Fix unexpected shown of Scrollbar by hgraceb · Pull Request #159386 · flutter/flutter

hgraceb · 2024-11-24T08:59:45Z

Fixes Narrow DatePickerDialog has unnecessary scrollbar on months with 6 rows #141348

Details

288 / 7 + 288 / 7 * 6 = 288.00000000000006

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

victorsanni

LGTM. cc @nate-thegrate who fixed a similar problem recently in NestedScrollView.

Piinks · 2024-12-03T23:16:10Z

packages/flutter/lib/src/widgets/scrollbar.dart

    _lastMetrics = metrics;
    _lastAxisDirection = axisDirection;

-    bool needPaint(ScrollMetrics? metrics) => metrics != null && metrics.maxScrollExtent > metrics.minScrollExtent;


Removing this public method would be a breaking change, can you revert that?

Much like in a previous PR by @hgraceb, the narrow GitHub diffs make it kinda difficult to see the context of this change. Fortunately this is a local function defined inside the ScrollbarPainter.update method, so I believe we're good 👍

As @nate-thegrate said, thanks for the explanation.

Oh it is indeed! Sorry I did not catch that! :)

nate-thegrate

One of the few things I remember from college is the huge potential for precision loss when evaluating the difference between two numbers that are very close together.

I also remember how difficult it was for me to figure out what was going wrong while working on #157756.

Thanks for catching this and implementing the fix!

nate-thegrate · 2024-12-04T01:00:31Z

packages/flutter/lib/src/widgets/scrollbar.dart

    _lastMetrics = metrics;
    _lastAxisDirection = axisDirection;

-    bool needPaint(ScrollMetrics? metrics) => metrics != null && metrics.maxScrollExtent > metrics.minScrollExtent;


Much like in a previous PR by @hgraceb, the narrow GitHub diffs make it kinda difficult to see the context of this change. Fortunately this is a local function defined inside the ScrollbarPainter.update method, so I believe we're good 👍

victorsanni · 2024-12-05T00:00:11Z

I'm investigating the google testing failures. I haven't looked too deeply but this change might be causing an issue with horizontal scrollbars.

hgraceb · 2024-12-11T09:46:29Z

I'm investigating the google testing failures. I haven't looked too deeply but this change might be causing an issue with horizontal scrollbars.

Is there any update or more information?

victorsanni · 2024-12-11T18:56:15Z

Is there any update or more information?

Still trying to reproduce. But the tests pass if I lower precisionErrorTolerance from 1e-10 to 1e-14.

victorsanni · 2024-12-17T23:38:28Z

@hgraceb this test in data_table_2 fails due to the changes in this PR:

https://github.com/maxim-saplin/data_table_2/blob/ceacea5279769fcd35b01e01f3eb21207c6fea61/test/custom_features_test.dart#L27

hgraceb · 2024-12-18T14:17:19Z

@victorsanni I can confirm that this test failed because it was written with an incorrect expected result. If you change the width from 250 to 250 + precisionErrorTolerance or 250 + 1e-10, this test will fail even without the changes from the current PR.

 testWidgets(
     'Horizontal scrollbar is visible if isHorizontalScrollBarVisible=true',
     (WidgetTester tester) async {
   await wrapWidgetSetSurf(tester,
-      buildTable(isHorizontalScrollBarVisible: true), const Size(250, 300));
+      buildTable(isHorizontalScrollBarVisible: true), const Size(250 + precisionErrorTolerance, 300));
 
   await tester.pumpAndSettle();
 
   expect(find.byType(Scrollbar).first, paints..rect());
 });

victorsanni · 2025-01-27T18:55:15Z

Hi @hgraceb, thanks for your patience. We're currently working on a patch to apply the fixes you proposed to the failing google tests, and will move forward with merging this PR once that work is done.

victorsanni · 2025-01-29T17:58:52Z

Hi @hgraceb, this PR has some merge conflicts. Once they are fixed, google testing should pass when rerun.

hgraceb · 2025-01-30T11:25:59Z

Hi @victorsanni, the Google tests are still failing. Are there any other unit tests that are broken?

Roll Flutter from b007899 to 8e2a6fc (61 revisions) flutter/flutter@b007899...8e2a6fc 2025-02-03 [email protected] Implement hot reload using the DDC library bundle format (flutter/flutter#162498) 2025-02-01 [email protected] [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527) 2025-02-01 [email protected] Fix `Linux docs_publish` running at head (flutter/flutter#162557) 2025-02-01 [email protected] [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104) 2025-02-01 [email protected] [Impeller] Increase conical gradient precision. (flutter/flutter#162543) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162542) 2025-01-31 [email protected] [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461) 2025-01-31 [email protected] [web] Remove HTML build artifacts (flutter/flutter#162528) 2025-01-31 [email protected] [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522) 2025-01-31 [email protected] Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423) 2025-01-31 [email protected] [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478) 2025-01-31 [email protected] Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409) 2025-01-31 [email protected] Fix NavigationRail examples overflow alignment (flutter/flutter#159937) 2025-01-31 [email protected] Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511) 2025-01-31 [email protected] Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504) 2025-01-31 [email protected] [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450) 2025-01-31 [email protected] fix syntax error in comment pseudocode (flutter/flutter#162453) 2025-01-31 [email protected] Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502) 2025-01-31 [email protected] Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162476) 2025-01-31 [email protected] Document flutter/package deps version policy (flutter/flutter#162492) 2025-01-31 [email protected] Add iOS tool codeowner (flutter/flutter#162167) 2025-01-31 [email protected] Fixed the text aspect ratio (flutter/flutter#162415) 2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494) 2025-01-31 [email protected] Add new web contributors to web triage doc. (flutter/flutter#162420) 2025-01-30 [email protected] Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484) 2025-01-30 [email protected] Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474) 2025-01-30 [email protected] Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475) 2025-01-30 [email protected] Delete `FlutterCommand.usageValues` (flutter/flutter#162468) 2025-01-30 [email protected] Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351) 2025-01-30 [email protected] Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411) 2025-01-30 [email protected] Add FormField.errorBuilder (flutter/flutter#162255) 2025-01-30 [email protected] Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081) 2025-01-30 [email protected] [Android] add HC++ platform view class. (flutter/flutter#161829) 2025-01-30 [email protected] Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425) 2025-01-30 [email protected] [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454) 2025-01-30 [email protected] [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835) 2025-01-30 [email protected] fix slider semantic label (flutter/flutter#162304) 2025-01-30 [email protected] Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447) 2025-01-30 [email protected] Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281) 2025-01-30 [email protected] remove more (simple) usage of package:usage (flutter/flutter#162354) 2025-01-30 [email protected] [Android] HC++ plumbing. (flutter/flutter#162407) 2025-01-30 [email protected] Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828) 2025-01-30 [email protected] Fix unexpected shown of Scrollbar (flutter/flutter#159386) 2025-01-30 [email protected] Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325) 2025-01-30 [email protected] Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427) ...

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Nov 24, 2024

goderbauer requested a review from victorsanni November 26, 2024 23:04

victorsanni approved these changes Dec 3, 2024

View reviewed changes

victorsanni requested a review from nate-thegrate December 3, 2024 21:34

Piinks reviewed Dec 3, 2024

View reviewed changes

nate-thegrate approved these changes Dec 4, 2024

View reviewed changes

hgraceb mentioned this pull request Dec 19, 2024

Fix the erroneous scrollbar tests maxim-saplin/data_table_2#330

Closed

hgraceb mentioned this pull request Jan 22, 2025

Scrollbar test written based on incorrect behavior maxim-saplin/data_table_2#344

Open

Fix unexpected shown of Scrollbar

2fff84c

hgraceb force-pushed the scroll_bar branch from 9db453c to 2fff84c Compare January 30, 2025 09:24

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

auto-submit bot added this pull request to the merge queue Jan 30, 2025

Merged via the queue into flutter:master with commit 1dd3f5d Jan 30, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

engine-flutter-autoroll mentioned this pull request Jan 30, 2025

Roll Flutter from b007899d3a7a to 1dd3f5d45bff (18 revisions) flutter/packages#8536

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

5600eb7

engine-flutter-autoroll mentioned this pull request Jan 30, 2025

Roll Flutter from b007899d3a7a to fffbf663ff34 (19 revisions) flutter/packages#8537

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

abec377

engine-flutter-autoroll mentioned this pull request Jan 30, 2025

Roll Flutter from b007899d3a7a to 1eecbf12568d (20 revisions) flutter/packages#8538

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

6cb63e1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

dee9103

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

8694e94

engine-flutter-autoroll mentioned this pull request Feb 1, 2025

Roll Flutter from b007899d3a7a to f56d5a98c1da (59 revisions) flutter/packages#8547

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

9b1c9c9

engine-flutter-autoroll mentioned this pull request Feb 1, 2025

Roll Flutter from b007899d3a7a to f56d5a98c1da (59 revisions) flutter/packages#8548

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

cab4272

engine-flutter-autoroll mentioned this pull request Feb 2, 2025

Roll Flutter from b007899d3a7a to 4d08217f8dca (60 revisions) flutter/packages#8549

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

1ec76dd

engine-flutter-autoroll mentioned this pull request Feb 2, 2025

Roll Flutter from b007899d3a7a to 4d08217f8dca (60 revisions) flutter/packages#8550

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

ac2557f

engine-flutter-autoroll mentioned this pull request Feb 3, 2025

Roll Flutter from b007899d3a7a to 8e2a6fc3fd2c (61 revisions) flutter/packages#8554

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

f06f6d5

engine-flutter-autoroll mentioned this pull request Feb 3, 2025

Roll Flutter from b007899d3a7a to 8e2a6fc3fd2c (61 revisions) flutter/packages#8556

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

0536254

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

56e45f0

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

78c4d74

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

1dd3f5d Fix unexpected shown of Scrollbar (flutter/flutter#159386)

7c2905c

Conversation

hgraceb commented Nov 24, 2024

Details

Pre-launch Checklist

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks Dec 3, 2024

Choose a reason for hiding this comment

Uh oh!

nate-thegrate Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

hgraceb Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

Piinks Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

nate-thegrate left a comment

Choose a reason for hiding this comment

Uh oh!

nate-thegrate Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

victorsanni commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hgraceb commented Dec 11, 2024

Uh oh!

victorsanni commented Dec 11, 2024

Uh oh!

victorsanni commented Dec 17, 2024

Uh oh!

hgraceb commented Dec 18, 2024

Uh oh!

victorsanni commented Jan 27, 2025

Uh oh!

victorsanni commented Jan 29, 2025

Uh oh!

hgraceb commented Jan 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

victorsanni commented Dec 5, 2024 •

edited

Loading