Fix RangeSlider thumb doesn't align with divisions, thumb padding, and rounded corners#159792
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Dec 9, 2024
TahaTesser:range_slider_issues
Merged
Fix RangeSlider thumb doesn't align with divisions, thumb padding, and rounded corners#159792auto-submit[bot] merged 1 commit intoflutter:masterfrom TahaTesser:range_slider_issues
RangeSlider thumb doesn't align with divisions, thumb padding, and rounded corners#159792auto-submit[bot] merged 1 commit intoflutter:masterfrom
TahaTesser:range_slider_issues
Conversation
…and rounded corners
Contributor
Author
|
@Piinks Hey! You reviewed similar PR for Slider so requested review here. :) |
Piinks
approved these changes
Dec 9, 2024
Contributor
Piinks
left a comment
There was a problem hiding this comment.
This also LGTM! The google testing failures are okay to me too, they are all typical hairline diffs around sliders as expected from this change.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2024
…adding, and rounded corners (flutter/flutter#159792)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2024
…adding, and rounded corners (flutter/flutter#159792)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2024
…adding, and rounded corners (flutter/flutter#159792)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2024
…adding, and rounded corners (flutter/flutter#159792)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2024
…adding, and rounded corners (flutter/flutter#159792)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2024
…adding, and rounded corners (flutter/flutter#159792)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…adding, and rounded corners (flutter/flutter#159792)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…adding, and rounded corners (flutter/flutter#159792)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…adding, and rounded corners (flutter/flutter#159792)
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
…adding, and rounded corners (flutter/flutter#159792)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…adding, and rounded corners (flutter/flutter#159792)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…adding, and rounded corners (flutter/flutter#159792)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
…adding, and rounded corners (flutter/flutter#159792)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
…adding, and rounded corners (flutter/flutter#159792)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
RangeSliderthumb's center doesn't align with division's center, thumb padding, and rounded corners don't work as expectedThis makes a similar fix as the one for
Sliderin #149594. This fix is essential to bring updated Material Design forRangeSlider.Code sample
expand to view the code sample
Before
After
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.