CupertinoTextField accessibility behavior on Linux should match TextField#159823
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Dec 10, 2024
Merged
Conversation
github-actions
bot
added
a: text input
Renzo-Olivares
changed the title
CupertinoTextField accessibility behavior should match TextField on LinuxCupertinoTextField accessibility behavior on Linux should match TextField
Renzo-Olivares
force-pushed
the
cupertino-a11y-updates
branch
from
5d33d3f to
2afbff6
Compare
justinmc
approved these changes
Dec 10, 2024
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM, good catch!
Do you think it would be possible to define this Semantics stuff at the EditableText level so it's not duplicated across TextField and CupertinoTextField? That's the real core of the problem here. Not for this PR but I'm just curious for the future.
Contributor
Author
|
I think that's a great idea! I had that same thought when catching this. I'll try to investigate how possible that is, and also see what else we can move down to |
Renzo-Olivares
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…atch `TextField` (flutter/flutter#159823)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…atch `TextField` (flutter/flutter#159823)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…atch `TextField` (flutter/flutter#159823)
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
…atch `TextField` (flutter/flutter#159823)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…atch `TextField` (flutter/flutter#159823)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…atch `TextField` (flutter/flutter#159823)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
…atch `TextField` (flutter/flutter#159823)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
…atch `TextField` (flutter/flutter#159823)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While going through
TextFieldandCupertinoTextFieldI noticed #94898 and #129652 did not make it over toCupertinoTextField. This PR brings over those changes toCupertinoTextField. On Linux after this change theCupertinoTextFieldnow focuses when gaining a11y focus, and unfocuses when losing a11y focus.Pre-launch Checklist
///).