Use the VM service to proxy goldenComparator for integration testing#160131
Closed
matanlurey wants to merge 4 commits intoflutter:masterfrom
Closed
Use the VM service to proxy goldenComparator for integration testing#160131matanlurey wants to merge 4 commits intoflutter:masterfrom
goldenComparator for integration testing#160131matanlurey wants to merge 4 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
a: tests
This was referenced Dec 13, 2024
Merged
Closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
…S) integration tests (#160215) Part of #160043, makes it easier to add #160131. This PR has no functional changes to any of the code, but does refactor both the code and tests: - Makes a number of always non-null but not migrated to non-null properties, well, not-null - Creates two concrete methods (`update` and `compare` versus a positional nullable boolean) - Uses type signatures instead of `String?` to explain the possible results of the methods - Renames the mysterious `shellPath` variable to `flutterTesterBinPath` - Expands and rewrites internally-facing doc comments - Moves `WebRenderer` environment variable setting to `flutter_web_platform.dart` - Makes the tests have less duplication, and check for update/compare cases After this PR, I can use it in the non-web branch of the Flutter tool without any hacks or TODOS :) /cc @eyebrowsoffire (trivial web refactoring), @camsim99 (changes being made to tool).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prospective implementation, as a proof of concept, for #160043.
This re-uses
TestGoldenComparator, which was written for Flutter Web (which, similar to Android and iOS, can't do golden-file comparisons on "device"), but this time would apply them to Android and iOS builds as well (though in this PR, no conditional logic is applied).What works:
flutter_toolsCLI) listens on the VM serviceWhat doesn't:
flutter_toolsCLI) doesn't get the event the client sentThe console output at the current commit looks like this:
I'm perhaps doing something wrong, so I'll get some help tomorrow.