Make AppContext API not be prone to Future oddities#16034
Merged
tvolkert merged 1 commit intoflutter:masterfrom Mar 28, 2018
tvolkert:context-post-review
Merged
Make AppContext API not be prone to Future oddities#16034tvolkert merged 1 commit intoflutter:masterfrom tvolkert:context-post-review
tvolkert merged 1 commit intoflutter:masterfrom
tvolkert:context-post-review
Conversation
Follow-up comments to #15984
yjbanov
approved these changes
Mar 28, 2018
Contributor
|
|
Contributor
Author
|
Landing on red because @aam has deemed the current redness to be a flake. |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Follow-up comments to flutter#15984
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up comments to #15984