Adds Java EE module to SDK manager calls#16035
Merged
tvolkert merged 1 commit intoflutter:masterfrom Apr 3, 2018
lukef:lf-sdkmanager-fix
Merged
Adds Java EE module to SDK manager calls#16035tvolkert merged 1 commit intoflutter:masterfrom lukef:lf-sdkmanager-fix
tvolkert merged 1 commit intoflutter:masterfrom
lukef:lf-sdkmanager-fix
Conversation
…brary exception when checking for licenses.
Member
|
On my machine, this triggers the following error, which causes #16025 to return A run of |
Contributor
|
I get the same error with this change. I'm going to revert. @lukef can you repro the problem, then re-submit the patch with a version that works in all environments? |
Contributor
|
Revert PR: #16227 |
tvolkert
added a commit
that referenced
this pull request
Apr 4, 2018
This was referenced Apr 4, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
…brary exception when checking for licenses. (flutter#16035)
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an environment variable to the Android SDK Manager calls that re-enables the deprecated java EE module to allow SDK manager to run. This is a workaround and the fix should be done in the Android tools. However, without that fix, Flutter will be broken.
Fixes: #16025
See:
https://bugs.openjdk.java.net/browse/JDK-8189188
https://stackoverflow.com/questions/47150410/failed-to-run-sdkmanager-list-android-sdk-with-java-9