[DatePickerThemeData] Add Subheader Color Customization#161483
[DatePickerThemeData] Add Subheader Color Customization#161483AffanShaikhsurab wants to merge 9 commits intoflutter:masterfrom
Conversation
…r color customization in DatePickerThemeData. Previously, it was not possible to directly modify the subheader styling without relying on onSurface color in the colorScheme.
github-actions
bot
added
framework
|
@AffanShaikhsurab Please complete the prelaunch checklist by checking the ones that apply
I am not the right person to review. To escalate the review process I would suggest reaching out to flutter team members on discord. |
yeah sure , are there any specifc members i should approch too !!? |
|
Just ask if someone can give feedback on this PR and you should have the right person taking a look. Reviewers are busy with other issues, so someone should take a look at this one as soon as they can. you may find reviewers by looking at issues/PRs with similar tags material design, framework |
Sure thanks a lot |
|
One of the pre-launch checklist items:
For future reference, that page recommends waiting 2 weeks before reaching out on Discord, to allow time for the contribution to go through the normal PR triage process. |
I will make sure of it from now on |
removed blank line . as mentioned in the error The error messages reported above are repeated here: -- This line intentionally left blank -- /b/s/w/ir/x/w/flutter/packages/flutter/lib/src/material/date_picker_theme.dart:1164: trailing U+0020 space character in Linux analyze
QuncCccccc
left a comment
QuncCccccc
left a comment
There was a problem hiding this comment.
Thanks so much for your contribution! There's a similar PR #161458 and that one seems provide more flexibility that we can customize the text button and the toggle button colors separately. Would you mind if I review that one first?
Yeah, sure! If that offers a better approach, then it's definitely better. |
|
Thanks so much for your understanding:) |
|
Per the conversation here, I am going to close this PR. Thank you for contributing @AffanShaikhsurab! It is much appreciated. :) |
5 participants
This PR addresses issue #160591 by adding support for subheader color customization in
DatePickerThemeData. Previously, it was not possible to directly modify the subheader styling without relying ononSurfacecolor in thecolorScheme.Changes
subheaderColortoDatePickerThemeData.calendar_date_picker.dartimplementation to useDatePickerThemeData.subheaderColorif defined, falling back to the previous behavior if null.Code Behavior
subheaderColoris set, it overrides the default styling of the subheader.Theme.of(context).colorScheme.onSurface.withOpacity(0.60)whensubheaderColoris not specified.Before
Using
colorScheme: ColorScheme.light(onSurface: Colors.orange),After
Using
subheaderColor : Colors.orange ,in DatePickerThemeDataPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.