Skip to content

Add button flag to NavigationDestination#161568

Merged
auto-submit[bot] merged 8 commits intoflutter:masterfrom
QuncCccccc:nav_bar_a11y
Feb 4, 2025
Merged

Add button flag to NavigationDestination#161568
auto-submit[bot] merged 8 commits intoflutter:masterfrom
QuncCccccc:nav_bar_a11y

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Jan 14, 2025 •
edited
Loading

This PR is to add Semantics.button to NavigationDestination so that when the switch control on iOS is turned on, it can traverse the unselected destinations.

Fixes #161563

nav_bar_a11y.mp4

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 14, 2025
@QuncCccccc QuncCccccc marked this pull request as draft January 14, 2025 20:05
@QuncCccccc QuncCccccc changed the title Add focusable flag to NavigationDestination Add button flag to NavigationDestination Jan 28, 2025
@QuncCccccc QuncCccccc marked this pull request as ready for review January 28, 2025 21:49
@QuncCccccc QuncCccccc requested a review from chunhtai January 28, 2025 22:04
chunhtai
chunhtai approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025
@QuncCccccc QuncCccccc linked an issue Jan 29, 2025 that may be closed by this pull request
[a11y][iOS] bottomNavigationBar cannot be navigated using Switch Control #160033
Closed
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 30, 2025

autosubmit label was removed for flutter/flutter/161568, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025
@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Jan 30, 2025 •
edited
Loading

g3fix attached cl/721136198

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 30, 2025

autosubmit label was removed for flutter/flutter/161568, because - The status or check suite Mac_arm64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac_x64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_x64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_impeller has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux_android_emu_34 android_defines_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux_android_emu android_defines_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_skwasm_tests_7_last has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_skwasm_tests_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_skwasm_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_skwasm_tests_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_skwasm_tests_1 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_skwasm_tests_0 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_7_last has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_1 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_long_running_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_long_running_tests_4_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_long_running_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_long_running_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_long_running_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux_android_emu android_engine_opengles_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux_android_emu android_engine_vulkan_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests_slow has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux docs_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux build_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux build_tests_4_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux build_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux build_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux build_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux_android_emu_34 android views has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux skp_generator has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 30, 2025

autosubmit label was removed for flutter/flutter/161568, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025
@QuncCccccc QuncCccccc force-pushed the nav_bar_a11y branch 3 times, most recently from 491e3c2 to a2fc00a Compare January 31, 2025 23:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
4406a76 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
a92dab6 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
363fc99 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
13e67a2 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
c96b50d 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
838ee99 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
81e79f5 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
fdfc2f7 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
1a30787 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
50c1c54 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
e9c2bf8 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
d724170 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
d9f91c2 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
cf362e4 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
d1988b6 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
af9e818 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
6f0514a 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
659b10d 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
ec0ad5f 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
2b6096e 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
b1f4751 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
f8212bb 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
fd4cbfc 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
086f63b 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
b3c97f6 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
d7458fd 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
56190fb Add button flag to NavigationDestination (flutter/flutter#161568
726d420 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch Control does not focus on unselected NavigationBar destinations (iOS) [a11y][iOS] bottomNavigationBar cannot be navigated using Switch Control

2 participants

@QuncCccccc @chunhtai