Manual roll of Skia to e7b8d078851f by jason-simmons · Pull Request #161609 · flutter/flutter

jason-simmons · 2025-01-14T18:52:03Z

The Skia->engine roller was disabled for a few weeks during the migration to the monorepo.

…en the file is truncated

jason-simmons · 2025-01-14T21:19:56Z

A test in codec_test.dart had to be updated due to a change in Skia behavior. The test was trying to force a decode error in a JPEG image. But Skia will now output an image if a progressive JPEG can be partially decoded.

See https://skia.googlesource.com/skia/+/e56496eb35a3e20114d1a0052348e43b363f3cd4

This is an invalid test image file that is incompatible with web codecs

jason-simmons · 2025-01-15T02:19:15Z

https://skia.googlesource.com/skia/+/e56496eb35a3e20114d1a0052348e43b363f3cd4 also added a test image file that contains invalid data for testing error handling.

This image needs to be excluded from Flutter Web tests that feed the Skia test images to web codecs.

flutter/flutter@40c2b86...5517cc9 2025-01-15 [email protected] feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161680) 2025-01-15 [email protected] Revert "Autocomplete Options Width" (flutter/flutter#161666) 2025-01-15 [email protected] Update two_dimensional_scrollables triage routing (flutter/flutter#161667) 2025-01-15 [email protected] [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652) 2025-01-15 [email protected] Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672) 2025-01-15 [email protected] Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427) 2025-01-15 [email protected] Manual roll of Skia to e7b8d078851f (flutter/flutter#161609) 2025-01-15 [email protected] Fix `TabBar` glitchy elastic `Tab` animation (flutter/flutter#161514) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161643) 2025-01-15 [email protected] Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161632) 2025-01-15 [email protected] Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534) 2025-01-15 [email protected] [Impeller] null check device buffer in image encoding. (flutter/flutter#161194) 2025-01-15 [email protected] Feature/twitter keyboard (flutter/flutter#161025) 2025-01-15 [email protected] Fixed XiaoMi statusBar Bug (flutter/flutter#161271) 2025-01-15 [email protected] Clean up engine's analysis_options.yaml (flutter/flutter#161554) 2025-01-14 [email protected] Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622) 2025-01-14 [email protected] [deps] remove no-longer-used repo deps (flutter/flutter#161605) 2025-01-14 [email protected] [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553) 2025-01-14 [email protected] [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409) 2025-01-14 [email protected] [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464) 2025-01-14 [email protected] [canvaskit] Fix GIF decode failure (flutter/flutter#161536) 2025-01-14 [email protected] [Impeller] fixes for AHB swapchains. (flutter/flutter#161562) 2025-01-14 [email protected] Last Engine<>Framework lint sync (flutter/flutter#161560) 2025-01-14 [email protected] Check that localization files of stocks app are up-to-date (flutter/flutter#161608) 2025-01-14 [email protected] [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343) 2025-01-14 [email protected] Update package revisions to latest (flutter/flutter#161525) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Manual roll of Skia to e7b8d078851f

386fbf7

The Skia->engine roller was disabled for a few weeks during the migration to the monorepo.

github-actions bot added the engine flutter/engine related. See also e: labels. label Jan 14, 2025

jason-simmons requested a review from jtmcdole January 14, 2025 18:52

jtmcdole approved these changes Jan 14, 2025

View reviewed changes

Update codec_test to use an image that will produce a decode error wh…

008eb98

…en the file is truncated

jason-simmons added 2 commits January 14, 2025 22:53

licenses

b6c79e9

Exclude progressive_kitten_missing_eof.jpg from web tests

6b8dce9

This is an invalid test image file that is incompatible with web codecs

github-actions bot added the platform-web Web applications specifically label Jan 15, 2025

final var

2cfb2b5

jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 15, 2025

auto-submit bot added this pull request to the merge queue Jan 15, 2025

Merged via the queue into flutter:master with commit 1e79b65 Jan 15, 2025

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 15, 2025

engine-flutter-autoroll mentioned this pull request Jan 15, 2025

Roll Flutter from 40c2b86fdf65 to 44ff2f59774b (22 revisions) flutter/packages#8436

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

20ea943

engine-flutter-autoroll mentioned this pull request Jan 15, 2025

Roll Flutter from 40c2b86fdf65 to 1580a3d3fbe7 (23 revisions) flutter/packages#8437

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

55b84c6

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

bf89539

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

d994f9f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

a21b11b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

03580e9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

85653cb

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

546d56d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

4aaa26d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

3598aec

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

f0fdb4a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

d87c25a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

6085d49

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

d8b3c00

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

fea76c6

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

1e79b65 Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)

ab749bb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manual roll of Skia to e7b8d078851f#161609

Manual roll of Skia to e7b8d078851f#161609
auto-submit[bot] merged 5 commits intoflutter:masterfrom
jason-simmons:roll_skia_011425

jason-simmons commented Jan 14, 2025

Uh oh!

jason-simmons commented Jan 14, 2025

Uh oh!

jason-simmons commented Jan 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jason-simmons commented Jan 14, 2025

Uh oh!

jason-simmons commented Jan 14, 2025

Uh oh!

jason-simmons commented Jan 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants