Skip to content

[Impeller] backfilling TextContents unit tests#161625

Merged
gaaclarke merged 17 commits intoflutter:masterfrom
gaaclarke:text_contents_tests
Jan 21, 2025
Merged

[Impeller] backfilling TextContents unit tests#161625
gaaclarke merged 17 commits intoflutter:masterfrom
gaaclarke:text_contents_tests

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Jan 14, 2025 •
edited
Loading

issue: #149652

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 14, 2025
@gaaclarke gaaclarke marked this pull request as ready for review January 16, 2025 23:23
@gaaclarke gaaclarke changed the title Text contents tests [Impeller] backfilling TextContents unit tests Jan 16, 2025
jonahwilliams
jonahwilliams approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 17, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 17, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 17, 2025

auto label is removed for flutter/flutter/161625, due to - The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gaaclarke gaaclarke force-pushed the text_contents_tests branch from 2ff9694 to 099ffc3 Compare January 17, 2025 21:20
@gaaclarke
Copy link
Member Author

gaaclarke commented Jan 17, 2025 •
edited
Loading

Oh interesting, we get all different results in Metal/OpenGLES/Vulkan. edit: (on linux)

@gaaclarke gaaclarke force-pushed the text_contents_tests branch from 184d9cb to 599b675 Compare January 21, 2025 16:24
@gaaclarke gaaclarke added this pull request to the merge queue Jan 21, 2025
Merged via the queue into flutter:master with commit 52cfc8b Jan 21, 2025
178 checks passed
@gaaclarke gaaclarke deleted the text_contents_tests branch January 21, 2025 21:07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2025
@engine-flutter-autoroll
52cfc8b [Impeller] backfilling TextContents unit tests (flutter/flutt…
a8f0b85 
…er#161625)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2025
@engine-flutter-autoroll
52cfc8b [Impeller] backfilling TextContents unit tests (flutter/flutt…
efc7839 
…er#161625)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2025
@engine-flutter-autoroll
52cfc8b [Impeller] backfilling TextContents unit tests (flutter/flutt…
af66192 
…er#161625)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) (#8482)
b346343 
Manual roll Flutter from b9e86a5 to b2f515f (42 revisions)

Manual roll requested by [email protected]

flutter/flutter@b9e86a5...b2f515f

2025-01-22 [email protected] Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035)
2025-01-22 [email protected] `const AnimationStyle` (flutter/flutter#160564)
2025-01-22 [email protected] Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020)
2025-01-22 [email protected] [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855)
2025-01-22 [email protected] Experiment with a `files-changed.json` per PR (flutter/flutter#161788)
2025-01-22 [email protected] Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925)
2025-01-22 [email protected] Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019)
2025-01-22 [email protected] Adds cupertino picker semantics test (flutter/flutter#161768)
2025-01-22 [email protected] [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775)
2025-01-22 [email protected] fix: Add enabled property for search anchor named constructor (flutter/flutter#161468)
2025-01-22 [email protected] Roll pub packages (flutter/flutter#162015)
2025-01-22 [email protected] [web] Remove spam from test output (flutter/flutter#161774)
2025-01-22 [email protected] Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577)
2025-01-22 [email protected] Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016)
2025-01-22 [email protected] Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622)
2025-01-22 [email protected] [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537)
2025-01-22 [email protected] Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991)
2025-01-22 [email protected] Fix incorrect [enabled] documentation (flutter/flutter#161650)
2025-01-22 [email protected] Add `windows_host_engine_test`. (flutter/flutter#161992)
2025-01-22 [email protected] Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989)
2025-01-22 [email protected] Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024)
2025-01-22 [email protected] [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981)
2025-01-22 [email protected] Merge changelog for 3.27.3 release (flutter/flutter#161977)
2025-01-21 [email protected] Remove FlKeyboardViewDelegate (flutter/flutter#161705)
2025-01-21 [email protected] Fix documentation of Flow.clipBehavior (flutter/flutter#161863)
2025-01-21 [email protected] [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841)
2025-01-21 [email protected] [Impeller] backfilling TextContents unit tests (flutter/flutter#161625)
2025-01-21 [email protected] Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824)
2025-01-21 [email protected] fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301)
2025-01-21 [email protected] Get `et` working for local web engine builds. (flutter/flutter#161825)
2025-01-21 [email protected] Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994)
2025-01-21 [email protected] Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656)
2025-01-21 [email protected] Don't crash flutter tool if Chrome is not available (flutter/flutter#154941)
2025-01-21 [email protected] Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717)
2025-01-21 [email protected] [native assets] Cleanup dead code 2 (flutter/flutter#161916)
2025-01-21 [email protected] Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811)
2025-01-21 [email protected] Roll pub packages (flutter/flutter#161924)
2025-01-21 [email protected] Make `PipelineOwner` a `base` class (flutter/flutter#161789)
2025-01-20 [email protected] [native assets] Cleanup dead code (flutter/flutter#161913)
2025-01-20 [email protected] Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914)
2025-01-20 [email protected] [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917)
2025-01-19 [email protected] Update documentation on what display information is provided. (flutter/flutter#161785)

If this roll has caused a breakage, revert this CL and stop the roller
...
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025
@gaaclarke
[Impeller] backfilling TextContents unit tests (flutter#161625)
1e0a920 
issue: flutter#149652

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Feb 11, 2025
@gaaclarke
[Impeller] backfilling TextContents unit tests (flutter#161625)
7d203d5 
issue: flutter#149652

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Feb 11, 2025
@gaaclarke
[Impeller] backfilling TextContents unit tests (flutter#161625)
7700dca 
issue: flutter#149652

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@gaaclarke gaaclarke mentioned this pull request Feb 11, 2025
Merged
9 tasks
auto-submit bot pushed a commit that referenced this pull request Feb 20, 2025
@gaaclarke
[CP] all jittery glyph fixes (#163058)
d73fc34 
This is a cherry-pick for all the changes that went into fixing #149652

It looks like a lot but most of it is testing and refactoring.

## PRs included
- #161625
- #162351
- #162415
- #162555
- #162824

## Impacted Users

All users of Impeller.

## Impact Description

Animating text with translations and scales can cause:
  - jitter between glyphs
  - jitter between glyphs and the baseline
  - artifacts when rendering glyphs at non integer scales

## Workaround

Use skia.

## Risk

Since this edits how text is rendered, the risk is pretty high.  The actual changes are small and there are unit tests for them.  Golden test coverage for cherry-picks is not complete and text rendering golden coverage for android is problematic.

## Test Coverage

Yes.

## Validation Steps

The reproduction code in #149652 is good.
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
@gaaclarke @Fintasys
[CP] all jittery glyph fixes (flutter#163058)
895b258 
This is a cherry-pick for all the changes that went into fixing flutter#149652

It looks like a lot but most of it is testing and refactoring.

- flutter#161625
- flutter#162351
- flutter#162415
- flutter#162555
- flutter#162824

All users of Impeller.

Animating text with translations and scales can cause:
  - jitter between glyphs
  - jitter between glyphs and the baseline
  - artifacts when rendering glyphs at non integer scales

Use skia.

Since this edits how text is rendered, the risk is pretty high.  The actual changes are small and there are unit tests for them.  Golden test coverage for cherry-picks is not complete and text rendering golden coverage for android is problematic.

Yes.

The reproduction code in flutter#149652 is good.
CodixNinja pushed a commit to CodixNinja/flutter that referenced this pull request May 15, 2025
@gaaclarke
[CP] all jittery glyph fixes (#163058)
d4fe28c 
This is a cherry-pick for all the changes that went into fixing flutter/flutter#149652

It looks like a lot but most of it is testing and refactoring.

## PRs included
- flutter/flutter#161625
- flutter/flutter#162351
- flutter/flutter#162415
- flutter/flutter#162555
- flutter/flutter#162824

## Impacted Users

All users of Impeller.

## Impact Description

Animating text with translations and scales can cause:
  - jitter between glyphs
  - jitter between glyphs and the baseline
  - artifacts when rendering glyphs at non integer scales

## Workaround

Use skia.

## Risk

Since this edits how text is rendered, the risk is pretty high.  The actual changes are small and there are unit tests for them.  Golden test coverage for cherry-picks is not complete and text rendering golden coverage for android is problematic.

## Test Coverage

Yes.

## Validation Steps

The reproduction code in flutter/flutter#149652 is good.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
52cfc8b [Impeller] backfilling TextContents unit tests (flutter/flutt…
345c2ce 
…er#161625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
52cfc8b [Impeller] backfilling TextContents unit tests (flutter/flutt…
e8a5530 
…er#161625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
52cfc8b [Impeller] backfilling TextContents unit tests (flutter/flutt…
1e4ecb0 
…er#161625)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) (flutter#8482
3b38e95 
)

Manual roll Flutter from b9e86a5 to b2f515f (42 revisions)

Manual roll requested by [email protected]

flutter/flutter@b9e86a5...b2f515f

2025-01-22 [email protected] Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035)
2025-01-22 [email protected] `const AnimationStyle` (flutter/flutter#160564)
2025-01-22 [email protected] Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020)
2025-01-22 [email protected] [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855)
2025-01-22 [email protected] Experiment with a `files-changed.json` per PR (flutter/flutter#161788)
2025-01-22 [email protected] Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925)
2025-01-22 [email protected] Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019)
2025-01-22 [email protected] Adds cupertino picker semantics test (flutter/flutter#161768)
2025-01-22 [email protected] [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775)
2025-01-22 [email protected] fix: Add enabled property for search anchor named constructor (flutter/flutter#161468)
2025-01-22 [email protected] Roll pub packages (flutter/flutter#162015)
2025-01-22 [email protected] [web] Remove spam from test output (flutter/flutter#161774)
2025-01-22 [email protected] Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577)
2025-01-22 [email protected] Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016)
2025-01-22 [email protected] Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622)
2025-01-22 [email protected] [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537)
2025-01-22 [email protected] Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991)
2025-01-22 [email protected] Fix incorrect [enabled] documentation (flutter/flutter#161650)
2025-01-22 [email protected] Add `windows_host_engine_test`. (flutter/flutter#161992)
2025-01-22 [email protected] Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989)
2025-01-22 [email protected] Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024)
2025-01-22 [email protected] [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981)
2025-01-22 [email protected] Merge changelog for 3.27.3 release (flutter/flutter#161977)
2025-01-21 [email protected] Remove FlKeyboardViewDelegate (flutter/flutter#161705)
2025-01-21 [email protected] Fix documentation of Flow.clipBehavior (flutter/flutter#161863)
2025-01-21 [email protected] [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841)
2025-01-21 [email protected] [Impeller] backfilling TextContents unit tests (flutter/flutter#161625)
2025-01-21 [email protected] Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824)
2025-01-21 [email protected] fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301)
2025-01-21 [email protected] Get `et` working for local web engine builds. (flutter/flutter#161825)
2025-01-21 [email protected] Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994)
2025-01-21 [email protected] Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656)
2025-01-21 [email protected] Don't crash flutter tool if Chrome is not available (flutter/flutter#154941)
2025-01-21 [email protected] Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717)
2025-01-21 [email protected] [native assets] Cleanup dead code 2 (flutter/flutter#161916)
2025-01-21 [email protected] Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811)
2025-01-21 [email protected] Roll pub packages (flutter/flutter#161924)
2025-01-21 [email protected] Make `PipelineOwner` a `base` class (flutter/flutter#161789)
2025-01-20 [email protected] [native assets] Cleanup dead code (flutter/flutter#161913)
2025-01-20 [email protected] Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914)
2025-01-20 [email protected] [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917)
2025-01-19 [email protected] Update documentation on what display information is provided. (flutter/flutter#161785)

If this roll has caused a breakage, revert this CL and stop the roller
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) (flutter#8482
1e59947 
)

Manual roll Flutter from b9e86a5 to b2f515f (42 revisions)

Manual roll requested by [email protected]

flutter/flutter@b9e86a5...b2f515f

2025-01-22 [email protected] Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035)
2025-01-22 [email protected] `const AnimationStyle` (flutter/flutter#160564)
2025-01-22 [email protected] Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020)
2025-01-22 [email protected] [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855)
2025-01-22 [email protected] Experiment with a `files-changed.json` per PR (flutter/flutter#161788)
2025-01-22 [email protected] Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925)
2025-01-22 [email protected] Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019)
2025-01-22 [email protected] Adds cupertino picker semantics test (flutter/flutter#161768)
2025-01-22 [email protected] [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775)
2025-01-22 [email protected] fix: Add enabled property for search anchor named constructor (flutter/flutter#161468)
2025-01-22 [email protected] Roll pub packages (flutter/flutter#162015)
2025-01-22 [email protected] [web] Remove spam from test output (flutter/flutter#161774)
2025-01-22 [email protected] Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577)
2025-01-22 [email protected] Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016)
2025-01-22 [email protected] Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622)
2025-01-22 [email protected] [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537)
2025-01-22 [email protected] Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991)
2025-01-22 [email protected] Fix incorrect [enabled] documentation (flutter/flutter#161650)
2025-01-22 [email protected] Add `windows_host_engine_test`. (flutter/flutter#161992)
2025-01-22 [email protected] Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989)
2025-01-22 [email protected] Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024)
2025-01-22 [email protected] [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981)
2025-01-22 [email protected] Merge changelog for 3.27.3 release (flutter/flutter#161977)
2025-01-21 [email protected] Remove FlKeyboardViewDelegate (flutter/flutter#161705)
2025-01-21 [email protected] Fix documentation of Flow.clipBehavior (flutter/flutter#161863)
2025-01-21 [email protected] [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841)
2025-01-21 [email protected] [Impeller] backfilling TextContents unit tests (flutter/flutter#161625)
2025-01-21 [email protected] Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824)
2025-01-21 [email protected] fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301)
2025-01-21 [email protected] Get `et` working for local web engine builds. (flutter/flutter#161825)
2025-01-21 [email protected] Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994)
2025-01-21 [email protected] Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656)
2025-01-21 [email protected] Don't crash flutter tool if Chrome is not available (flutter/flutter#154941)
2025-01-21 [email protected] Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717)
2025-01-21 [email protected] [native assets] Cleanup dead code 2 (flutter/flutter#161916)
2025-01-21 [email protected] Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811)
2025-01-21 [email protected] Roll pub packages (flutter/flutter#161924)
2025-01-21 [email protected] Make `PipelineOwner` a `base` class (flutter/flutter#161789)
2025-01-20 [email protected] [native assets] Cleanup dead code (flutter/flutter#161913)
2025-01-20 [email protected] Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914)
2025-01-20 [email protected] [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917)
2025-01-19 [email protected] Update documentation on what display information is provided. (flutter/flutter#161785)

If this roll has caused a breakage, revert this CL and stop the roller
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdero bdero Awaiting requested review from bdero

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaaclarke @jonahwilliams