Experiment with a `files-changed.json` per PR by matanlurey · Pull Request #161788 · flutter/flutter

matanlurey · 2025-01-17T04:40:18Z

This is an experiment to determine what the wall time of a (minimal) "upload a JSON file describing files changed".

We are looking for this to take (low) single digit minutes, because if we use this file (and expand it to become a build plan), it will block almost all other actions, and will likely get longer as we add more complex logic and checks. Here's hoping!

jtmcdole · 2025-01-17T20:51:33Z

.github/workflows/files-changed.yml

+        # Fetch what to compare the commit against
+        run: |
+          git fetch origin ${{ github.event.pull_request.base.sha }}
+          git fethc origin/master


s/fethc/fetch

jtmcdole · 2025-01-17T20:57:22Z

dev/tools/bin/get_files_changed.dart

+
+  // Get a list of files changed between this commit and the base SHA.
+  final List<String> filesChanged;
+  {


Why the block?

It's not necessary, just encloses some local variables (i.e. stdout) that have no purpose outside the block.

matanlurey · 2025-01-21T17:26:27Z

I'd like to land this to measure the impact of this running, though it should (more or less) be a NOP.

matanlurey · 2025-01-22T03:10:27Z

CI failures are due to a stray debug print I'll remove.

matanlurey · 2025-01-22T03:11:11Z

Ping @jtmcdole @yjbanov (not urgent but I'd love to merge this tomorrow so we can get a couple of days of stability and speed analysis).

auto-submit · 2025-01-22T18:09:00Z

auto label is removed for flutter/flutter/161788, due to - The status or check suite Linux mac_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Merge Queue Guard has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-01-22T18:11:05Z

auto label is removed for flutter/flutter/161788, due to - The status or check suite Merge Queue Guard has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-01-22T20:21:06Z

auto label is removed for flutter/flutter/161788, due to - The status or check suite Mac_x64 hot_mode_dev_cycle_macos_target__benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.

…r#161788)

Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) Manual roll requested by [email protected] flutter/flutter@b9e86a5...b2f515f 2025-01-22 [email protected] Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035) 2025-01-22 [email protected] `const AnimationStyle` (flutter/flutter#160564) 2025-01-22 [email protected] Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020) 2025-01-22 [email protected] [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855) 2025-01-22 [email protected] Experiment with a `files-changed.json` per PR (flutter/flutter#161788) 2025-01-22 [email protected] Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925) 2025-01-22 [email protected] Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019) 2025-01-22 [email protected] Adds cupertino picker semantics test (flutter/flutter#161768) 2025-01-22 [email protected] [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775) 2025-01-22 [email protected] fix: Add enabled property for search anchor named constructor (flutter/flutter#161468) 2025-01-22 [email protected] Roll pub packages (flutter/flutter#162015) 2025-01-22 [email protected] [web] Remove spam from test output (flutter/flutter#161774) 2025-01-22 [email protected] Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577) 2025-01-22 [email protected] Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016) 2025-01-22 [email protected] Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622) 2025-01-22 [email protected] [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537) 2025-01-22 [email protected] Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991) 2025-01-22 [email protected] Fix incorrect [enabled] documentation (flutter/flutter#161650) 2025-01-22 [email protected] Add `windows_host_engine_test`. (flutter/flutter#161992) 2025-01-22 [email protected] Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989) 2025-01-22 [email protected] Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024) 2025-01-22 [email protected] [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981) 2025-01-22 [email protected] Merge changelog for 3.27.3 release (flutter/flutter#161977) 2025-01-21 [email protected] Remove FlKeyboardViewDelegate (flutter/flutter#161705) 2025-01-21 [email protected] Fix documentation of Flow.clipBehavior (flutter/flutter#161863) 2025-01-21 [email protected] [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841) 2025-01-21 [email protected] [Impeller] backfilling TextContents unit tests (flutter/flutter#161625) 2025-01-21 [email protected] Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824) 2025-01-21 [email protected] fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301) 2025-01-21 [email protected] Get `et` working for local web engine builds. (flutter/flutter#161825) 2025-01-21 [email protected] Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994) 2025-01-21 [email protected] Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656) 2025-01-21 [email protected] Don't crash flutter tool if Chrome is not available (flutter/flutter#154941) 2025-01-21 [email protected] Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717) 2025-01-21 [email protected] [native assets] Cleanup dead code 2 (flutter/flutter#161916) 2025-01-21 [email protected] Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811) 2025-01-21 [email protected] Roll pub packages (flutter/flutter#161924) 2025-01-21 [email protected] Make `PipelineOwner` a `base` class (flutter/flutter#161789) 2025-01-20 [email protected] [native assets] Cleanup dead code (flutter/flutter#161913) 2025-01-20 [email protected] Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914) 2025-01-20 [email protected] [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917) 2025-01-19 [email protected] Update documentation on what display information is provided. (flutter/flutter#161785) If this roll has caused a breakage, revert this CL and stop the roller ...

aam · 2025-01-23T17:53:50Z

bin/internal/update_engine_version.sh

+# file an issue if you have workflow needs.
+if [ -n "${FLUTTER_ENGINE_VERSION}" ]; then
+  ENGINE_VERSION="${FLUTTER_ENGINE_VERSION}"
+  echo "[Unstable] Override: Setting engine SHA to $ENGINE_VERSION" 1>&2


Note that engine.version override is also happening on dart/flutter hh: https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine_v2/tester.py#104.

Please keep dart infra team in the loop regarding changes around mechanism that allows to override engine.version

What is there to inform? The Dart team isn't using FLUTTER_ENGINE_VERSION (right?) and this is an internal experiment we're trying not to publicize intentionally.

This is an experiment to determine what the wall time of a (minimal) "upload a JSON file describing files changed". We are looking for this to take (low) single digit minutes, because if we use this file (and expand it to become a build plan), it will block almost _all_ other actions, and will likely get longer as we add more complex logic and checks. Here's hoping!

…r#161788)

) Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) Manual roll requested by [email protected] flutter/flutter@b9e86a5...b2f515f 2025-01-22 [email protected] Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035) 2025-01-22 [email protected] `const AnimationStyle` (flutter/flutter#160564) 2025-01-22 [email protected] Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020) 2025-01-22 [email protected] [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855) 2025-01-22 [email protected] Experiment with a `files-changed.json` per PR (flutter/flutter#161788) 2025-01-22 [email protected] Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925) 2025-01-22 [email protected] Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019) 2025-01-22 [email protected] Adds cupertino picker semantics test (flutter/flutter#161768) 2025-01-22 [email protected] [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775) 2025-01-22 [email protected] fix: Add enabled property for search anchor named constructor (flutter/flutter#161468) 2025-01-22 [email protected] Roll pub packages (flutter/flutter#162015) 2025-01-22 [email protected] [web] Remove spam from test output (flutter/flutter#161774) 2025-01-22 [email protected] Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577) 2025-01-22 [email protected] Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016) 2025-01-22 [email protected] Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622) 2025-01-22 [email protected] [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537) 2025-01-22 [email protected] Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991) 2025-01-22 [email protected] Fix incorrect [enabled] documentation (flutter/flutter#161650) 2025-01-22 [email protected] Add `windows_host_engine_test`. (flutter/flutter#161992) 2025-01-22 [email protected] Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989) 2025-01-22 [email protected] Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024) 2025-01-22 [email protected] [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981) 2025-01-22 [email protected] Merge changelog for 3.27.3 release (flutter/flutter#161977) 2025-01-21 [email protected] Remove FlKeyboardViewDelegate (flutter/flutter#161705) 2025-01-21 [email protected] Fix documentation of Flow.clipBehavior (flutter/flutter#161863) 2025-01-21 [email protected] [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841) 2025-01-21 [email protected] [Impeller] backfilling TextContents unit tests (flutter/flutter#161625) 2025-01-21 [email protected] Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824) 2025-01-21 [email protected] fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301) 2025-01-21 [email protected] Get `et` working for local web engine builds. (flutter/flutter#161825) 2025-01-21 [email protected] Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994) 2025-01-21 [email protected] Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656) 2025-01-21 [email protected] Don't crash flutter tool if Chrome is not available (flutter/flutter#154941) 2025-01-21 [email protected] Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717) 2025-01-21 [email protected] [native assets] Cleanup dead code 2 (flutter/flutter#161916) 2025-01-21 [email protected] Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811) 2025-01-21 [email protected] Roll pub packages (flutter/flutter#161924) 2025-01-21 [email protected] Make `PipelineOwner` a `base` class (flutter/flutter#161789) 2025-01-20 [email protected] [native assets] Cleanup dead code (flutter/flutter#161913) 2025-01-20 [email protected] Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914) 2025-01-20 [email protected] [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917) 2025-01-19 [email protected] Update documentation on what display information is provided. (flutter/flutter#161785) If this roll has caused a breakage, revert this CL and stop the roller ...

Experiment with the cost of generating a minimal JSON file per PR.

d829a02

matanlurey requested review from jtmcdole and yjbanov January 17, 2025 04:40

jtmcdole reviewed Jan 17, 2025

View reviewed changes

Add a GH action.

bde45df

matanlurey force-pushed the files-changed.yml branch from d588e7a to bde45df Compare January 18, 2025 00:10

Use stderr correctly.

d59d02c

matanlurey mentioned this pull request Jan 18, 2025

Use DEPS to bootstrap the GitHub Actions Dart SDK #161843

Open

Use stderr correctly.

8967016

matanlurey marked this pull request as ready for review January 21, 2025 17:26

jtmcdole approved these changes Jan 22, 2025

View reviewed changes

Remove debug statement.

b0de0f9

matanlurey force-pushed the files-changed.yml branch from da76f44 to b0de0f9 Compare January 22, 2025 17:33

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

matanlurey enabled auto-merge January 22, 2025 18:29

matanlurey disabled auto-merge January 22, 2025 18:29

Merge branch 'master' into files-changed.yml

7a9ab16

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

matanlurey added this pull request to the merge queue Jan 22, 2025

Merged via the queue into flutter:master with commit cc9c13e Jan 22, 2025
174 checks passed

matanlurey deleted the files-changed.yml branch January 22, 2025 22:26

engine-flutter-autoroll mentioned this pull request Jan 22, 2025

Manual roll Flutter from b9e86a565f92 to b2f515f45ef5 (42 revisions) flutter/packages#8482

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2025

cc9c13e Experiment with a files-changed.json per PR (flutter/flutte…

7682a95

…r#161788)

aam reviewed Jan 23, 2025

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

cc9c13e Experiment with a files-changed.json per PR (flutter/flutte…

0dae7ed

…r#161788)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

cc9c13e Experiment with a files-changed.json per PR (flutter/flutte…

120d174

…r#161788)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

cc9c13e Experiment with a files-changed.json per PR (flutter/flutte…

c6438a9

…r#161788)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Experiment with a `files-changed.json` per PR#161788

Experiment with a `files-changed.json` per PR#161788
matanlurey merged 6 commits intoflutter:masterfrom
matanlurey:files-changed.yml

matanlurey commented Jan 17, 2025

Uh oh!

jtmcdole Jan 17, 2025

Uh oh!

matanlurey Jan 18, 2025

Uh oh!

jtmcdole Jan 17, 2025

Uh oh!

matanlurey Jan 18, 2025

Uh oh!

matanlurey commented Jan 21, 2025

Uh oh!

matanlurey commented Jan 22, 2025

Uh oh!

matanlurey commented Jan 22, 2025

Uh oh!

auto-submit bot commented Jan 22, 2025

Uh oh!

auto-submit bot commented Jan 22, 2025

Uh oh!

auto-submit bot commented Jan 22, 2025

Uh oh!

Uh oh!

aam Jan 23, 2025

Uh oh!

matanlurey Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

matanlurey commented Jan 17, 2025

Uh oh!

jtmcdole Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

jtmcdole Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey commented Jan 21, 2025

Uh oh!

matanlurey commented Jan 22, 2025

Uh oh!

matanlurey commented Jan 22, 2025

Uh oh!

auto-submit bot commented Jan 22, 2025

Uh oh!

auto-submit bot commented Jan 22, 2025

Uh oh!

auto-submit bot commented Jan 22, 2025

Uh oh!

Uh oh!

aam Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants