Fix Slider renders track when track colors are transparent #161814
Fix Slider renders track when track colors are transparent #161814auto-submit[bot] merged 5 commits intoflutter:masterfrom TahaTesser:fix_slider_thumb_padding
Slider renders track when track colors are transparent #161814Conversation
|
Wow, awesome fixes! Thanks @TahaTesser 💙 |
QuncCccccc
left a comment
There was a problem hiding this comment.
LGTM! Thanks a lot for the fix:)
|
|
||
| final Color? effectiveActiveTrackColor = | ||
| widget.activeColor ?? sliderTheme.activeTrackColor ?? defaults.activeTrackColor; | ||
| final Color? effectiveInactiveColor = |
There was a problem hiding this comment.
nit: maybe rename to effectiveInactiveTrackColor to keep consistent:)?
|
@QuncCccccc Looks like this is failing google testing. |
|
Taking a look |
| sliderTheme.inactiveTrackColor == Colors.transparent) { | ||
| trackHeight = 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
This fix seems only related to the first issue in the description. Are we still include the fix for the second issue #161805?
There was a problem hiding this comment.
Yes, I commented one of the fixes to figure out which fix is actually failing google testing.
Now I know which code is causing the issue. I will try to find a root cause.
There was a problem hiding this comment.
I'm removing non google test failing fix to better understand the cause and file separate PR for it.
There was a problem hiding this comment.
Also updated the description to remove second the issue.
There was a problem hiding this comment.
Would you please mind approving second time with only single issue fix now so I can land this?
There was a problem hiding this comment.
Ah thanks a lot for letting me know! LGTM:)
Slider thumb cannot reach extreme endsRangeSlider renders track when track colors are transparent
RangeSlider renders track when track colors are transparent Slider renders track when track colors are transparent
|
So these changes removes the original fix I commented on earlier? Just asking, because if so, I need to reflect that change in the status of original issue. |
It'll be in separate PR |
| sliderTheme.inactiveTrackColor == Colors.transparent) { | ||
| trackHeight = 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
Ah thanks a lot for letting me know! LGTM:)
Description
Fixes
Sliderwith transparent track colors and customtrackHeightcannot reach the extreme endsCode Sample
expand to view the code sample
Before
After
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.