Drag handle semantic role#161941
Merged
hannah-hyj merged 3 commits intoflutter:masterfrom Jan 30, 2025
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
framework
hannah-hyj
approved these changes
Jan 21, 2025
Member
hannah-hyj
left a comment
hannah-hyj
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
hannah-hyj
added
the
a: accessibility
nate-thegrate
approved these changes
Jan 23, 2025
Contributor
nate-thegrate
left a comment
nate-thegrate
left a comment
There was a problem hiding this comment.
LGTM, thanks for catching this!
github-actions
bot
removed
the
a: accessibility
hannah-hyj
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
I believe Google Testing likely failed since it has a hard time interpreting merge commits. Hopefully a rebase will fix it! Update: rebase did not fix it 🙁 |
nate-thegrate
force-pushed
the
drag_handle_semantic_role
branch
from
204776e to
0b97ba7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
nate-thegrate
force-pushed
the
drag_handle_semantic_role
branch
from
9a0f7ea to
ea41326
Compare
nate-thegrate
added
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/161941, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
From triage: @hannah-hyj will look into these Google testing failures 👍 |
Member
|
re-running google testing with g3 fix added |
Contributor
|
Are we tracking to make sure the linked issue is closed? #161430 |
Member
|
@kevmoo thank you for noticing it! i just closed it |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 31, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 31, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds semantic role button to ModalBottomSheet's DragHandle.
#161430
Pre-launch Checklist
///).Existing test was updated
No breaking changes
If you need help, consider asking for advice on the #hackers-new channel on Discord.