Update Theme documentation with Cupertino details#161980
Update Theme documentation with Cupertino details#161980auto-submit[bot] merged 3 commits intoflutter:masterfrom
Theme documentation with Cupertino details#161980Conversation
github-actions
bot
added
framework
|
Some more context around this change can be found here: #161573 (comment) |
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM with nits.
I left a question, I want to understand this more, but I'm giving an LGTM just to make sure I don't end up blocking this PR from landing. It's definitely an improvement already.
| /// To interact seamlessly with descendant Cupertino widgets, the [Theme] widget | ||
| /// implies a [CupertinoTheme] widget with a [CupertinoThemeData] inherited from | ||
| /// the nearest ancestor [CupertinoTheme] or if none exists, derived from the | ||
| /// Material [data] for the [Theme]. The values in the Material derived [CupertinoThemeData] |
There was a problem hiding this comment.
Nit: hyphen "Material-derived"
| /// [ThemeData.iconTheme] of the [data] for the [Theme]. | ||
| /// | ||
| /// To interact seamlessly with descendant Cupertino widgets, the [Theme] widget | ||
| /// implies a [CupertinoTheme] widget with a [CupertinoThemeData] inherited from |
There was a problem hiding this comment.
What do you mean by "implies" here?
There was a problem hiding this comment.
I was trying to say "internally creates a CupertinoTheme for its descendants" without saying it. Maybe I should just say "the [Theme] widget provides a [CupertinoTheme] for its descendants with a [CupertinoThemeData]....".
There was a problem hiding this comment.
Yeah I think that's better. I think "implies" could be interpreted to mean that CupertinoTheme must be present elsewhere or something like that.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
IMO https://api.flutter.dev/flutter/material/TextSelectionThemeData/selectionHandleColor.html should be updated as well. |
Piinks
force-pushed
the
theme-doc-update
branch
from
674373c to
6e53934
Compare
github-actions
bot
added
the
a: text input
Renzo-Olivares
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
3 participants
Updates
Themedocumentation to note how it interacts with descendantCupertinowidgets.Fixes #161573
Pre-launch Checklist
///).