Marks Mac_mokey microbenchmarks to be unflaky#162000
Marks Mac_mokey microbenchmarks to be unflaky#162000fluttergithubbot wants to merge 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
c: flake
github-actions
bot
removed
the
c: tech-debt
|
@jtmcdole I guess based on #153828 comments and the recent logs from staging https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_mokey%20microbenchmarks?limit=200, this can be merged? |
It could be merged, but it could go flakey again in the future due to the random seed.
|
|
@jtmcdole Sorry, my mistake, I was looking at a wrong issue. Based on Git history of: Lines 4655 to 4660 in e4c726a this is the last relevant discussion: #161550 The problem is indeed not fixed. I propose we close this PR without merging. Note: I was unable to find either a followup issue for #161550 or the bug issue to get benchmarks restartable. Can you point me to it/them? Would be good to link it from here and/or from the YAML, then these PRs bringup=false can be easily dealt with in the future until the issue is fixed :) Thanks! |
|
#156506 should be the issue tracking this. I've just been focused on infra and monorepo. |
|
Cool, I'll close this PR; no point in reenabling it at this stage. |
…i config for easier discovery (#164694) Update the comment in .ci.yaml with the issue link for easier discovery. Related issue: #156506 Related discussion: #162000 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
…i config for easier discovery (flutter#164694) Update the comment in .ci.yaml with the issue link for easier discovery. Related issue: flutter#156506 Related discussion: flutter#162000 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
3 participants
The test has been passing for 50 consecutive runs.
This test can be marked as unflaky.