[web] do not send SemanticsAction.focus inside frame#162554
Merged
yjbanov merged 3 commits intoflutter:masterfrom Feb 4, 2025
Merged
[web] do not send SemanticsAction.focus inside frame#162554yjbanov merged 3 commits intoflutter:masterfrom
yjbanov merged 3 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
engine
mdebbar
reviewed
Feb 3, 2025
| /// | ||
| /// Used for debugging only. | ||
| int debugFrameNumber = 1; | ||
| // TODO(yjbanov): this file should be deleted as part of https://github.com/flutter/flutter/issues/145954 |
Contributor
There was a problem hiding this comment.
Nice catch! I think it's better if we moved the file so that it gets deleted with the html code: #162608
mdebbar
reviewed
Feb 3, 2025
| /// implementation. | ||
| /// | ||
| /// This is intended for tests only. | ||
| static void debugOverrideFrameService(FrameService? mock) { |
Contributor
There was a problem hiding this comment.
Suggested change
| static void debugOverrideFrameService(FrameService? mock) { | |
| @visibleForTesting | |
| static void debugOverrideFrameService(FrameService? mock) { |
| /// DOM event handlers whose notifications to the framework result in state | ||
| /// changes may want to delay their notifications, e.g. by scheduling them in | ||
| /// a timer. | ||
| bool get isUpdatingSemanticsTree => _isUpdatingSemanticsTree; |
Contributor
There was a problem hiding this comment.
I'm guessing this is leftover from a previous iteration? It's not being used anywhere.
Contributor
Author
There was a problem hiding this comment.
Yep! Thanks for catching. Cleaning up.
mdebbar
approved these changes
Feb 3, 2025
github-actions
bot
removed
the
a: accessibility
yjbanov
force-pushed
the
semantic-action-inside-frame
branch
from
49bf60b to
06e4f2c
Compare
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/162554, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/162554, because - The status or check suite Mac tool_integration_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 4, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
Fix the issue with the first frame not rendering, introduced in #162554. Nobody filed an issue yet. I found it while testing something else.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
SemanticsActionfires while rendering a frame, delay it by a zero-length timer.Explanation
A concrete situation where this happens is when a semantics update causes DOM focus shift. DOM focus events are delivered synchronously when induced programmatically. We want to notify the framework about the shift. Since it wasn't the framework that decided where the focus moved, the framework may end up out-of-sync with the engine about which widget is currently focused. However, if the framework is still in the middle of rendering a frame, the notification may induce an illegal
setState. We have to wait until the framework is done before delivering the notification.How
FrameServiceand consolidate all frame scheduling logic into it (this also makes it way more testable).FrameService.isRenderingFrameboolean that can be used to tell if a frame is being rendered.invokeOnSemanticsActionto useisRenderingFrameto decide if the action can be delivered immediately, or delayed by a zero-length timer.Fixes #162472