Exclude build.gradle.kts files from automatic lockfile generation in display rotation #162622
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Tested, ran |
|
This is test-exempt, though, we really should have a test that we can't get into this state again (i.e. |
reidbaker
added
the
autosubmit
| - examples/hello_world/android | ||
| # Also uses kts files. | ||
| - dev/integration_tests/display_cutout_rotation/android | ||
| - dev/integration_tests/display_cutout_rotation/android/app |
There was a problem hiding this comment.
you should only need the line above, does it not build without the /app directory too?
There was a problem hiding this comment.
correct, I needed both. I think it works based on build.gradle basis and there were 2.
There was a problem hiding this comment.
Hmm it works based on an android directory basis
https://github.com/flutter/flutter/blob/master/dev/tools/bin/generate_gradle_lockfiles.dart#L73
So excluding an app directory should never do anything here... did you maybe run it the first time with --no-exclusion?
I just tried it now on master with just the one line above, and didn't run in to any issues. Basically, if excluding an /app directory here did something, it would mean we definitely had a bug with discoverAndroidDirectories below (because it would be discovering an app directory)
There was a problem hiding this comment.
Removed from merge queue and double checking my work. Maybe I didnt press save?
flutter-dashboard
bot
removed
the
autosubmit
reidbaker
added
the
autosubmit
reidbaker
deleted the
i162614-exempt-rotation-test-from-lockfile-generation
branch
flutter-dashboard
bot
removed
the
autosubmit
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
…tion in display rotation (flutter/flutter#162622)
3 participants
Fixes #162614
Pre-launch Checklist
///).