Skip to content

Run web benchmarks at -O2 to evaluate performance.#162625

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
eyebrowsoffire:web_benchmarks_O2
Feb 4, 2025
Merged

Run web benchmarks at -O2 to evaluate performance.#162625
auto-submit[bot] merged 3 commits intoflutter:masterfrom
eyebrowsoffire:web_benchmarks_O2

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented Feb 3, 2025

As per #162620, we are going to run the web benchmarks at -O2 for a trial period to evaluate the performance difference, which will give us some data on whether we can consider changing to -O2 by default.

kevmoo
kevmoo reviewed Feb 3, 2025
View reviewed changes
dev/devicelab/lib/tasks/web_benchmarks.dart
options: <String>[
'web',
'--no-tree-shake-icons', // local engine builds are frequently out of sync with the Dart Kernel version
if (benchmarkOptions.useWasm) ...<String>['-O4', '--wasm', '--no-strip-wasm'],
Copy link
Contributor

@kevmoo kevmoo Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so this previous -04 was redundant

Copy link
Contributor Author

@eyebrowsoffire eyebrowsoffire Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's currently -O4 by default in profile and release mode.

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 3, 2025
Merged via the queue into flutter:master with commit 13e5f8c Feb 4, 2025
148 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
e0b1406 
…lutter#162625)
@gaaclarke gaaclarke mentioned this pull request Feb 4, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
43f8fc4 
…lutter#162625)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
65a318a 
…lutter#162625)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
69eb4e9 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
d59c0e1 
…lutter#162625)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
1efde19 
…lutter#162625)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
412735e 
…lutter#162625)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
@eyebrowsoffire eyebrowsoffire mentioned this pull request Feb 5, 2025
Closed
3 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
457dd88 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
a3868d9 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
758c520 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
f9ab853 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
3b874ac 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
be0981e 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
e30efde 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
af4231e 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
85681a1 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
9feb8a1 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
125a735 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
9e10979 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
e0b0bc2 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
46804ce 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
c3e1cb5 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
8b8a455 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
6dd6762 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
4fcea0e 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
f65a425 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
bc229e3 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
27a1489 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
d2904e6 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
29df4c9 
…lutter#162625)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
13e5f8c Run web benchmarks at -O2 to evaluate performance. (flutter/f…
a842035 
…lutter#162625)
@eyebrowsoffire eyebrowsoffire deleted the web_benchmarks_O2 branch December 12, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevmoo kevmoo kevmoo left review comments

@mdebbar mdebbar mdebbar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eyebrowsoffire @kevmoo @mdebbar