Remove --verbose from devicelab task executions.#162644
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Feb 7, 2025
Merged
Remove --verbose from devicelab task executions.#162644auto-submit[bot] merged 2 commits intoflutter:masterfrom
--verbose from devicelab task executions.#162644auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
Looks like it's "green", though who knows for post-submit. |
jonahwilliams
approved these changes
Feb 5, 2025
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
do you remember logs?
reidbaker
reviewed
Feb 6, 2025
| section('Build release AAR'); | ||
|
|
||
| await inDirectory(projectDir, () async { | ||
| await flutter('build', options: <String>['aar', '--verbose']); |
Contributor
There was a problem hiding this comment.
You might consider keeping this one. If an aar fails to build then I think verbose logs might be required to know why.
Contributor
Author
There was a problem hiding this comment.
I suspect if it's important we can add it back 🤷🏼
reidbaker
approved these changes
Feb 6, 2025
Contributor
reidbaker
left a comment
There was a problem hiding this comment.
Consider getting an ios approval.
Contributor
Author
|
reason for revert: At least one post-submit test depends on the output of |
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
This reverts commit fdeb7b9.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
#162853) <!-- start_original_pr_link --> Reverts: #162644 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: matanlurey <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: At least one post-submit test depends on the output of `--verbose`. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: matanlurey <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {cbracken, reidbaker, jonahwilliams} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: These can be useful, but were probably left in past the point where they are always useful: - #58018 - #56342 - #74080 ... compared to the cost of reading these logs with 1000s of lines of `stdout: ` output. Will ask the CI gods if any of this was load-bearing before sending out for review. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
matanlurey
added a commit
to matanlurey/flutter
that referenced
this pull request
Feb 10, 2025
…lutter#162644)" (flutter#162853)" This reverts commit 7569fbf.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

These can be useful, but were probably left in past the point where they are always useful:
... compared to the cost of reading these logs with 1000s of lines of
stdout:output.Will ask the CI gods if any of this was load-bearing before sending out for review.