delete almost all remaining references to package:usage#162658
delete almost all remaining references to package:usage#162658andrewkolos wants to merge 4 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
platform-ios
| @override | ||
| bool get reportNullSafety => true; | ||
|
|
There was a problem hiding this comment.
I don't see any package:unified_analytics event for reporting null-safety (or rather the lack of it). Disabling null-safety is not possible in the tool (outside of forks). I'm speculating that this information has no known use case and that this code should be deleted.
| void main() { | ||
| testWithoutContext('DoctorResultEvent sends usage event for each sub validator', () async { |
There was a problem hiding this comment.
These doctor tests are covered in doctor_test.dart
| globals.logger.fatalWarnings = boolArg(FlutterOptions.kFatalWarnings); | ||
| } | ||
| // Prints the welcome message if needed. | ||
| globals.flutterUsage.printWelcome(); |
There was a problem hiding this comment.
We print a consent message upon exit
Unless you are saying we should keep this until we actually remove the package completely
|
@andrewkolos do you have a couple of cycles to get this ready for landing? |
|
Sure do! I just need to stop forgetting about it |
bkonyi
left a comment
bkonyi
left a comment
There was a problem hiding this comment.
The changes to remove package:usage reference still LGTM, but I think there's something wrong with the formatting changes.
| abstract class DotEnvRegex { | ||
| // Dot env multi-line block value regex | ||
| static final RegExp multiLineBlock = RegExp(r'^\s*([a-zA-Z_]+[a-zA-Z0-9_]*)\s*=\s*"""\s*(.*)$'); | ||
| static final RegExp multiLineBlock = RegExp( |
There was a problem hiding this comment.
I'm not sure these formatting changes are correct given what's currently at HEAD. Maybe the 100 character limit set in analysis_options.yaml isn't being respected properly?
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@andrewkolos @bkonyi I'm guessing this isn't being worked on any more? Should we close it for now? |
3 participants
Toward #150575. The idea of this PR is to get as close as possible to removing package:usage without actually deleting the dependency from the tool pubspec. That will be a separate PR since that has a decent chance of running into internal roll complications.
Pre-launch checklist
///).