Skip to content

[Android] wire up Java Transaction to AHB swapchain.#162750

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jonahwilliams:more_hc_pp
Feb 5, 2025
Merged

[Android] wire up Java Transaction to AHB swapchain.#162750
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jonahwilliams:more_hc_pp

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Feb 5, 2025

  • When the opt in surface control setting is enabled (and the backend is impeller vulkan) - then use the external view embedder 2.
  • ALways create the SurfaceControl.Transaction in PlatformViewController2 and manage it in Java. This was done for ease of implementation. Rather than switching between SurfaceControl.Transaction objects created in the native heap or created in java, we always go through java. This also means that adding platform views shouldn't change this flow.
  • We may need to separate this after peformance profiling.

One more PR to go to wire up the new message channels and add the integration_test.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 5, 2025

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Feb 5, 2025
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Feb 5, 2025

Integration test will be here: #162751

jonahwilliams
jonahwilliams commented Feb 5, 2025
View reviewed changes
engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/swapchain_vk.h
namespace impeller {

#if FML_OS_ANDROID
using CreateTransactionCB = std::function<android::SurfaceTransaction()>;
Copy link
Contributor Author

@jonahwilliams jonahwilliams Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate that this uses a callback but I had a bad time looking for some common place to put an interface to be shared between the platform and impeller code anywhere.

ideally we'd have something fairly simple like:

class TransactionFactory {

  android::SurfaceTransaction CreateTransaction();
  
  enum TransactionMode {
    kNative,
    kJava,
  }
  
  void SetTransactionMode(/* java or native*/ mode)
}

But I plan to fix this in a follow up.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 5, 2025
Merged via the queue into flutter:master with commit 17cb12d Feb 5, 2025
176 of 177 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
451980d 
…/flutter#162750)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
679bace 
…/flutter#162750)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
0b5555f 
…/flutter#162750)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
c7d576e 
…/flutter#162750)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
cd6845a 
…/flutter#162750)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
0da560c 
…/flutter#162750)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
b10b9ca 
…/flutter#162750)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
c94386e 
…/flutter#162750)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
db7a302 
…/flutter#162750)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
b7b3462 
…/flutter#162750)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
4c70782 
…/flutter#162750)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
950bbe0 
…/flutter#162750)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
13e117e 
…/flutter#162750)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
1ac259e 
…/flutter#162750)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
f3225a1 
…/flutter#162750)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
ee4afc8 
…/flutter#162750)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
f47cc72 
…/flutter#162750)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
81a593d 
…/flutter#162750)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
2d52112 
…/flutter#162750)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
7f0fe98 
…/flutter#162750)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
f76a3b7 
…/flutter#162750)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
160d30d 
…/flutter#162750)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
99b8e35 
…/flutter#162750)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
17cb12d [Android] wire up Java Transaction to AHB swapchain. (flutter…
270e6d2 
…/flutter#162750)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnmccutchan johnmccutchan johnmccutchan approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. platform-android Android applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @johnmccutchan