[Android] HC++ wire up dart platform channel code and integration test.#162751
[Android] HC++ wire up dart platform channel code and integration test.#162751auto-submit[bot] merged 13 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
platform-android
jonahwilliams
changed the title
|
@matanlurey question when you get in tomorrow: how do you think I should wire this up to the existing Android engine tests? This would go under the vulkan shard, but i'd need to update the AndroidManifest configuration just for this one test suite. I think I could put it in its own directory and then just ... do that? Or do you think we should have a separate shard for it. |
| if (widget.controller.requiresViewComposition) { | ||
| if (widget.controller.useNewHybridComposition) { | ||
| // TODO(jonahwilliams): make it actually work. | ||
| return _PlatformLayerBasedAndroidViewSurface( |
There was a problem hiding this comment.
Not sure yet if we need a new surface class
There was a problem hiding this comment.
We will need to configure touch gestures differently. Will do in follow up.
| add(NativeDriverSupportPlugin()) | ||
| } | ||
|
|
||
| flutterEngine |
There was a problem hiding this comment.
This isn't great and we probably need to fix the registry so that it is shared across controllers.
There was a problem hiding this comment.
I have a follow up patch to fix this.
There was a problem hiding this comment.
Thank you!
Add a TODO/issue.
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
LGTM, a few small comments.
| if (stdout == null) { | ||
| foundError(<String>['No stdout produced.']); | ||
| continue; | ||
| return; |
There was a problem hiding this comment.
I think I had this as a continue so that hypothetically other tests ran, but I am not sure it was worth it.
If this was intentional feel free to ignore.
There was a problem hiding this comment.
Talked offline, this is pulled into a closure now so its equivalent code.
| } | ||
|
|
||
| // Test HCPP Platform Views | ||
| androidManifestXml.writeAsStringSync( |
There was a problem hiding this comment.
You'd want to skip this stanza for OpenGLES.
| add(NativeDriverSupportPlugin()) | ||
| } | ||
|
|
||
| flutterEngine |
There was a problem hiding this comment.
Thank you!
Add a TODO/issue.
| /// | ||
| /// For a convenient way to deflake a test, see `tool/deflake.dart`. | ||
| void main() async { | ||
| const String goldenPrefix = 'hybrid_composition_2_platform_view'; |
There was a problem hiding this comment.
plus_plus instead of 2? or PP. PP is good.
| if (widget.controller.requiresViewComposition) { | ||
| if (widget.controller.useNewHybridComposition) { | ||
| // TODO(jonahwilliams): make it actually work. | ||
| return _PlatformLayerBasedAndroidViewSurface( |
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/162751, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
2 participants
Use the PlatformViewController2 to register a platform view, allow the dart side platform view logic to opt into this new platform view. Wires up an integration test with android_engine_test.