Convert dependency version checker to Kotlin source by gmackall · Pull Request #162771 · flutter/flutter

gmackall · 2025-02-05T21:28:42Z

Converts the dependency_version_checker.kts script to a Kotlin source class. Also adds unit tests that depend heavily on mocking, because from what I can tell you can't create an instance of a Gradle org.gradle.api.Project for testing (so I can't pass a real Project to DependencyVersionChecker.checkDependencyVersions()).

Perhaps functionality for unit testing will come in the future:
https://docs.gradle.org/current/userguide/test_kit.html

At this time, it is focused on functional testing. That is, testing build logic by exercising it as part of a programmatically executed build. Over time, the TestKit will likely expand to facilitate other kinds of tests.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…e there other side affects?

flutter-dashboard · 2025-02-11T23:38:43Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162771 at sha 3ecc29d

packages/flutter_tools/gradle/README.md

reidbaker · 2025-02-12T16:11:51Z

packages/flutter_tools/gradle/build.gradle.kts


 dependencies {
+    compileOnly("androidx.annotation:annotation-jvm:1.9.1")
+    implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.7.10")


Does this version number have a relationship with the kotlin version used? if so consider using a kotlin variable.

I believe this is actually unrelated now, with it being an implementation dependency

reidbaker · 2025-02-12T16:15:20Z

packages/flutter_tools/gradle/src/main/kotlin/DependencyVersionChecker.kt

+    // TODO(gmackall): AGP has a getKotlinAndroidPluginVersion(), and KGP has a
+    //                 getKotlinPluginVersion(). Consider replacing this implementation with one of
+    //                 those.


Fantastic find!

FWIW I think there is also a AndroidPluginVersion https://developer.android.com/reference/tools/gradle-api/8.8/com/android/build/api/AndroidPluginVersion#getCurrent()

Co-authored-by: Reid Baker <[email protected]>

…checker_conversion' into dependency_version_checker_conversion

…flutter#162771)

convert dependency version checker to kotlin source

0601407

github-actions bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 5, 2025

Gray Mackall added 10 commits February 5, 2025 15:27

examples of tests, just need to fill them out for other dependencies

a947df9

this needed to be @JvmStatic 'd

dad8946

change the annotation, and make everything internal

25d6856

compileOnlyMaybe?

b76ae35

how about this way instead?

fe1a215

return to old agp getting

3a238e6

does adding implementation work? or will this break some projects? Ar…

552d94d

…e there other side affects?

wip

46754f3

wip round 2

174d08a

go with this ugly mocking for now

a137f88

gmackall mentioned this pull request Feb 11, 2025

[FGP Kotlin conversion] Convert dependency_version_checker.gradle.kts #162102

Closed

gmackall marked this pull request as ready for review February 11, 2025 22:52

gmackall and others added 2 commits February 11, 2025 14:52

Merge branch 'master' into dependency_version_checker_conversion

3ecc29d

remove testkit dep

d363aae

gmackall requested a review from a team February 11, 2025 22:54

flutter-dashboard bot added the will affect goldens Changes to golden files label Feb 11, 2025

reidbaker approved these changes Feb 12, 2025

View reviewed changes

Update packages/flutter_tools/gradle/README.md

23d9053

Co-authored-by: Reid Baker <[email protected]>

gmackall removed the will affect goldens Changes to golden files label Feb 12, 2025

gmackall and others added 2 commits February 12, 2025 10:08

Merge branch 'master' into dependency_version_checker_conversion

2e92769

Merge remote-tracking branch 'refs/remotes/origin/dependency_version_…

4e5b274

…checker_conversion' into dependency_version_checker_conversion

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025

auto-submit bot added this pull request to the merge queue Feb 12, 2025

gmackall mentioned this pull request Feb 12, 2025

☂️ [FGP Kotlin conversion] Umbrella bug to track conversion progress #162103

Open

15 tasks

Merged via the queue into flutter:master with commit c3fc69d Feb 12, 2025
141 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

159186b

…flutter#162771)

engine-flutter-autoroll mentioned this pull request Feb 13, 2025

Roll Flutter from 892f9c13a2bb to 4ff2deafd4b9 (103 revisions) flutter/packages#8625

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

36a5e22

…flutter#162771)

engine-flutter-autoroll mentioned this pull request Feb 13, 2025

Roll Flutter from 892f9c13a2bb to 1cd3ab16ca1c (104 revisions) flutter/packages#8626

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

da21cff

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

257e5e8

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

b8d8187

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

d726837

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

8e6676f

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

d924e60

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

d6a501b

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

a5553b9

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

d3c81fe

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

be33d2f

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

8ceb95a

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

ce2af4d

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

4a2a91b

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

208d081

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

4d5e2dd

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

c760725

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

e277ce1

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

ecda51b

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

a24d31d

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

caea0cd

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

1516320

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

69c9a06

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

d2ac0c5

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

aef9b5e

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

9074ab5

…flutter#162771)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

c3fc69d Convert dependency version checker to Kotlin source (flutter/…

5b5732a

…flutter#162771)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert dependency version checker to Kotlin source#162771

Convert dependency version checker to Kotlin source#162771
auto-submit[bot] merged 16 commits intoflutter:masterfrom
gmackall:dependency_version_checker_conversion

gmackall commented Feb 5, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Feb 11, 2025

Uh oh!

Uh oh!

reidbaker Feb 12, 2025

Uh oh!

gmackall Feb 12, 2025

Uh oh!

reidbaker Feb 12, 2025

Uh oh!

reidbaker Feb 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gmackall commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Feb 11, 2025

Uh oh!

Uh oh!

reidbaker Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

gmackall Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gmackall commented Feb 5, 2025 •

edited

Loading