Delete un-tested hybrid_android_views, add layering to android_engine_test.#162903
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Feb 7, 2025
Merged
Conversation
Contributor
|
Indifferent to keeping or deleting in this PR, but I do plan to stand up a hcpp benchmark that was going to use the hybrid android views logic. I think I can actually just add that onto the android_engine_test app though. So i guess fire away |
matanlurey
added
the
autosubmit
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 9, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 9, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 10, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
…roid_engine_test`. (flutter/flutter#162903)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
…roid_engine_test`. (flutter/flutter#162903)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2026
This test was deleted in #162903 under the claim that it wasn't running, but it was actually (just only in bringup). In fact the [glue code](https://github.com/flutter/flutter/blob/dbed04aa32e5f0319898d29c8996919ee6ae8e2e/dev/devicelab/lib/tasks/integration_tests.dart#L75) and [ci.yaml](https://github.com/flutter/flutter/blob/master/.ci.yaml#L2874) target are still around. It tested stuff that isn't covered by the current testing landscape, like alert dialogue popup and event types being preserved. The original pr was not a pure deletion so I maintained the good changes (mostly a change to use shared code for the app under test). Had to make some changes (described in comments below) but the test is passing in its current state. --------- Co-authored-by: Gray Mackall <[email protected]>
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
This test was deleted in flutter#162903 under the claim that it wasn't running, but it was actually (just only in bringup). In fact the [glue code](https://github.com/flutter/flutter/blob/dbed04aa32e5f0319898d29c8996919ee6ae8e2e/dev/devicelab/lib/tasks/integration_tests.dart#L75) and [ci.yaml](https://github.com/flutter/flutter/blob/master/.ci.yaml#L2874) target are still around. It tested stuff that isn't covered by the current testing landscape, like alert dialogue popup and event types being preserved. The original pr was not a pure deletion so I maintained the good changes (mostly a change to use shared code for the app under test). Had to make some changes (described in comments below) but the test is passing in its current state. --------- Co-authored-by: Gray Mackall <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another large test suite that has never been running.
The underlying thing I think it wanted tested, which was hybrid composition, is now tested by
android_engine_test. I also added a red square on top of each platform view so that, likehybrid_android_views, we can make sure layering is working as expected.Any other ideas? Can also be follow-up PRs?