Marks Mac_arm64_ios imitation_game_swiftui to be unflaky#163114
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom May 8, 2025
Merged
Marks Mac_arm64_ios imitation_game_swiftui to be unflaky#163114auto-submit[bot] merged 1 commit intoflutter:masterfrom
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
auto-submit bot
pushed a commit
to flutter/cocoon
that referenced
this pull request
Apr 11, 2025
Further work towards debugging why flutter/flutter#166758 occurs in prod. Locally, with a regression test, it does mark `Windows plugin_test` as non-flaky, but in prod: ```txt > DEBUG 2025-04-09T09:20:07.673Z Skipping Linux analyzer_benchmark, could not find matching builder line > DEBUG 2025-04-09T09:20:07.831Z Skipping Linux coverage, could not find matching builder line > DEBUG 2025-04-09T09:20:07.833Z Skipping Linux_android_emu_unstable android_defines_test, an existing PR is open: flutter/flutter#165961 > DEBUG 2025-04-09T09:20:07.989Z Skipping Linux_pixel_7pro android_semantics_integration_test, could not find matching builder line > DEBUG 2025-04-09T09:20:08.185Z Skipping Linux_mokey hybrid_android_views_integration_test, could not find matching builder line > DEBUG 2025-04-09T09:20:08.407Z Skipping Linux_mokey new_gallery__crane_perf, could not find matching builder line > DEBUG 2025-04-09T09:20:08.415Z Skipping Staging_build_linux analyze, ignore_flakiness specified > DEBUG 2025-04-09T09:20:08.610Z Skipping Mac_mokey run_debug_test_android, could not find matching builder line > DEBUG 2025-04-09T09:20:08.792Z Skipping Mac_mokey run_release_test, could not find matching builder line > DEBUG 2025-04-09T09:20:08.793Z Skipping Mac_arm64_ios imitation_game_flutter, an existing PR is open: flutter/flutter#163113 > DEBUG 2025-04-09T09:20:08.793Z Skipping Mac_arm64_ios imitation_game_swiftui, an existing PR is open: flutter/flutter#163114 > DEBUG 2025-04-09T09:20:09.008Z Skipping Windows plugin_test, could not find matching builder line > DEBUG 2025-04-09T09:20:09.219Z Skipping Windows_arm64 plugin_test_windows, could not find matching builder line > DEBUG 2025-04-09T09:20:09.219Z Skipping Linux flutter_packaging, could not find matching builder line > DEBUG 2025-04-09T09:20:09.221Z Skipping Windows flutter_packaging, could not find matching builder line ``` I am guessing it's some sort of state error? The extra debugging lines will help.
Piinks
approved these changes
May 7, 2025
Contributor
Piinks
left a comment
There was a problem hiding this comment.
Confirmed this still does not appear to be flaking anymore. LGTM to take off bring up.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 8, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 8, 2025
flutter/flutter@b0f5c8c...02d8c1a 2025-05-08 [email protected] iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517) 2025-05-08 [email protected] Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548) 2025-05-08 [email protected] Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345) 2025-05-08 [email protected] Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526) 2025-05-08 [email protected] Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525) 2025-05-08 [email protected] Make MergeSemantics be able to merge customAction (flutter/flutter#168414) 2025-05-08 [email protected] Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514) 2025-05-08 [email protected] Roll pub packages (flutter/flutter#168509) 2025-05-07 [email protected] Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114) 2025-05-07 [email protected] Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782) 2025-05-07 [email protected] Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505) 2025-05-07 [email protected] [web] drop more use of deprecated JS functions (flutter/flutter#166157) 2025-05-07 [email protected] docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191) 2025-05-07 [email protected] Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489) 2025-05-07 [email protected] Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433) 2025-05-07 [email protected] Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479) 2025-05-07 [email protected] Fix stencil buffer leak (flutter/flutter#168448) 2025-05-07 [email protected] Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447) 2025-05-07 [email protected] Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
flutter/flutter@b0f5c8c...02d8c1a 2025-05-08 [email protected] iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517) 2025-05-08 [email protected] Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548) 2025-05-08 [email protected] Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345) 2025-05-08 [email protected] Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526) 2025-05-08 [email protected] Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525) 2025-05-08 [email protected] Make MergeSemantics be able to merge customAction (flutter/flutter#168414) 2025-05-08 [email protected] Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514) 2025-05-08 [email protected] Roll pub packages (flutter/flutter#168509) 2025-05-07 [email protected] Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114) 2025-05-07 [email protected] Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782) 2025-05-07 [email protected] Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505) 2025-05-07 [email protected] [web] drop more use of deprecated JS functions (flutter/flutter#166157) 2025-05-07 [email protected] docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191) 2025-05-07 [email protected] Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489) 2025-05-07 [email protected] Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433) 2025-05-07 [email protected] Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479) 2025-05-07 [email protected] Fix stencil buffer leak (flutter/flutter#168448) 2025-05-07 [email protected] Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447) 2025-05-07 [email protected] Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
flutter/flutter@b0f5c8c...02d8c1a 2025-05-08 [email protected] iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517) 2025-05-08 [email protected] Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548) 2025-05-08 [email protected] Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345) 2025-05-08 [email protected] Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526) 2025-05-08 [email protected] Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525) 2025-05-08 [email protected] Make MergeSemantics be able to merge customAction (flutter/flutter#168414) 2025-05-08 [email protected] Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514) 2025-05-08 [email protected] Roll pub packages (flutter/flutter#168509) 2025-05-07 [email protected] Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114) 2025-05-07 [email protected] Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782) 2025-05-07 [email protected] Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505) 2025-05-07 [email protected] [web] drop more use of deprecated JS functions (flutter/flutter#166157) 2025-05-07 [email protected] docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191) 2025-05-07 [email protected] Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489) 2025-05-07 [email protected] Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433) 2025-05-07 [email protected] Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479) 2025-05-07 [email protected] Fix stencil buffer leak (flutter/flutter#168448) 2025-05-07 [email protected] Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447) 2025-05-07 [email protected] Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test has been passing for 50 consecutive runs.
This test can be marked as unflaky.