Finish removing `null-safety` mode, checks, and reporting. by matanlurey · Pull Request #163153 · flutter/flutter

matanlurey · 2025-02-12T19:36:51Z

At HEAD, including before this PR, it was impossible to use, or pass-in, an unsound null-safety mode, but we still had code checking for it, and reported analytics (I think? Some of these are package:usage specific which is defunct).

This PR eradicates the otherwise unused code.

jonahwilliams

LGTM

auto-submit · 2025-02-12T19:46:46Z

autosubmit label was removed for flutter/flutter/163153, because - The status or check suite Linux web_canvaskit_tests_7_last has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux web_canvaskit_tests_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_1 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_0 has failed. Please fix the issues identified (or deflake) before re-applying this label.

jonahwilliams · 2025-02-12T19:48:36Z

packages/flutter_tools/lib/src/test/web_test_compiler.dart

-        platformDillName = 'ddc_outline.dill';
-    }
-
+    final LanguageVersion languageVersion = LanguageVersion(2, 8);


The errors on CI are caused by this, 2.8 is the last non-null safe version. I think if you just leave the language version string out, it will just work, but specifying an old version won't

Right, it was my mistake, the original code was:

final LanguageVersion languageVersion = currentLanguageVersion(_fileSystem, Cache.flutterRoot!);

Is that better (or worse) than your suggestion of omission?

That will work

auto-submit · 2025-02-12T20:04:54Z

autosubmit label was removed for flutter/flutter/163153, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-02-12T21:06:01Z

autosubmit label was removed for flutter/flutter/163153, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…lutter/flutter#163153)

Finish removing null-safety mode.

24fb77d

matanlurey requested review from bkonyi and jonahwilliams February 12, 2025 19:36

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Feb 12, 2025

jonahwilliams approved these changes Feb 12, 2025

View reviewed changes

bkonyi approved these changes Feb 12, 2025

View reviewed changes

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025

Fix language version.

64c22a4

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025

jonahwilliams reviewed Feb 12, 2025

View reviewed changes

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025

Remove deprecations.

a83b147

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025

auto-submit bot added this pull request to the merge queue Feb 12, 2025

Merged via the queue into flutter:master with commit 063f80d Feb 12, 2025
142 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025

engine-flutter-autoroll mentioned this pull request Feb 13, 2025

Roll Flutter from 892f9c13a2bb to b61335bd3bad (102 revisions) flutter/packages#8620

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

7e3d78d

…lutter/flutter#163153)

engine-flutter-autoroll mentioned this pull request Feb 13, 2025

Roll Flutter from 892f9c13a2bb to 4ff2deafd4b9 (103 revisions) flutter/packages#8625

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

0731c83

…lutter/flutter#163153)

engine-flutter-autoroll mentioned this pull request Feb 13, 2025

Roll Flutter from 892f9c13a2bb to 1cd3ab16ca1c (104 revisions) flutter/packages#8626

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

230cd2c

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

75b0d16

…lutter/flutter#163153)

engine-flutter-autoroll mentioned this pull request Feb 14, 2025

Roll Flutter from 892f9c13a2bb to 990e837656ca (128 revisions) flutter/packages#8632

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

d853c54

…lutter/flutter#163153)

engine-flutter-autoroll mentioned this pull request Feb 14, 2025

Roll Flutter from 892f9c13a2bb to 3dc4e016707a (129 revisions) flutter/packages#8633

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

07e0159

…lutter/flutter#163153)

engine-flutter-autoroll mentioned this pull request Feb 14, 2025

Roll Flutter from 892f9c13a2bb to f949d8eaedf3 (130 revisions) flutter/packages#8634

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

55fcf37

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

53a33be

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

ab987e2

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

49afab7

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

da2ad69

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

3ff1b76

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

5363d65

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

bbe46e5

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

b9635f9

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

97b8f4c

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

59b018d

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

989f78c

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

599d87c

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

03527b9

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

0a1c710

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

4d429f2

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

bf5442b

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

3317890

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

e1661ca

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

85e3f9e

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

f1ebe63

…lutter/flutter#163153)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

063f80d Finish removing null-safety mode, checks, and reporting. (f…

8d5ac4e

…lutter/flutter#163153)

JSUYA mentioned this pull request May 26, 2025

Upgrade to Flutter 3.32.0 flutter-tizen/flutter-tizen#631

Merged

jmagman mentioned this pull request Aug 27, 2025

Deprecate Objective-C plugin template #174003

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Finish removing `null-safety` mode, checks, and reporting.#163153

Finish removing `null-safety` mode, checks, and reporting.#163153
auto-submit[bot] merged 3 commits intoflutter:masterfrom
matanlurey:remove-null-safety-mode

matanlurey commented Feb 12, 2025

Uh oh!

jonahwilliams left a comment

Uh oh!

auto-submit bot commented Feb 12, 2025

Uh oh!

jonahwilliams Feb 12, 2025

Uh oh!

matanlurey Feb 12, 2025

Uh oh!

jonahwilliams Feb 12, 2025

Uh oh!

auto-submit bot commented Feb 12, 2025

Uh oh!

auto-submit bot commented Feb 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

matanlurey commented Feb 12, 2025

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Feb 12, 2025

Uh oh!

jonahwilliams Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Feb 12, 2025

Uh oh!

auto-submit bot commented Feb 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants