Skip to content

[Impeller] Ensure that texture coordinate coverage and gradient color source sizes used by DrawVertices are nonempty#163177

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jason-simmons:bug_162969_b
Feb 13, 2025
Merged

[Impeller] Ensure that texture coordinate coverage and gradient color source sizes used by DrawVertices are nonempty#163177
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jason-simmons:bug_162969_b

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Feb 13, 2025

Fixes #162969

@jason-simmons
[Impeller] Ensure that texture coordinate coverage and gradient color…
0b12ee1 
… source sizes used by DrawVertices are nonempty

Fixes flutter#162969
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Feb 13, 2025
jonahwilliams
jonahwilliams approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams
Copy link
Contributor

jonahwilliams commented Feb 13, 2025

Thank you Jason!

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 13, 2025
@jonahwilliams
Copy link
Contributor

jonahwilliams commented Feb 13, 2025

@jason-simmons can you file a cherry pick PR for this and the prev. fix?

Merged via the queue into flutter:master with commit ce659cd Feb 13, 2025
179 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Feb 13, 2025
@jason-simmons
[CP] Fixes for Impeller DrawVertices issues involving snapshots with …
0a5f7d5 
…empty sizes

See flutter#162969

Includes flutter#163099 and flutter#163177
@jason-simmons jason-simmons mentioned this pull request Feb 13, 2025
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
277be12 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
8e12f08 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
a9e3700 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
ece28be 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
d2747e0 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
ef87796 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
def4f0d 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
6a32390 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
6dfe32a 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
58a17bf 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
bea7b4e 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
d9fe7fa 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
329d57f 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
aca4dd9 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
6e0e473 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
e5a1466 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
9af2a52 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
42afda8 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
c1ee441 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
e0824ad 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
4f0e2c9 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
9c09644 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
auto-submit bot pushed a commit that referenced this pull request Feb 26, 2025
@jason-simmons
[CP] Fixes for Impeller DrawVertices issues involving snapshots with …
836b6fd 
…empty sizes (#163261)

See #162969

Includes #163099 and #163177
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
@jason-simmons @Fintasys
[CP] Fixes for Impeller DrawVertices issues involving snapshots with …
de61a34 
…empty sizes (flutter#163261)

See flutter#162969

Includes flutter#163099 and flutter#163177
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
0a280e1 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
074767d 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
ce659cd [Impeller] Ensure that texture coordinate coverage and gradie…
6bf5bc4 
…nt color source sizes used by DrawVertices are nonempty (flutter/flutter#163177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[impeller] app crashes when drawing some raw vertices with custom shader or gradient shader

2 participants

@jason-simmons @jonahwilliams