feat(FixedExtentScrollController): Add parent class properties to the constructor.#163190
Merged
auto-submit[bot] merged 5 commits intoflutter:masterfrom Mar 11, 2025
Conversation
github-actions
bot
added
framework
Contributor
Author
|
Could you take some time to review this request? cc @Piinks |
Piinks
reviewed
Feb 24, 2025
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
I am not sure we should add keepScrollOffset, I think using Scrollable.restorationId is preferred. It was added long after keepScrollOffset. I will double check on this.
Piinks
reviewed
Feb 26, 2025
| ); | ||
| } | ||
|
|
||
| FixedExtentScrollController controller = FixedExtentScrollController(initialItem: 2); |
Contributor
There was a problem hiding this comment.
In this test, to check that keep scroll offset is working, can you check the actual scroll offset, controller.offset? I might check the existing tests for ScrollController.keepScrollOffset for comparison.
Contributor
Author
There was a problem hiding this comment.
Of course, I have updated it.
Contributor
Following up on this, it is fine to pipe this through from the super class. |
Contributor
|
Rebasing to unstick the Google testing shard here. |
Piinks
force-pushed
the
feature/fixed_fxtent_scroll_controller
branch
from
aad1fbd to
bc6edeb
Compare
Contributor
Author
|
This Google test failed again. Can anyone help investigate? Much appreciated. |
MitchellGoodwin
force-pushed
the
feature/fixed_fxtent_scroll_controller
branch
from
d742a96 to
3d46514
Compare
MitchellGoodwin
force-pushed
the
feature/fixed_fxtent_scroll_controller
branch
from
3d46514 to
2f546f5
Compare
MitchellGoodwin
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 17, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
…s to the constructor. (flutter/flutter#163190)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
…s to the constructor. (flutter/flutter#163190)
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
… constructor. (flutter#163190) This request is to add configurable parameters keepScrollOffset and debugLabel to FixedExtentScrollController. - Fixes flutter#162972 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This request is to add configurable parameters keepScrollOffset and debugLabel to FixedExtentScrollController.
FixedExtentScrollController.newis missing parameters present inScrollController.new#162972Pre-launch Checklist
///).