Reverts "[Impeller] add support for rational bezier conics to Path (#163282)"#163573
Closed
auto-submit[bot] wants to merge 1 commit intomasterfrom
Closed
Reverts "[Impeller] add support for rational bezier conics to Path (#163282)"#163573auto-submit[bot] wants to merge 1 commit intomasterfrom
auto-submit[bot] wants to merge 1 commit intomasterfrom
Conversation
auto-submit
bot
added
the
revert of
github-actions
bot
added
engine
victorsanni
requested review from
flar and
jonahwilliams
and removed request for
jonahwilliams
fluttergithubbot
approved these changes
Feb 19, 2025
victorsanni
added
the
emergency
victorsanni
added
the
autosubmit
Contributor
|
Manually removing and re-adding to the queue, as it is stuck /cc @jtmcdole |
flutter-dashboard
bot
removed
the
autosubmit
Member
|
Check run updates are sounding increasingly unreliable. I commented internally about another way to handle the staging docs |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Contributor
|
This PR is not making progress, even after exiting/re-entering the queue. I am going to close it and make a new one, and file a P0 (there is clearly something wrong). |
flutter-dashboard
bot
removed
the
autosubmit
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
Checking to see if Gold is processing image updates as it should be. Related to #163573 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts: #163282
Initiated by: victorsanni
Reason for reverting: This PR is closing the tree.
Original PR Author: flar
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
Add basic support for storing rational bezier conics in impeller::Path. The support is very thin and just degrades the conics into a pair of quadratic curves just as Impeller has always done for the conic segments that it receives via SkPath objects, but it puts in place the framework for eventually handling the conics more directly and allows the unit tests to be rewritten on top of Impeller paths rather than SkPaths, paving the way for reduced internal API dependencies.