#163840 - CupertinoButton cursor doesn't change to clickable on desktop#163967
Closed
srivats22 wants to merge 4 commits intoflutter:masterfrom
srivats22:master
Closed
#163840 - CupertinoButton cursor doesn't change to clickable on desktop#163967srivats22 wants to merge 4 commits intoflutter:masterfrom srivats22:master
srivats22 wants to merge 4 commits intoflutter:masterfrom
srivats22:master
Conversation
Adds mouseCursor options to CupertinoButtons
Contributor
|
Thanks for your contribution! Since we're adding a property here, I think a better way is to use the WidgetStateProperty so that the disabled cursor is also included instead of being broken in the future. This has been done for many widgets before, such as in #151788 . Can you apply the approach in that PR here? |
Contributor
Author
|
Sure let me give it a try and see if I am able to get the required output and then will push to the same PR |
Contributor
Author
|
I will close this PR and open a new one... my local fork something went wrong so took a new fork and will open the PR from that... in a nutshell it wasnt able to recognize flutter & dart for some reason |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue number: 163840, where when hovering over a Cupertino button the mouse cursor wouldn't switch to clickable and there wasn't any option to configure it.
Adds Mouse cursor to CupertinoButton, CupertinoButton.Filled and CupertinoButton.Tinted
Fixes #163840
Part of #58192
Demo of the changes
pr_demo.mov
Code snippet showing new behavior
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.