[macOS] Prepare TextInputPlugin for multi-view by knopp · Pull Request #164014 · flutter/flutter

knopp · 2025-02-24T17:31:21Z

Notable changes:

FlutterTextInputPlugin is now owned by FlutterEngine.
FlutterTextInputPlugin is only associated with a FlutterViewController while having active IME connection.
Changed private state of TextInputPlugin from properties to ivars. There is no need for these to be properties, and the state was accessed both as ivars and properties which seemed inconsistent.
Updated test to reflect the changes

I've also tested everything including voice-over to make sure accessibility didn't regress.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chinmaygarde · 2025-03-10T18:06:59Z

Ping @dkwingsmt or @justinmc perhaps?

dkwingsmt

LGTM, thank you!

dkwingsmt · 2025-03-11T05:46:51Z

engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterTextInputPlugin.mm

      }

      _activeModel = std::make_unique<flutter::TextInputModel>();
+      NSNumber* viewId = config[kViewId];


Does it break existing apps that create such messages manually and doesn't add view ID? Should it default to implicit view ID?

Are any applications out there creating the messages manually instead of using the text input client, which always puts the viewId? I'd hope not.

dkwingsmt · 2025-03-11T06:07:05Z

engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterViewController.mm

+// Returns the text input plugin associated with this view controller.
+// This method only returns non nil instance if the text input plugin has active
+// client with viewId matching this controller's view identifier.
+- (FlutterTextInputPlugin*)textInputPlugin {


I'm concerned that this name might cause trouble if a maintainer does not read the doc carefully. Shall we rename it to something like matchingTextInputPlugin?

That's a good point. I'll rename it to activeTextInputPlugin.

…er#164014)

github-actions bot added engine flutter/engine related. See also e: labels. a: desktop Running on desktop platform-macos labels Feb 24, 2025

knopp force-pushed the multiview_text_input_plugin branch 2 times, most recently from 4b578b3 to 429fc13 Compare March 1, 2025 12:21

knopp requested a review from cbracken March 1, 2025 12:26

knopp changed the title ~~WIP: [macOS] Prepare TextInputPlugin for multi-view~~ [macOS] Prepare TextInputPlugin for multi-view Mar 1, 2025

knopp requested a review from dkwingsmt March 1, 2025 12:27

dkwingsmt approved these changes Mar 11, 2025

View reviewed changes

knopp added 3 commits March 11, 2025 10:33

[macOS] Prepare TextInputPlugin for multi-view

241684c

comments

074e389

Rename to activeTextInputPlugin

c9b723b

knopp force-pushed the multiview_text_input_plugin branch from 429fc13 to c9b723b Compare March 11, 2025 10:04

knopp added this pull request to the merge queue Mar 11, 2025

Merged via the queue into flutter:master with commit 91d195f Mar 11, 2025
170 checks passed

knopp deleted the multiview_text_input_plugin branch March 11, 2025 11:39

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to b60d60a16673 (20 revisions) flutter/packages#8846

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

63733ed

…er#164014)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 39dc5717d599 (21 revisions) flutter/packages#8847

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

54f28b9

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

bf6b233

…er#164014)

This was referenced Mar 11, 2025

Roll Flutter from b16430b2fd57 to 7bf883711647 (22 revisions) flutter/packages#8848

Closed

Roll Flutter from b16430b2fd57 to 9d2dcea4ab46 (23 revisions) flutter/packages#8849

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

b1b530f

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

3e1132a

…er#164014)

This was referenced Mar 11, 2025

Roll Flutter from b16430b2fd57 to 463e7516406b (24 revisions) flutter/packages#8850

Closed

Roll Flutter from b16430b2fd57 to 1cfbc3c10622 (25 revisions) flutter/packages#8851

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

49c620e

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

0aca4c3

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

6276547

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

953a0fb

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

141e21a

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

91af2c5

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

4d1981d

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

e8bceb2

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

b7a8c22

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

0089808

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

43899fa

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

707ef50

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

da6d251

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

adc768d

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

f88b17c

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

4fc3b1a

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

be340f6

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

db9d4d8

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

23db1a4

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

c37ab3f

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

318bfa4

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

706ed7d

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

85d64e6

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

f65d58d

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

ce91ac7

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

0fe4dda

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

2ee2278

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

603dc2e

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

729e040

…er#164014)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

91d195f [macOS] Prepare TextInputPlugin for multi-view (flutter/flutt…

7f6bb02

…er#164014)

knopp mentioned this pull request May 26, 2025

TextInput.attach causes crash on macOS with Flutter 3.32.0 #169204

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[macOS] Prepare TextInputPlugin for multi-view#164014

[macOS] Prepare TextInputPlugin for multi-view#164014
knopp merged 3 commits intoflutter:masterfrom
knopp:multiview_text_input_plugin

knopp commented Feb 24, 2025 •

edited

Loading

Uh oh!

chinmaygarde commented Mar 10, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

dkwingsmt Mar 11, 2025

Uh oh!

knopp Mar 11, 2025

Uh oh!

dkwingsmt Mar 11, 2025

Uh oh!

knopp Mar 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

knopp commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

chinmaygarde commented Mar 10, 2025

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

knopp Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

knopp Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

knopp commented Feb 24, 2025 •

edited

Loading