[stable] Cherry-pick change to CanvasKit build flags to fix double download#164341
Merged
auto-submit[bot] merged 4 commits intoflutter:flutter-3.29-candidate.0from Mar 7, 2025
Conversation
Fixes the debug build for CanvasKit. NOTE: We need to build the debug WASM build with `-O1` because building with `-O0` causes Emscripten to produce a binary that is rejected by Chrome for having functions with too many local variables. Building with `-O1` optimizes those locals out. - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
harryterkelsen
added
cp: review
camsim99
approved these changes
Mar 6, 2025
Contributor
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
This seems reasonable to me! I think merge this later after the current stable hotfix release is cut (3.29.1).
|
We really need this merged rather quickly. Waiting for almost three weeks… |
camsim99
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/164341, because - The status or check suite Mac clangd has failed. Please fix the issues identified (or deflake) before re-applying this label. |
camsim99
added
the
autosubmit
auto-submit
bot
merged commit bfcf486
into
flutter:flutter-3.29-candidate.0
156 checks passed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 3, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stable Cherry Pick
Cherry-picks #162198 to stable to fix issue with double-downloading CanvasKit.
Fixes #163250
Impacted Users: All Flutter Web users
Impact Description:
canvaskit.wasm(a roughly 5 MB download) is double-downloaded. While some browsers may retrieve the second request from the cache, not all do.Workaround: None
Risk: Low (a small change to the BUILD flags for CanvasKit that prevents
canvaskit.wasmfrom being downloaded twice)Test Coverage: We don't have a test that checks how many requests there are for
canvaskit.wasmValidation Steps: Build and run any Flutter Web app and check the network requests to see that
canvaskit.wasmis only requested once.