Provide monitor list, display size, refresh rate, and more for Windows by 9AZX · Pull Request #164460 · flutter/flutter

9AZX · 2025-03-02T23:24:03Z

This PR enhances the Windows implementation by adding support for retrieving display properties, available displays, refresh rate, dpi, size, and more.

Fixes: #160660, #125939

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

flutter-dashboard · 2025-04-23T09:40:28Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

engine/src/flutter/shell/platform/windows/flutter_windows_display_monitor.cc

engine/src/flutter/shell/platform/windows/flutter_windows_display_monitor_unittests.cc

engine/src/flutter/shell/platform/windows/flutter_windows_engine.h

engine/src/flutter/shell/platform/windows/flutter_windows_display_monitor.cc

engine/src/flutter/ci/licenses_golden/licenses_flutter

loic-sharma · 2025-04-28T18:26:01Z

@9AZX Apologies for the long response time. This is looking great! I left some minor nitpicks. Feel free to tag me when this is ready for another review.

engine/src/flutter/shell/platform/windows/flutter_windows_display_monitor.cc

loic-sharma · 2025-05-01T23:09:43Z

FYI you have the some test failures: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8716084517876313281/+/u/test:_test:_Host_Tests_for_host_debug_unopt/stdout

[151/610] FlutterWindowsEngineTest.RunHeadless (943 ms)
[INFO:flutter/testing/test_timeout_listener.cc(75)] Test timeout of 300 seconds per test case will be enforced.
Note: Google Test filter = FlutterWindowsEngineTest.RunHeadless
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from FlutterWindowsEngineTest
[ RUN      ] FlutterWindowsEngineTest.RunHeadless
WARN: Renderer11.cpp:972 (initializeD3DDevice): Failed creating Debug D3D11 device - falling back to release runtime.
WARN: Renderer11.cpp:972 (initializeD3DDevice): Failed creating Debug D3D11 device - falling back to release runtime.
[FATAL:flutter/shell/common/display_manager.cc(27)] Check failed: !displays.empty().
[151/610] FlutterWindowsEngineTest.RunHeadless returned/aborted with exit code 3 (943 ms)
[152/610] FlutterWindowsEngineTest.PlatformMessageRespondOnDifferentThread (882 ms)
[INFO:flutter/testing/test_timeout_listener.cc(75)] Test timeout of 300 seconds per test case will be enforced.
Note: Google Test filter = FlutterWindowsEngineTest.PlatformMessageRespondOnDifferentThread

FYI, you can run these tests locally on your machine by running out/flutter_windows_unittests.exe.

9AZX · 2025-06-18T11:49:43Z

FYI, you can run these tests locally on your machine by running out/flutter_windows_unittests.exe.

I was doing that, but i think the test runs headless only on the CI. I'm not getting any errors locally :(

loic-sharma · 2025-06-23T21:57:07Z

@mattkae @knopp Would y'all be able to review this as well? I suspect this will be useful for multi-window :)

engine/src/flutter/shell/platform/windows/flutter_windows_display_monitor.h

mattkae · 2025-08-06T15:42:16Z

Hello, yes i was still planning to land this one but was waiting for reviews...

I will review today! Sorry I had forgotten about it.

mattkae

A few small things, but mostly in line with what I had in mind too :)

engine/src/flutter/shell/platform/windows/display_monitor.h

engine/src/flutter/shell/platform/windows/display_monitor.cc

engine/src/flutter/shell/platform/windows/flutter_windows_engine.cc

… table from engine

mattkae

This looks good to me 🎉

…r Windows (flutter/flutter#164460)

flutter/flutter@9de63a0...92a6bfb 2025-08-07 [email protected] Roll Packages from f0b2726 to 6efb759 (4 revisions) (flutter/flutter#173414) 2025-08-07 [email protected] Provide monitor list, display size, refresh rate, and more for Windows (flutter/flutter#164460) 2025-08-07 [email protected] [android][tool] Consolidate minimum versions for android projects. (flutter/flutter#171965) 2025-08-07 [email protected] Roll Fuchsia Linux SDK from 2Mo76-tiDj4ZCZbPv... to i4vsuEGyP8Xeb5tiy... (flutter/flutter#173409) 2025-08-07 [email protected] Roll Skia from 9a886bdfb716 to a6ccfeafbfba (1 revision) (flutter/flutter#173384) 2025-08-07 [email protected] Fix drawerScrimColor transition. (flutter/flutter#173280) 2025-08-07 [email protected] Roll Skia from dd60ed46a006 to 9a886bdfb716 (2 revisions) (flutter/flutter#173382) 2025-08-06 [email protected] Roll Skia from 05d82af3f4bd to dd60ed46a006 (2 revisions) (flutter/flutter#173376) 2025-08-06 [email protected] Roll Skia from 5518bb27db67 to 05d82af3f4bd (2 revisions) (flutter/flutter#173372) 2025-08-06 [email protected] Roll Skia from 9bb1fc4bc326 to 5518bb27db67 (2 revisions) (flutter/flutter#173363) 2025-08-06 [email protected] Roll Skia from a918c0e08500 to 9bb1fc4bc326 (24 revisions) (flutter/flutter#173355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter#164460) This PR enhances the Windows implementation by adding support for retrieving display properties, available displays, refresh rate, dpi, size, and more. Fixes: flutter#160660, flutter#125939 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Matthew Kosarek <[email protected]>

…r Windows (flutter/flutter#164460)

flutter#164460) This PR enhances the Windows implementation by adding support for retrieving display properties, available displays, refresh rate, dpi, size, and more. Fixes: flutter#160660, flutter#125939 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Matthew Kosarek <[email protected]>

github-actions bot added engine flutter/engine related. See also e: labels. platform-windows Building on or for Windows specifically a: desktop Running on desktop labels Mar 2, 2025

9AZX force-pushed the windows_displays_monitor branch from b9dd753 to 71f9c40 Compare March 11, 2025 10:49

loic-sharma self-requested a review March 24, 2025 17:18

9AZX force-pushed the windows_displays_monitor branch from 71f9c40 to 6d71dc3 Compare April 3, 2025 09:20