Skip to content

(#112207) Adding view_id parameter to DispatchSemanticsAction and UpdateSemantics#164577

Merged
mattkae merged 62 commits intoflutter:masterfrom
canonical:feature/112207
Mar 20, 2025
Merged

(#112207) Adding view_id parameter to DispatchSemanticsAction and UpdateSemantics#164577
mattkae merged 62 commits intoflutter:masterfrom
canonical:feature/112207

Conversation

@mattkae
Copy link
Contributor

@mattkae mattkae commented Mar 4, 2025 •
edited by loic-sharma
Loading

fixes #112207

What's new?

  • Added a view_id on UpdateSemantics
  • Added a view_id on DispatchSemanticsAction
  • Piped the view_id all over creation
  • Updated tests for these actions across the different platforms
  • Added FlutterEngineSendSemanticsAction to the embedder API in order to not break FlutterEngineDispatchSemanticsAction
  • Using this view ID properly on the Windows platform (see engine/src/flutter/shell/platform/windows/flutter_windows_engine.cc)

How to test

  1. Checkout foundation-plus-framework from canonical/flutter
  2. Merge this branch into it
  3. Enable the "Narrator" screen reader on windows
  4. Run the Multi window reference app (see PR for details)
  5. Open up another window, and note that the right buttons and things are being highlighted, as the screenreader would expect 🎉

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-windows Building on or for Windows specifically platform-linux Building on or for Linux specifically a: desktop Running on desktop labels Mar 4, 2025
@mattkae mattkae changed the title Initial wip (#112207) Initial WIP of piping the view_id through the semantics actions Mar 4, 2025
@github-actions github-actions bot added platform-ios iOS applications specifically platform-fuchsia Fuchsia code specifically team-ios Owned by iOS platform team labels Mar 7, 2025
@github-actions github-actions bot added the platform-android Android applications specifically label Mar 7, 2025
@github-actions github-actions bot added the platform-web Web applications specifically label Mar 8, 2025
@github-actions github-actions bot removed the platform-web Web applications specifically label Mar 10, 2025
Merged via the queue into flutter:master with commit 554c814 Mar 20, 2025
172 of 173 checks passed
@mattkae mattkae deleted the feature/112207 branch March 20, 2025 17:18
@Piinks Piinks mentioned this pull request Mar 21, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
d92f6dd 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
fd02fd5 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
d0fbe59 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
ca81aaa 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
fdc3cdc 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
8070cae 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
26d0a8e 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
b7fbe38 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
77a08ff 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
32463aa 
…on and UpdateSemantics (flutter/flutter#164577)
github-merge-queue bot pushed a commit that referenced this pull request Mar 26, 2025
@loic-sharma
Fix CODEOWNERS after monorepo merge (#165217)
5c3bc83 
GitHub's CODEOWNERS feature [picks the first file it finds in the root,
`.github/`, or `docs/`
directory](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-file-location).
GitHub does not support nested CODEOWNERS files.

For example, this PR updates the embedder API but did not request
reviews from the embedder API reviewers:
#164577

To fix this, this merges all `CODEOWNERS` files to the root of the repo.

cc @cbracken @chinmaygarde @jmagman as you are added as CODEOWNERS.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
450e444 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
3a61be5 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
ab1f7ce 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
33ea80e 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
1f21c98 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
aa68e02 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
82cd37a 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
8d6c52f 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
a159f41 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
1f938d4 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
518f2c0 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
8eca29f 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
2323605 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
d0f145a 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
02f5f24 
…on and UpdateSemantics (flutter/flutter#164577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
554c814 (#112207) Adding view_id parameter to DispatchSemanticsActi…
b4d4882 
…on and UpdateSemantics (flutter/flutter#164577)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert-ancell robert-ancell robert-ancell approved these changes

@justinmc justinmc justinmc approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

@chunhtai chunhtai chunhtai approved these changes

@hbatagelo hbatagelo Awaiting requested review from hbatagelo

@knopp knopp Awaiting requested review from knopp

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-android Android applications specifically platform-fuchsia Fuchsia code specifically platform-ios iOS applications specifically platform-linux Building on or for Linux specifically platform-macos platform-windows Building on or for Windows specifically team-ios Owned by iOS platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SemanticsActions need to be associated with a view

8 participants

@mattkae @loic-sharma @reidbaker @chunhtai @chinmaygarde @robert-ancell @justinmc @Saviq