Make LLDB check a warning instead of a failure by vashworth · Pull Request #164828 · flutter/flutter

vashworth · 2025-03-07T23:21:17Z

We added LLDB file in #164344. This adjusts it so if the LLDB file is missing it gives a warning rather than an error that fails the build.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

loic-sharma · 2025-03-10T20:51:39Z

packages/flutter_tools/lib/src/build_system/targets/ios.dart

    if (srcRoot == null) {
-      throw MissingDefineException(kSdkRoot, name);
+      environment.logger.printError('Failed to find $srcRoot');
+      return;


Why change this one? It looks like the unpack ios target throws a missing define exception for this case too:

flutter/packages/flutter_tools/lib/src/build_system/targets/ios.dart

Lines 265 to 268 in cd433d4

final String? sdkRoot = environment.defines[kSdkRoot];

if (sdkRoot == null) {

throw MissingDefineException(kSdkRoot, name);

}

Just to be safe. Basically, if this target fails, we don't want it to stop the build.

Personally I would keep the exceptions for things that are unexpected and indicate a bug in our logic that we should investigate. I don't feel strongly though, feel free to keep as is.

loic-sharma · 2025-03-10T23:06:01Z

packages/flutter_tools/test/general.shard/build_system/targets/ios_test.dart

-          throwsToolExit(
-            message: 'Debugging Flutter on new iOS versions requires an LLDB Init File.',
-          ),
+          buffer.toString(),


Silly nit: could push the .toString() to capturedConsolePrint's implementation. This might be nice if we end up using capturedConsolePrint in more locations in the future. I don't feel strongly, feel free to skip

…er#164828)

We added LLDB file in flutter#164344. This adjusts it so if the LLDB file is missing it gives a warning rather than an error that fails the build. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Make LLDB check a warning instead of a failure

9fcd4f2

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Mar 8, 2025

vashworth marked this pull request as ready for review March 10, 2025 14:31

vashworth requested a review from loic-sharma March 10, 2025 14:31

loic-sharma reviewed Mar 10, 2025

View reviewed changes

loic-sharma approved these changes Mar 10, 2025

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2025

auto-submit bot added this pull request to the merge queue Mar 10, 2025

Merged via the queue into flutter:master with commit 84b38b8 Mar 10, 2025
140 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

f5dbd29

…er#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to b60d60a16673 (20 revisions) flutter/packages#8846

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

f1cabd3

…er#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 39dc5717d599 (21 revisions) flutter/packages#8847

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

0a9486f

…er#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 7bf883711647 (22 revisions) flutter/packages#8848

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

dc7c61d

…er#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 9d2dcea4ab46 (23 revisions) flutter/packages#8849

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

e92cf27

…er#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 463e7516406b (24 revisions) flutter/packages#8850

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

2711384

…er#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 1cfbc3c10622 (25 revisions) flutter/packages#8851

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

9da80c1

…er#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 61a5fe792957 (26 revisions) flutter/packages#8852

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

64355ad

…er#164828)

engine-flutter-autoroll mentioned this pull request Mar 12, 2025

Roll Flutter from b16430b2fd57 to eef31a1c2b73 (34 revisions) flutter/packages#8856

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

dc50364

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

af984c1

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

a1e2737

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

d4df2f4

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

d328427

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

9b773ca

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

c3969da

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

9d33976

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

5a29704

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

2189fad

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

98fa47a

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

de0b3bb

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

2df497e

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

f08daed

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

cde9759

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

81a677a

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

29d619d

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

978f346

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

4488250

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

fd49d94

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

819b124

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

1bd6445

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

a3bcbb4

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

5d9278b

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

ea028e8

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

5648e82

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

8a71588

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

e66cfbd

…er#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

84b38b8 Make LLDB check a warning instead of a failure (flutter/flutt…

9e9b5f4

…er#164828)

mraleph mentioned this pull request Jul 25, 2025

LLDB can’t locate Dart VM sources when building engine with --no-prebuilt-dart-sdk #172686

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make LLDB check a warning instead of a failure#164828

Make LLDB check a warning instead of a failure#164828
auto-submit[bot] merged 1 commit intoflutter:masterfrom
vashworth:lldb_init_warning

vashworth commented Mar 7, 2025 •

edited

Loading

Uh oh!

loic-sharma Mar 10, 2025

Uh oh!

vashworth Mar 10, 2025

Uh oh!

loic-sharma Mar 10, 2025

Uh oh!

loic-sharma Mar 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	final String? sdkRoot = environment.defines[kSdkRoot];
	if (sdkRoot == null) {
	throw MissingDefineException(kSdkRoot, name);
	}

Conversation

vashworth commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

loic-sharma Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

vashworth Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

loic-sharma Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

loic-sharma Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vashworth commented Mar 7, 2025 •

edited

Loading