Fix: Localization for non zero time in 24 hours format by rkishan516 · Pull Request #164885 · flutter/flutter

rkishan516 · 2025-03-10T02:51:51Z

Fix: Localization for non zero time in 24 hours format
fixes: #164860

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

packages/flutter/lib/src/material/time_picker.dart

QuncCccccc

LGTM! Thank you!

packages/flutter/test/material/time_picker_test.dart

dkwingsmt · 2025-03-27T17:33:52Z

packages/flutter/test/material/time_picker_test.dart

+      tester.element(find.byType(TimePickerDialog)),
+    );
+
+    final List<String> labels00To23 = List<String>.generate(24, (int index) {


Can we instead use the literal strings for the numbers for comparison? (Probably just print them out in the console and copy them.) This way it's clearer what we're looking for, and avoids the current way which feels like just repeating the implementation code.

Sure, pushing required change.

dkwingsmt · 2025-03-28T22:04:16Z

packages/flutter/test/material/time_picker_test.dart

+      materialType: MaterialType.material3,
+    );
+
+    final List<String> labels00To23 = <String>[


Does it mean all numbers are displayed in Arabic numerals? Although this is consistent, I thought #164860 wanted all numbers to display in Farsi. (I'm not really sure which is the correct)

I confirm that numbers should be in Farsi, according to Android Google Calendar app.

Oh, sorry. My bad, even at expectation I could see its farsi. Let me do the change and push.

dkwingsmt

LGTM. Thank you!

…er/flutter#164885)

flutter/flutter@aef4718...ecabb1a 2025-04-17 [email protected] Hide error on mDNS registration failure and print warning in flutter attach (flutter/flutter#166782) 2025-04-17 [email protected] Add support for language hints in TextFields (Android only) (flutter/flutter#165554) 2025-04-17 [email protected] Roll Skia from d8f13372549d to cc2b57434651 (1 revision) (flutter/flutter#167331) 2025-04-17 [email protected] Add DropdownMenu.restorationId (flutter/flutter#166684) 2025-04-17 [email protected] Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (flutter/flutter#167325) 2025-04-17 [email protected] fix(CircularProgressIndicator.adaptive): strokeWidth default value (flutter/flutter#165370) 2025-04-17 [email protected] Remove unnecessary builder (flutter/flutter#166623) 2025-04-17 [email protected] Add a `gradle_errors.dart`entry for missing NDK source.properties file (flutter/flutter#167320) 2025-04-17 [email protected] Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) (flutter/flutter#167255) 2025-04-17 [email protected] Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (flutter/flutter#167243) 2025-04-16 [email protected] Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (flutter/flutter#167312) 2025-04-16 [email protected] Don't throw on error for mDNS when searching for Dart VML url on core devices (flutter/flutter#167135) 2025-04-16 [email protected] Fix: Localization for non zero time in 24 hours format (flutter/flutter#164885) 2025-04-16 [email protected] Updated docstrings for TextureContents (flutter/flutter#167221) 2025-04-16 [email protected] Broke cyclical dependency with dlpath and typographer. (flutter/flutter#167293) 2025-04-16 [email protected] Set an additional CMake arg in `forceNdkDownload` to make the task name align with the `BuildType` (flutter/flutter#167240) 2025-04-16 [email protected] Fix Carousel crashes when using PageStorageKey (flutter/flutter#166817) 2025-04-16 [email protected] Revert "Removed superfluous copy in license checker (#167146)" (flutter/flutter#167246) 2025-04-16 [email protected] [native assets] Roll dependencies (flutter/flutter#167287) 2025-04-16 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#167259) 2025-04-16 [email protected] Feat: Add carousel view theme (flutter/flutter#164769) 2025-04-16 [email protected] Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167261) 2025-04-16 [email protected] When using --local-web-sdk, use a locally built Dart SDK if one is available (flutter/flutter#166732) 2025-04-16 [email protected] Added emulator version to doctor (flutter/flutter#167236) 2025-04-16 [email protected] Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fix: Localization for non zero time in 24 hours format fixes: flutter#164860 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

flutter/flutter@aef4718...ecabb1a 2025-04-17 [email protected] Hide error on mDNS registration failure and print warning in flutter attach (flutter/flutter#166782) 2025-04-17 [email protected] Add support for language hints in TextFields (Android only) (flutter/flutter#165554) 2025-04-17 [email protected] Roll Skia from d8f13372549d to cc2b57434651 (1 revision) (flutter/flutter#167331) 2025-04-17 [email protected] Add DropdownMenu.restorationId (flutter/flutter#166684) 2025-04-17 [email protected] Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (flutter/flutter#167325) 2025-04-17 [email protected] fix(CircularProgressIndicator.adaptive): strokeWidth default value (flutter/flutter#165370) 2025-04-17 [email protected] Remove unnecessary builder (flutter/flutter#166623) 2025-04-17 [email protected] Add a `gradle_errors.dart`entry for missing NDK source.properties file (flutter/flutter#167320) 2025-04-17 [email protected] Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) (flutter/flutter#167255) 2025-04-17 [email protected] Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (flutter/flutter#167243) 2025-04-16 [email protected] Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (flutter/flutter#167312) 2025-04-16 [email protected] Don't throw on error for mDNS when searching for Dart VML url on core devices (flutter/flutter#167135) 2025-04-16 [email protected] Fix: Localization for non zero time in 24 hours format (flutter/flutter#164885) 2025-04-16 [email protected] Updated docstrings for TextureContents (flutter/flutter#167221) 2025-04-16 [email protected] Broke cyclical dependency with dlpath and typographer. (flutter/flutter#167293) 2025-04-16 [email protected] Set an additional CMake arg in `forceNdkDownload` to make the task name align with the `BuildType` (flutter/flutter#167240) 2025-04-16 [email protected] Fix Carousel crashes when using PageStorageKey (flutter/flutter#166817) 2025-04-16 [email protected] Revert "Removed superfluous copy in license checker (#167146)" (flutter/flutter#167246) 2025-04-16 [email protected] [native assets] Roll dependencies (flutter/flutter#167287) 2025-04-16 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#167259) 2025-04-16 [email protected] Feat: Add carousel view theme (flutter/flutter#164769) 2025-04-16 [email protected] Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167261) 2025-04-16 [email protected] When using --local-web-sdk, use a locally built Dart SDK if one is available (flutter/flutter#166732) 2025-04-16 [email protected] Added emulator version to doctor (flutter/flutter#167236) 2025-04-16 [email protected] Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…er/flutter#164885)

Fix: Localization for non zero time in 24 hours format fixes: flutter#164860 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…er/flutter#164885)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 10, 2025

dkwingsmt requested a review from QuncCccccc March 19, 2025 18:22

QuncCccccc reviewed Mar 27, 2025

View reviewed changes

packages/flutter/lib/src/material/time_picker.dart Show resolved Hide resolved

QuncCccccc approved these changes Mar 27, 2025

View reviewed changes

Piinks reviewed Mar 27, 2025

View reviewed changes

packages/flutter/test/material/time_picker_test.dart Show resolved Hide resolved

dkwingsmt reviewed Mar 27, 2025

View reviewed changes

rkishan516 force-pushed the farsi-time-picker-localization branch from 1e7f880 to 0ee21a8 Compare March 27, 2025 23:15

dkwingsmt reviewed Mar 28, 2025

View reviewed changes

Fix: Localization for non zero time in 24 hours format

0080889

rkishan516 force-pushed the farsi-time-picker-localization branch from d0448b6 to 0080889 Compare March 29, 2025 01:35

dkwingsmt self-requested a review April 9, 2025 18:18

dkwingsmt approved these changes Apr 16, 2025

View reviewed changes

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025

auto-submit bot added this pull request to the merge queue Apr 16, 2025

Merged via the queue into flutter:master with commit 37fa9ae Apr 16, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2025

37fa9ae Fix: Localization for non zero time in 24 hours format (flutt…

0838ac5

…er/flutter#164885)

engine-flutter-autoroll mentioned this pull request Apr 17, 2025

Roll Flutter from aef4718b3956 to ecabb1a05212 (25 revisions) flutter/packages#9104

Merged

This comment was marked as spam.

Sign in to view

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

37fa9ae Fix: Localization for non zero time in 24 hours format (flutt…

20e16fe

…er/flutter#164885)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

37fa9ae Fix: Localization for non zero time in 24 hours format (flutt…

e3968fb

…er/flutter#164885)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

37fa9ae Fix: Localization for non zero time in 24 hours format (flutt…

cad9824

…er/flutter#164885)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

37fa9ae Fix: Localization for non zero time in 24 hours format (flutt…

3652655

…er/flutter#164885)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

37fa9ae Fix: Localization for non zero time in 24 hours format (flutt…

40b7631

…er/flutter#164885)

rkishan516 deleted the farsi-time-picker-localization branch February 20, 2026 03:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Localization for non zero time in 24 hours format#164885

Fix: Localization for non zero time in 24 hours format#164885
auto-submit[bot] merged 1 commit intoflutter:masterfrom
rkishan516:farsi-time-picker-localization

rkishan516 commented Mar 10, 2025

Uh oh!

Uh oh!

QuncCccccc left a comment

Uh oh!

Uh oh!

dkwingsmt Mar 27, 2025 •

edited

Loading

Uh oh!

rkishan516 Mar 27, 2025

Uh oh!

dkwingsmt Mar 28, 2025

Uh oh!

dkwingsmt Mar 28, 2025

Uh oh!

rkishan516 Mar 29, 2025 •

edited

Loading

Uh oh!

dkwingsmt left a comment

Uh oh!

Uh oh!

This comment was marked as spam.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

rkishan516 commented Mar 10, 2025

Pre-launch Checklist

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dkwingsmt Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rkishan516 Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

rkishan516 Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as spam.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dkwingsmt Mar 27, 2025 •

edited

Loading

rkishan516 Mar 29, 2025 •

edited

Loading