[stable] Fixes rendering text rotated 180 degrees#165080
[stable] Fixes rendering text rotated 180 degrees#165080auto-submit[bot] merged 2 commits intoflutter:flutter-3.29-candidate.0from
Conversation
gaaclarke
added
the
cp: stable
github-actions
bot
added
a: text input
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
What a bug lol
|
@gaaclarke what platforms does this effect (affect?)? |
All Impeller users (iOS, Android, some macOS) |
reidbaker
added
the
autosubmit
|
@gaaclarke if you can get all the tests green and this merged tonight it will make the release. I will add a changelog for you in another pr and this will be the last cp for 3.29.2 |
|
autosubmit label was removed for flutter/flutter/165080, because - The status or check suite Windows windows_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
auto-submit
bot
removed
the
autosubmit
Ah shoot, I forgot to edit the changelog. Thanks Reid. |
No worries, Can you get these tests all green. I will come back after EOD cali time and make sure this is landed put up a pr with the changelog for this and the dart version bump then work on the rest of the release tomorrow. |
|
Yea, the failure right now isn't a flake. It's from the SkPoint -> DlPoint refactor, addressing it now. |
reidbaker
added
the
autosubmit
auto-submit
bot
merged commit 31b3a7d
into
flutter:flutter-3.29-candidate.0
cherry-pick of flutter#165008 Impeller users. Text that is rotated 180 degrees exactly will render as if it is scaled by {-1, 1} instead of {-1, -1}. You can rotate text 180.001 degrees instead but the fidelity will be less. If it's wrong it could break all text rendering. There are golden tests for it. Golden tests (which are not run on release branches) flutter#164958 has reproduction code
Changelog for flutter#165075, the dart stable change and for flutter#165080
4 participants
cherry-pick of #165008
Impacted Users
Impeller users.
Impact Description
Text that is rotated 180 degrees exactly will render as if it is scaled by {-1, 1} instead of {-1, -1}.
Workaround
You can rotate text 180.001 degrees instead but the fidelity will be less.
Risk
If it's wrong it could break all text rendering. There are golden tests for it.
Test Coverage
Golden tests (which are not run on release branches)
Validation Steps
#164958 has reproduction code