Update tests to use Xcode 16.2 and iOS 18.2 Simulator#165318
Update tests to use Xcode 16.2 and iOS 18.2 Simulator#165318auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
| final String? iosKey = | ||
| decodeResult.keys.where((String key) => key.contains('iphoneos')).firstOrNull; | ||
| final String? runtimeBuildForSelectedXcode = switch (decodeResult[iosKey]) { | ||
| {'userOverriddenBuild': final String build} => build, |
There was a problem hiding this comment.
Xcode 16.2 is weird in that it originally shipped with iOS 18.2 (22C150), but later the "preferredBuild" became 18.3.1 (22D8075). mac_toolchain is still using iOS 18.2 and sets it as the override build. This will make Flutter tests using a simulator use the override version if set.
This was causing a flaky error: https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20module_test_ios/3351/overview
| destination: 'platform=macOS', | ||
| configuration: 'Debug', | ||
| testName: 'native_plugin_unit_tests_macos', | ||
| extraOptions: <String>['-parallel-testing-enabled', 'NO'], |
There was a problem hiding this comment.
This is potential fix for #164902:
Tests indicate it seem to be effective:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20plugin_test_macos/27007/overview
https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20plugin_test_macos/7/overview
https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20plugin_test_macos/6/overview
https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20plugin_test_macos/8/overview
Runs tests on Xcode 16.2 and iOS 18.2. Also updates engine scenario golden files to iOS 18.2 and removes non-impeller (Skia) test files that we no longer use. All framework tests passing: flutter#148899 (comment) All engine tests passing: flutter#148906 (comment) Fixes flutter#148907 and flutter#148957. - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Runs tests on Xcode 16.2 and iOS 18.2. Also updates engine scenario golden files to iOS 18.2 and removes non-impeller (Skia) test files that we no longer use. All framework tests passing: flutter#148899 (comment) All engine tests passing: flutter#148906 (comment) Fixes flutter#148907 and flutter#148957. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Runs tests on Xcode 16.2 and iOS 18.2. Also updates engine scenario golden files to iOS 18.2 and removes non-impeller (Skia) test files that we no longer use.
All framework tests passing: #148899 (comment)
All engine tests passing: #148906 (comment)
Fixes #148907 and #148957.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.