It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@rkishan516 Maybe you're still working on it but make sure to add some tests. Thank you! (from triage)

@rkishan516 Maybe you're still working on it but make sure to add some tests. Thank you! (from triage)

@dkwingsmt This PR is just migrating code into separate file. So, don't need any test.

I see! Sorry for the confusion.

@TahaTesser Can you take a look if this is what you asked for? If it is then we can approve this since it seems a trivial change.

@rkishan516 @dkwingsmt we still need to follow the process the bot provided to get test exemption. @rkishan516 can you follow the instructions to reach out on Discord to the right folks?

@rkishan516 can you follow the instructions to reach out on Discord to the right folks?

Sure.

Also @dkwingsmt & @Piinks, Rather than creating multiple PRs, I have pushed all changes in this single PR but with multiple commits. Thoughts ?

Yeah, I think for a trivial refactor like moving code doing it together should be preferred. Thanks!

test-exempt: code refactor with no semantic change

I see! Sorry for the confusion.

@TahaTesser Can you take a look if this is what you asked for? If it is then we can approve this since it seems a trivial change.

This looks good! Just have to make sure nothing is missed when moving the code as it is hard to verify every single line is correctly moved.

Also @dkwingsmt & @Piinks, Rather than creating multiple PRs, I have pushed all changes in this single PR but with multiple commits. Thoughts ?

Hey @rkishan516 as we discussed in #162858, it is preferred to break this up into smaller changes so we can review and land it more easily. Regressions are easy to introduce in large code moves like this. #162858 landed after reducing to a smaller segment of moves. Can we continue that as planned?

Hey @rkishan516 as we discussed in #162858, it is preferred to break this up into smaller changes so we can review and land it more easily. Regressions are easy to introduce in large code moves like this. #162858 landed after reducing to a smaller segment of moves. Can we continue that as planned?

@Piinks So that review become easy, I have divided that into commits which can be reviewed easily. But if still required i can change this back. Should i ?