[stable] Removes assumption that basis scalar and rounded_scalar match#165428
Merged
auto-submit[bot] merged 3 commits intoflutter:flutter-3.29-candidate.0from Mar 28, 2025
Merged
Conversation
…r#165166) fixes flutter#165130 - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
github-actions
bot
added
a: text input
gaaclarke
added
cp: review
jonahwilliams
added
the
cp: stable
justinmc
approved these changes
Mar 26, 2025
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . @gaaclarke Are the tests supposed to be failing here?
Contributor
|
We're not sure why the tests are failing: seems like an issue where main/stable disagree about the set of builders? I think we've resolved that before by cherry picking recipie changes into stable. |
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
The `Linux tool_integration_tests*` have been failing on this release branch, blocking cherry picks #165430 and #165428. This PR attempts to cherry pick fixes that will make the tests go green. This PR contains cherry-picks of three PRs: * #164935 * #165620 * #165661 Example of the failures I was seeing: https://github.com/flutter/flutter/pull/165428/checks?check_run_id=38997055797. ``` error: { code: 5 message: builder not found: "Linux tool_integration_tests_1_6" } ```
github-actions
bot
added
a: text input
justinmc
added
the
autosubmit
auto-submit
bot
merged commit e272b5c
into
flutter:flutter-3.29-candidate.0
129 checks passed
Contributor
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
Fintasys
pushed a commit
to Fintasys/flutter
that referenced
this pull request
May 14, 2025
The `Linux tool_integration_tests*` have been failing on this release branch, blocking cherry picks flutter#165430 and flutter#165428. This PR attempts to cherry pick fixes that will make the tests go green. This PR contains cherry-picks of three PRs: * flutter#164935 * flutter#165620 * flutter#165661 Example of the failures I was seeing: https://github.com/flutter/flutter/pull/165428/checks?check_run_id=38997055797. ``` error: { code: 5 message: builder not found: "Linux tool_integration_tests_1_6" } ```
Fintasys
pushed a commit
to Fintasys/flutter
that referenced
this pull request
May 14, 2025
flutter#165428) ## Impacted Users Impeller, all platforms ## Impact Description Text that is scaled over 48x will render at the incorrect size and position ## Workaround Change the font size instead of using a scale, but this isn't always clear from the framework usage. ## Risk If it is wrong, text will be rendered incorrectly. ## Test Coverage A golden test was written but they aren't automatically executed on release branches. ## Validation Steps flutter#165130 has reproduction code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impacted Users
Impeller, all platforms
Impact Description
Text that is scaled over 48x will render at the incorrect size and position
Workaround
Change the font size instead of using a scale, but this isn't always clear from the framework usage.
Risk
If it is wrong, text will be rendered incorrectly.
Test Coverage
A golden test was written but they aren't automatically executed on release branches.
Validation Steps
#165130 has reproduction code