Fix: DraggableScrollableSheet may not close if snapping is enabled by chika3742 · Pull Request #165557 · flutter/flutter

chika3742 · 2025-03-20T09:38:32Z

This PR fixes an issue where a DraggableScrollableSheet with snap set to true and shouldCloseOnMinExtent set to true may not close when dragged downward.

The issue was caused by round-off errors accumulated by addPixelDelta method, which could lead to extent.currentSize not matching the extent.minSize exactly when the bottom is reached. I added logic to correct it when the snapping ballistic animation is complete.

Sample code

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: HomePage(),
    );
  }
}

class HomePage extends StatelessWidget {
  const HomePage({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("DraggableScrollableSheet Test"),
      ),
      body: Center(
        child: ElevatedButton(
          child: Text("Open"),
          onPressed: () {
            showModalBottomSheet(
              context: context,
              showDragHandle: true,
              isScrollControlled: true,
              builder: (context) => _buildBottomSheet(),
            );
          },
        ),
      ),
    );
  }

  Widget _buildBottomSheet() {
    return NotificationListener<DraggableScrollableNotification>(
      onNotification: (notification) {
        print(notification.extent);
        return false;
      },
      child: DraggableScrollableSheet(
        expand: false,
        snap: true,
        shouldCloseOnMinExtent: true,
        maxChildSize: 0.9,
        minChildSize: 0.25,
        builder: (context, scrollController) {
          return ListView.builder(
            controller: scrollController,
            itemCount: 100,
            itemBuilder: (context, index) {
              return ListTile(
                title: Text("Item $index"),
              );
            },
          );
        },
      ),
    );
  }
}

Before applying fix	After
* Occurs with probability Simulator.Screen.Recording.-.iPhone.16.-.2025-03-21.at.01.04.18.mp4	Simulator.Screen.Recording.-.iPhone.16.-.2025-03-21.at.01.05.08.mp4

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…rollableSheet

flutter-dashboard · 2025-03-21T06:47:07Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

justinmc

LGTM with nits 👍

Thanks for jumping in and fixing this!

justinmc · 2025-03-28T20:43:19Z

packages/flutter/lib/src/widgets/draggable_scrollable_sheet.dart

+  /// Checks if the sheet's current size is close to a snap size, returning the
+  /// snap size if so; returns null otherwise.


Nit: I would make this 2 slashes instead of 3. Using 3 is for dart-doc-like comments.

justinmc · 2025-03-28T20:44:30Z

packages/flutter/lib/src/widgets/draggable_scrollable_sheet.dart

-    return extent.snapSizes.any((double snapSize) {
+  /// Checks if the sheet's current size is close to a snap size, returning the
+  /// snap size if so; returns null otherwise.
+  double? get _currentSnapSize {


Nit: I wouldn't make this a getter, to emphasize that there's some calculation that needs to be done.

double? _getCurrentSnapSize() {

See: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#getters-feel-faster-than-methods

@justinmc Thanks for reviewing.
Would it be better to rewrite getters using _currentSnapSize such as _isAtSnapSize and _shouldSnap as a method as well?

flutter/packages/flutter/lib/src/widgets/draggable_scrollable_sheet.dart

Lines 922 to 924 in bc18a80

bool get _isAtSnapSize => _currentSnapSize != null;

bool get _shouldSnap => extent.snap && extent.hasDragged && !_isAtSnapSize;

Ah yes you're right, thanks for catching that.

justinmc · 2025-03-28T20:46:56Z

packages/flutter/test/widgets/draggable_scrollable_sheet_test.dart

    controller.dispose();
  });
+
+  testWidgets('Ensures DraggableScrollableSheet snaps exactly to minChildSize', (


Can you add a link to the issue in a comment? Regression test for https://github.com/flutter/flutter/issues/140701.

justinmc · 2025-03-28T20:49:05Z

packages/flutter/test/widgets/draggable_scrollable_sheet_test.dart

+      const Duration(milliseconds: 500),
+    );
+    expect(lastExtent, .25);
+  });


I confirmed that this fails on master with a tiny rounding error as expected 👍

ValentinVignal

LGTM

justinmc

Renewing my LGTM and will add the autosubmit label.

…abled (flutter/flutter#165557)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) Manual roll requested by [email protected] flutter/flutter@212064a...9bf18f0 2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555) 2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760) 2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757) 2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099) 2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748) 2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742) 2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741) 2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737) 2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868) 2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557) 2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503) 2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303) 2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720) 2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714) 2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699) 2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710) 2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596) 2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711) 2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701) 2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700) 2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676) 2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687) 2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts (flutter/flutter#166150) 2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680) 2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675) 2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666) 2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114) 2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389) 2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

) Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) Manual roll requested by [email protected] flutter/flutter@212064a...9bf18f0 2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555) 2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760) 2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757) 2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099) 2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748) 2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742) 2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741) 2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737) 2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868) 2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557) 2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503) 2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303) 2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720) 2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714) 2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699) 2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710) 2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596) 2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711) 2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701) 2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700) 2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676) 2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687) 2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts (flutter/flutter#166150) 2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680) 2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675) 2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666) 2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114) 2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389) 2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

…(#9041) Manual roll Flutter from 212064a3e558 to 9bf18f097137 (32 revisions) Manual roll requested by [email protected] flutter/flutter@212064a...9bf18f0 2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555) 2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760) 2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757) 2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099) 2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748) 2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742) 2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741) 2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737) 2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868) 2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557) 2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503) 2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303) 2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720) 2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714) 2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699) 2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710) 2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596) 2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711) 2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701) 2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700) 2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676) 2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687) 2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts (flutter/flutter#166150) 2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680) 2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675) 2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666) 2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114) 2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389) 2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

…abled (flutter/flutter#165557)

) Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) Manual roll requested by [email protected] flutter/flutter@212064a...9bf18f0 2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555) 2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760) 2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757) 2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099) 2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748) 2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742) 2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741) 2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737) 2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868) 2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557) 2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503) 2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303) 2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720) 2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714) 2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699) 2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710) 2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596) 2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711) 2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701) 2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700) 2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676) 2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687) 2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts (flutter/flutter#166150) 2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680) 2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675) 2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666) 2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114) 2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389) 2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

@OverRide

…lutter#165557)  fixes flutter#140701 This PR fixes an issue where a DraggableScrollableSheet with `snap` set to true and `shouldCloseOnMinExtent` set to true may not close when dragged downward. The issue was caused by round-off errors accumulated by `addPixelDelta` method, which could lead to `extent.currentSize` not matching the `extent.minSize` exactly when the bottom is reached. I added logic to correct it when the snapping ballistic animation is complete. <details> <summary>Sample code</summary> ```Dart import 'package:flutter/material.dart'; void main() { runApp(MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( home: HomePage(), ); } } class HomePage extends StatelessWidget { const HomePage({super.key}); @OverRide Widget build(BuildContext context) { return Scaffold( appBar: AppBar( title: Text("DraggableScrollableSheet Test"), ), body: Center( child: ElevatedButton( child: Text("Open"), onPressed: () { showModalBottomSheet( context: context, showDragHandle: true, isScrollControlled: true, builder: (context) => _buildBottomSheet(), ); }, ), ), ); } Widget _buildBottomSheet() { return NotificationListener<DraggableScrollableNotification>( onNotification: (notification) { print(notification.extent); return false; }, child: DraggableScrollableSheet( expand: false, snap: true, shouldCloseOnMinExtent: true, maxChildSize: 0.9, minChildSize: 0.25, builder: (context, scrollController) { return ListView.builder( controller: scrollController, itemCount: 100, itemBuilder: (context, index) { return ListTile( title: Text("Item $index"), ); }, ); }, ), ); } } ``` </details> | Before applying fix | After | | --- | --- | | * Occurs with probability <video src="proxy.php?url=https://github.com/user-attachments/assets/ffd2d097-3ed5-4775-90d5-950092d49591"> | <video src="proxy.php?url=https://github.com/user-attachments/assets/0f20cb81-3444-40a3-a84d-ed4bff15887e"> | ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

) Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) Manual roll requested by [email protected] flutter/flutter@212064a...9bf18f0 2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555) 2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760) 2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757) 2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099) 2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748) 2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742) 2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741) 2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737) 2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868) 2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557) 2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503) 2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303) 2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720) 2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714) 2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699) 2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710) 2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596) 2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711) 2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701) 2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700) 2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676) 2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687) 2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts (flutter/flutter#166150) 2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680) 2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675) 2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909) 2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666) 2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114) 2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389) 2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

@OverRide

…lutter#165557)  fixes flutter#140701 This PR fixes an issue where a DraggableScrollableSheet with `snap` set to true and `shouldCloseOnMinExtent` set to true may not close when dragged downward. The issue was caused by round-off errors accumulated by `addPixelDelta` method, which could lead to `extent.currentSize` not matching the `extent.minSize` exactly when the bottom is reached. I added logic to correct it when the snapping ballistic animation is complete. <details> <summary>Sample code</summary> ```Dart import 'package:flutter/material.dart'; void main() { runApp(MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( home: HomePage(), ); } } class HomePage extends StatelessWidget { const HomePage({super.key}); @OverRide Widget build(BuildContext context) { return Scaffold( appBar: AppBar( title: Text("DraggableScrollableSheet Test"), ), body: Center( child: ElevatedButton( child: Text("Open"), onPressed: () { showModalBottomSheet( context: context, showDragHandle: true, isScrollControlled: true, builder: (context) => _buildBottomSheet(), ); }, ), ), ); } Widget _buildBottomSheet() { return NotificationListener<DraggableScrollableNotification>( onNotification: (notification) { print(notification.extent); return false; }, child: DraggableScrollableSheet( expand: false, snap: true, shouldCloseOnMinExtent: true, maxChildSize: 0.9, minChildSize: 0.25, builder: (context, scrollController) { return ListView.builder( controller: scrollController, itemCount: 100, itemBuilder: (context, index) { return ListTile( title: Text("Item $index"), ); }, ); }, ), ); } } ``` </details> | Before applying fix | After | | --- | --- | | * Occurs with probability <video src="proxy.php?url=https://github.com/user-attachments/assets/ffd2d097-3ed5-4775-90d5-950092d49591"> | <video src="proxy.php?url=https://github.com/user-attachments/assets/0f20cb81-3444-40a3-a84d-ed4bff15887e"> | ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Kiruel · 2025-10-24T09:42:30Z

Hello, how do you know this is on stable version or not ? Based on this PR, I only know if it's on master branch.

chika3742 · 2025-10-24T10:22:41Z

@Kiruel I think this is included in 3.32 release.

https://docs.flutter.dev/release/release-notes/release-notes-3.32.0

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Mar 20, 2025

chika3742 force-pushed the fix-draggable-scrollable-sheet branch 2 times, most recently from a6f07f5 to c135caa Compare March 20, 2025 12:12

fix: round extent size after snap animation completion in DraggableSc…

67abd35

…rollableSheet

chika3742 force-pushed the fix-draggable-scrollable-sheet branch from c135caa to 67abd35 Compare March 20, 2025 15:32

chika3742 marked this pull request as ready for review March 20, 2025 15:32

chika3742 marked this pull request as draft March 21, 2025 06:45

chika3742 marked this pull request as ready for review March 21, 2025 13:42

fix test

26c77b7

chika3742 marked this pull request as draft March 23, 2025 12:58

chika3742 and others added 3 commits March 24, 2025 09:26

Implement using a different approach

b0a0754

Merge branch 'master' into fix-draggable-scrollable-sheet

0752d4f

format fix

bc18a80

chika3742 marked this pull request as ready for review March 24, 2025 02:33

justinmc approved these changes Mar 28, 2025

View reviewed changes

minor fixes

175cb83

ValentinVignal approved these changes Mar 31, 2025

View reviewed changes

Merge branch 'master' into fix-draggable-scrollable-sheet

62dff46

justinmc approved these changes Apr 8, 2025

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025

auto-submit bot added this pull request to the merge queue Apr 8, 2025

Merged via the queue into flutter:master with commit cd0082f Apr 8, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025

gidrokolbaska mentioned this pull request Apr 8, 2025

DraggableScrollableSheet from showModalBottomSheet snaps to unspecified extent #116982

Closed

engine-flutter-autoroll mentioned this pull request Apr 8, 2025

Roll Flutter from 02f13c37841f to fd42f34d76f9 (48 revisions) flutter/packages#9026

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

9905ff2

…abled (flutter/flutter#165557)

engine-flutter-autoroll mentioned this pull request Apr 8, 2025

Roll Flutter from 02f13c37841f to ca3788316551 (49 revisions) flutter/packages#9027

Closed

engine-flutter-autoroll mentioned this pull request Apr 9, 2025

Roll Flutter from 02f13c37841f to 4ab2102665a5 (75 revisions) flutter/packages#9040

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

5ce29fb

…abled (flutter/flutter#165557)

engine-flutter-autoroll mentioned this pull request Apr 9, 2025

Manual roll Flutter from 212064a3e558 to 9bf18f097137 (32 revisions) flutter/packages#9041

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

8e56600

…abled (flutter/flutter#165557)

engine-flutter-autoroll mentioned this pull request Apr 9, 2025

Roll Flutter from 212064a3e558 to 059326d49dcd (55 revisions) flutter/packages#9042

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

024b610

…abled (flutter/flutter#165557)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

323b69a

…abled (flutter/flutter#165557)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

96436d3

…abled (flutter/flutter#165557)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

6ab10a3

…abled (flutter/flutter#165557)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

b6ea6e6

…abled (flutter/flutter#165557)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

5a406b6

…abled (flutter/flutter#165557)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

07af6c9

…abled (flutter/flutter#165557)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

4604b05

…abled (flutter/flutter#165557)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

ae54ce2

…abled (flutter/flutter#165557)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

081e4f1

…abled (flutter/flutter#165557)

Piinks mentioned this pull request Apr 18, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

30d9407

…abled (flutter/flutter#165557)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

fbb5318

…abled (flutter/flutter#165557)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

cd0082f Fix: DraggableScrollableSheet may not close if snapping is en…

6f06ffa

…abled (flutter/flutter#165557)

chika3742 deleted the fix-draggable-scrollable-sheet branch May 23, 2025 05:43

		/// Checks if the sheet's current size is close to a snap size, returning the
		/// snap size if so; returns null otherwise.

	bool get _isAtSnapSize => _currentSnapSize != null;

	bool get _shouldSnap => extent.snap && extent.hasDragged && !_isAtSnapSize;

Conversation

chika3742 commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Mar 21, 2025

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

chika3742 Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

ValentinVignal left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Kiruel commented Oct 24, 2025

Uh oh!

chika3742 commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chika3742 commented Mar 20, 2025 •

edited

Loading

chika3742 Mar 29, 2025 •

edited

Loading