Wire up MenuAnchor, MenuBar, MenuItem-related widgets to aria roles#165596
Merged
auto-submit[bot] merged 17 commits intoflutter:masterfrom Apr 24, 2025
Merged
Wire up MenuAnchor, MenuBar, MenuItem-related widgets to aria roles#165596auto-submit[bot] merged 17 commits intoflutter:masterfrom
MenuAnchor, MenuBar, MenuItem-related widgets to aria roles#165596auto-submit[bot] merged 17 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
framework
Contributor
Author
|
Once #164439 land, tests will be fixed. |
QuncCccccc
force-pushed
the
menu_anchor_semantcs_role
branch
from
9b73d1f to
74d845f
Compare
github-actions
bot
added
d: api docs
chrisbobbe
added a commit
to QuncCccccc/zulip-flutter
that referenced
this pull request
Mar 27, 2025
Flutter PR flutter/flutter#165596 (wiring up MenuAnchor-related widgets to SemanticsRole) breaks this test; fix it by adding the needed Semantics wrappers. Co-authored-by: Chris Bobbe <[email protected]>
Contributor
Author
|
Created zulip/zulip-flutter#1443 to fix customer testing. |
chrisbobbe
added a commit
to QuncCccccc/zulip-flutter
that referenced
this pull request
Mar 27, 2025
Flutter PR flutter/flutter#165596 (wiring up MenuAnchor-related widgets to SemanticsRole) breaks this test; fix it by adding the needed Semantics wrappers. Co-authored-by: Chris Bobbe <[email protected]>
QuncCccccc
force-pushed
the
menu_anchor_semantcs_role
branch
from
e2a509e to
f8a9f49
Compare
8 tasks
QuncCccccc
added a commit
to flutter/tests
that referenced
this pull request
Mar 28, 2025
This is to fix the customer testing in flutter/flutter#165596 by picking up zulip/zulip-flutter#1443 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read the [Flutter Style Guide] _recently_, and have followed its advice. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.
QuncCccccc
force-pushed
the
menu_anchor_semantcs_role
branch
from
f8a9f49 to
ae30e5b
Compare
QuncCccccc
commented
Mar 28, 2025
| @@ -1 +1 @@ | |||
| 3566ea0e688123cecc2b605bda13732adc1e610a | |||
| 8be72094d9b33dae8ff8a7085a3d922e7b3cad47 | |||
Contributor
Author
There was a problem hiding this comment.
This is intended to fix the customer testing.
QuncCccccc
commented
Mar 28, 2025
|
|
||
| static FlutterError? _semanticsMenu(SemanticsNode node) { | ||
| if (node.childrenCount < 1) { | ||
| return FlutterError('a menu cannot be empty'); |
Contributor
Author
There was a problem hiding this comment.
I think a menu can be empty if we have filter behavior, so I removed this check.
chunhtai
reviewed
Apr 1, 2025
|
|
||
| @override | ||
| Widget buildAnchor(BuildContext context) { | ||
| final Widget? overlayPortal = |
Contributor
Author
There was a problem hiding this comment.
We want the menu button and the menu have a parent-children relationship, but for OverlayPortal, its child and overlayChildBuilder are siblings relationship. To construct parent-children relationship, we use RawMenuAnchor.builder as the parent to wrap OverlayPortal which is constructed by RawMenuAnchor.child and RawMenuAnchor.overlayBuilder.
The disadvantage for this change is, if either widget.child or widget.builder is null, we are not able to have the parent-children relationship, but SubmenuButton is implemented by using both, so it should be okay.
4 tasks
Contributor
Author
|
Breaking change page: flutter/website#11881 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 29, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 29, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 29, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
This was referenced May 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to wire up
MenuAnchorrelated widgets to SemanticsRole.MenuAnchorand a menu is opened, the menu hasSemanticsRole.menu.MenuBarhasSemanticsRole.menuBarMenuItemButtonhasSemanticsRole.menuItemSubmenuButtonhasSemanticsRole.menuItemwitharia-haspopupattribute setup.CheckboxMenuButtonhasSemanticsRole.menuItemCheckboxRadioMenuButtonhasSemanticsRole.menuItemRadioThis PR also includes some changes related to
OverlayPortalandRawMenuAnchorso the "button" and the "menu" that the button opens has a "parent-children" relationship. Previously, they are siblings relationship which will cause some navigation issue in a11y.Pre-launch Checklist
///).