Fix warning when building for macOS desktop by Sameri11 · Pull Request #165996 · flutter/flutter

Sameri11 · 2025-03-26T16:31:35Z

This PR resolves warning when building macOS app in environments with multiple available destinations (i.e. arm Macs with Rosetta).

	Debug	Release	Profile
Before
After

For release/profile builds generic/platform=macOS was chosen because these configurations are "fat" (includes all arches) so it is a preferred way of building device-agnostic actions such as xcodebuild build, as per xcodebuild documentation.

fixes #86590

Also, kudos to @zhibisora. This PR is heavily inspired by #148920. Although, I failed to properly rebase it onto current master (you know, monorepo merge and format changes).

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jellis206 · 2025-03-28T20:26:44Z

I believe in you!

packages/flutter_tools/lib/src/macos/build_macos.dart

packages/flutter_tools/test/commands.shard/hermetic/build_macos_test.dart

vashworth

LGTM! Woo, super happy to see this fixed. Thanks for the PR!

Sameri11 · 2025-05-19T07:20:20Z

Hi @bkonyi ! Just a gentle reminder about this. If you could take a moment to review it, I would greatly appreciate it!

bkonyi · 2025-05-26T13:30:12Z

Sorry for the delay @Sameri11! This one slipped past me.

LGTM!

Sameri11 · 2025-05-26T15:57:50Z

@vashworth @bkonyi thanks for review! :)

@zhibisora

This PR resolves warning when building macOS app in environments with multiple available destinations (i.e. arm Macs with Rosetta). | | Debug | Release | Profile | |---|---|---|---| | **Before** | <img width="657" alt="image" src="proxy.php?url=https://github.com/user-attachments/assets/5207f2cc-2785-4bef-8eb0-e9a5a7431c91" /> | <img width="699" alt="image" src="proxy.php?url=https://github.com/user-attachments/assets/31f38373-adf9-4797-982d-782569be0681" /> | <img width="699" alt="image" src="proxy.php?url=https://github.com/user-attachments/assets/be1432f9-0668-44b9-b75e-ae4a56c0ff6e" /> | | **After** | <img width="672" alt="image" src="proxy.php?url=https://github.com/user-attachments/assets/62f3b37b-8461-4274-b9be-53df22bec82d" /> | <img width="672" alt="image" src="proxy.php?url=https://github.com/user-attachments/assets/7c0489e7-0f7f-4498-b9d2-6d566722a05a" /> | <img width="672" alt="image" src="proxy.php?url=https://github.com/user-attachments/assets/d0a3e065-3ae7-4d53-beb5-d2a96aa01aea" /> | For release/profile builds `generic/platform=macOS` was chosen because these configurations are "fat" (includes all arches) so it is a preferred way of building device-agnostic actions such as `xcodebuild build`, as per `xcodebuild` documentation. fixes flutter#86590 Also, kudos to @zhibisora. This PR is heavily inspired by flutter#148920. Although, I failed to properly rebase it onto current master (you know, monorepo merge and format changes). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…165996)

flutter/flutter@4372bfb...0e536eb 2025-05-28 [email protected] Introduces FlutterPluginRegistrant protocol. (flutter/flutter#169399) 2025-05-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Initialize `default-flavor` in `FlutterCommand`, adds integration test. (#169298)" (flutter/flutter#169581) 2025-05-28 [email protected] Initialize `default-flavor` in `FlutterCommand`, adds integration test. (flutter/flutter#169298) 2025-05-28 [email protected] Update DEPS to add dart-lang/ai repo (flutter/flutter#169540) 2025-05-28 [email protected] Roll Skia from 92311f2ba0b7 to 82d326fc2148 (1 revision) (flutter/flutter#169552) 2025-05-28 [email protected] dev/bots: improve service worker test code (flutter/flutter#169231) 2025-05-28 [email protected] Make Android team platform view TESTOWNERS (flutter/flutter#169297) 2025-05-28 [email protected] Roll Skia from 044f58f78a73 to 92311f2ba0b7 (9 revisions) (flutter/flutter#169542) 2025-05-27 [email protected] Roll Skia from 443f5257f382 to 044f58f78a73 (16 revisions) (flutter/flutter#169530) 2025-05-27 [email protected] [web] Fix unresponsive input above SelectionArea in Safari and Firefox. (flutter/flutter#167275) 2025-05-27 [email protected] Set pause_isolates_on_start flag if --start-paused (flutter/flutter#169392) 2025-05-27 [email protected] Roll Packages from af0b9a9 to 6eebe72 (24 revisions) (flutter/flutter#169514) 2025-05-27 [email protected] Roll Fuchsia Linux SDK from 5mpmPsuD8rpeiJizT... to nC9hLWjYVlChDTEPh... (flutter/flutter#169498) 2025-05-27 [email protected] Split hint from label and expose it via aria-description or aria-describedby (flutter/flutter#169157) 2025-05-26 [email protected] 🐛 Normalize generated file paths for the l10n generator (flutter/flutter#169467) 2025-05-26 [email protected] Roll Dart SDK from d811152316e4 to 6aeb798bdbe2 (2 revisions) (flutter/flutter#169478) 2025-05-26 [email protected] [Cupertino] Apply RSuperellipse to most Cupertino widgets (flutter/flutter#167784) 2025-05-26 [email protected] Roll `package:dds` to 5.0.2 (flutter/flutter#169471) 2025-05-26 [email protected] Use `.flutter-plugins-dependencies` for crash reporting. (flutter/flutter#169319) 2025-05-26 [email protected] Remove now disabled code that would generate `.flutter-plugins`. (flutter/flutter#169320) 2025-05-26 [email protected] Roll Dart SDK from 7dab9bffe1f7 to d811152316e4 (1 revision) (flutter/flutter#169473) 2025-05-26 [email protected] Precise browser resizing with integration_test and driver (flutter/flutter#160678) 2025-05-26 [email protected] Add `/coverage/` to `.gitignore.tmp` (flutter/flutter#169387) 2025-05-26 [email protected] Make test output with encoded `dart-defines=...` human readable. (flutter/flutter#169353) 2025-05-26 [email protected] Use at most `PROC~/2` tasks to transform assets. (flutter/flutter#169386) 2025-05-26 [email protected] Forward exit code from dart test to flutter test (flutter/flutter#168604) 2025-05-26 [email protected] Fix warning when building for macOS desktop (flutter/flutter#165996) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…165996)

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels Mar 26, 2025

Sameri11 force-pushed the fix-macos-arch-specify branch 8 times, most recently from 76aaae0 to 2a738f8 Compare March 28, 2025 15:39

Sameri11 force-pushed the fix-macos-arch-specify branch 3 times, most recently from 112eb22 to 89bd093 Compare March 30, 2025 14:08

Sameri11 marked this pull request as ready for review March 31, 2025 15:46

Sameri11 force-pushed the fix-macos-arch-specify branch from 89bd093 to f8268f2 Compare April 21, 2025 15:57

Sameri11 requested a review from a team as a code owner April 21, 2025 15:57

vashworth self-requested a review April 21, 2025 15:58

vashworth reviewed Apr 23, 2025

View reviewed changes

packages/flutter_tools/lib/src/macos/build_macos.dart Outdated Show resolved Hide resolved

packages/flutter_tools/test/commands.shard/hermetic/build_macos_test.dart Outdated Show resolved Hide resolved

Sameri11 force-pushed the fix-macos-arch-specify branch 3 times, most recently from 267a786 to 1fc9ec6 Compare April 26, 2025 19:28

Sameri11 requested a review from vashworth April 26, 2025 20:10

vashworth approved these changes Apr 29, 2025

View reviewed changes

vashworth requested a review from bkonyi April 29, 2025 15:54

Sameri11 added 3 commits May 25, 2025 19:15

get rid of warning for both release and debug builds

19011cc

try another one

7735878

try another one

4940be7

bkonyi approved these changes May 26, 2025

View reviewed changes

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label May 26, 2025

auto-submit bot added this pull request to the merge queue May 26, 2025

Merged via the queue into flutter:master with commit 742141a May 26, 2025
143 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 26, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2025

742141a Fix warning when building for macOS desktop (flutter/flutter#…

45d58ae

…165996)

engine-flutter-autoroll mentioned this pull request May 27, 2025

Roll Flutter from 4372bfbc6c23 to 4e75d56bdab0 (13 revisions) flutter/packages#9323

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2025

742141a Fix warning when building for macOS desktop (flutter/flutter#…

f9c0b0f

…165996)

engine-flutter-autoroll mentioned this pull request May 27, 2025

Roll Flutter from 4372bfbc6c23 to 768932e97299 (14 revisions) flutter/packages#9325

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2025

742141a Fix warning when building for macOS desktop (flutter/flutter#…

0da2205

…165996)

engine-flutter-autoroll mentioned this pull request May 27, 2025

Roll Flutter from 4372bfbc6c23 to 184835f7d8f5 (15 revisions) flutter/packages#9326

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2025

742141a Fix warning when building for macOS desktop (flutter/flutter#…

efd0bde

…165996)

engine-flutter-autoroll mentioned this pull request May 27, 2025

Roll Flutter from 4372bfbc6c23 to 973701688c46 (17 revisions) flutter/packages#9327

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2025

742141a Fix warning when building for macOS desktop (flutter/flutter#…

1aa48ff

…165996)

engine-flutter-autoroll mentioned this pull request May 28, 2025

Roll Flutter from 4372bfbc6c23 to 5d013c73baa7 (26 revisions) flutter/packages#9333

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2025

742141a Fix warning when building for macOS desktop (flutter/flutter#…

830ee1b

…165996)

engine-flutter-autoroll mentioned this pull request May 28, 2025

Roll Flutter from 4372bfbc6c23 to 0e536eb9fe4b (27 revisions) flutter/packages#9334

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

742141a Fix warning when building for macOS desktop (flutter/flutter#…

8188ffb

…165996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

742141a Fix warning when building for macOS desktop (flutter/flutter#…

b2c6e40

…165996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

742141a Fix warning when building for macOS desktop (flutter/flutter#…

25818d5

…165996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

742141a Fix warning when building for macOS desktop (flutter/flutter#…

ebba2e9

…165996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

742141a Fix warning when building for macOS desktop (flutter/flutter#…

3a6ac66

…165996)

vashworth mentioned this pull request Oct 13, 2025

SwiftPM macOS - Allow limiting architecture for release builds #176605

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix warning when building for macOS desktop#165996

Fix warning when building for macOS desktop#165996
auto-submit[bot] merged 6 commits intoflutter:masterfrom
Sameri11:fix-macos-arch-specify

Sameri11 commented Mar 26, 2025 •

edited

Loading

Uh oh!

jellis206 commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

vashworth left a comment

Uh oh!

Sameri11 commented May 19, 2025

Uh oh!

bkonyi commented May 26, 2025

Uh oh!

Uh oh!

Sameri11 commented May 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Sameri11 commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

jellis206 commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

vashworth left a comment

Choose a reason for hiding this comment

Uh oh!

Sameri11 commented May 19, 2025

Uh oh!

bkonyi commented May 26, 2025

Uh oh!

Uh oh!

Sameri11 commented May 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sameri11 commented Mar 26, 2025 •

edited

Loading