Public nodes needing paint or layout#166148
Merged
auto-submit[bot] merged 10 commits intoflutter:masterfrom Mar 31, 2025
Merged
Public nodes needing paint or layout#166148auto-submit[bot] merged 10 commits intoflutter:masterfrom
auto-submit[bot] merged 10 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
the
framework
| /// when they are marked for layout. Subclasses of [PipelineOwner] may use this list | ||
| /// to invalidate caches or otherwise make performance optimizations. | ||
| @protected | ||
| List<RenderObject> get nodesNeedingLayout => _nodesNeedingLayout; |
Contributor
There was a problem hiding this comment.
I would expose these as Iterables so that its more obvious they are intended to be read only. I guess in theory adding nodes to this list shouldn't cause bugs but I wouldn't want to test that.
Contributor
Author
There was a problem hiding this comment.
Great idea, thanks! Done.
Contributor
Author
|
@chunhtai FYI, here's the PR we discussed in flutter.dev/go/ondirtycallbacks. Looks like I don't have perms to add you as a reviewer as requested. |
chunhtai
approved these changes
Mar 28, 2025
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, I am glad we can reach a solution without touching the rendering code
| /// when they are marked for layout. Subclasses of [PipelineOwner] may use them | ||
| /// to invalidate caches or otherwise make performance optimizations. | ||
| @protected | ||
| Iterable<RenderObject> get nodesNeedingLayout => _nodesNeedingLayout; |
Contributor
There was a problem hiding this comment.
FWIW, it will be tricky to pick the correct timing to safety read the dirty list, as new dirty nodes can be added in transient callbacks / microtask flushes, or as a result of widget re-build. The dirty list can even be mutated during a flushLayout call (with RenderObject.invokeLayoutCallback).
Contributor
Author
There was a problem hiding this comment.
Yes, agreed. So far, I've not had problems in practice, I think possibly because for my use-case a lot of repaint boundaries are already dirtied when they're marked in these cases (in particular, I think anything marked during invokeLayoutCallback should already be invalidated based on the docs). I am trying to add more edge cases to test though.
Contributor
There was a problem hiding this comment.
uhm sorry I didn't notice the @protected annotation. So it looks like these getters will only be accessed in subclasses' flushLayout, which works for your use case (but it would be nice if it's documented as such). Also nodesNeedingLayout does not include the dirty nodes from child / descendant PipelineOwners (although I don't think those are actually used in the framework atm).
Contributor
Author
There was a problem hiding this comment.
Good point, docs added on timing and descendant PipelineOwners.
I have a few workarounds in mind for descendant PipelineOwners (either wrapping children for instrumentation as they are adopted, or enforcing that only instrumenting PipelineOwners can be adopted or similar). Haven't quite settled on an approach yet.
Contributor
There was a problem hiding this comment.
I don't think you can "wrap" any children IIUC, PiplelineOwner is a base class so composition is probably not an option, you'll have to extend the child's class in case it's a different PipelineOwner subclass and has custom logic.
Contributor
Author
There was a problem hiding this comment.
Hmm, I think this works for my mental model, but please double check me (I'm also going to start tackling this handling ASAP to make sure it's OK!)
I was thinking the adoption flow would look like one of the following cases:
- RootPipelineOwner case: ChildPipelineOwner passed to adoptChild is wrapped with DelegatePipelineOwner, which is adopted, but passes all public API calls to ChildPipelineOwner.
- ChildPipelineOwner case: GrandchildPipelineOwner passed to ChildPipelineOwner.adoptChild, wrapped with DelegatePipeline owner, which is adopted, but passes all public API calls to GrandchildPipelineOwner.
So either way, a LayoutBuilder PipelineOwner would be wrapped in DelegatePipelineOwner when it was adopted into the pipeline tree, but would otherwise be unaffected.
I think this should work in release mode, but the _debugParent field would get messed up by this. It doesn't look like that field is used too much, but it definitely will be a little odd.
I generally think any custom logic in a descendant PipelineOwner should still be executed by this setup (since any calls to Delegate will be passed through unchanged). In fact, I'm a little more worried that I'd miss registering children with my child tracking delegates.
Contributor
There was a problem hiding this comment.
I took a closer look at #166148 (comment), I doubt that it would work:
void flushPaint() {
// This shouldn't upset the check for @protected
// since it's within an extender of PipelineOwner
doStuffWith(child.nodesNeedingPaint);
child.flushPaint();
}child.flushPaint() wouldn't do anything here, since there's no public API for adding dirty nodes to child: in markNeedsPaint render objects would add dirty nodes to this._nodsNeedingPaint instead of child._nodsNeedingPaint. That was why PipelineOwner was made a base class
Contributor
Author
There was a problem hiding this comment.
Ah, I see now. Yes, you're right, RenderObject ownership with the delegate is broken. Further, your LayoutBuilder example makes me think that mandating a subclass for all PipelineOwners also isn't practical.
I guess a more reliable solution would be a way to iterate over PipelineOwner's children. I could imagine adding either an @protected children or a visitChildren(void Function(PipelineOwner) similar to RenderObject and Element (altho I think I prefer the latter). Thoughts?
Contributor
Author
There was a problem hiding this comment.
OK, I've had my coffee now and realized that visitChildren already exists. I'm gonna try out how this would work using that in the root's onLayout/onPaint to check each child's dirty nodes.
Contributor
Author
There was a problem hiding this comment.
Using visitChildren seems to work pretty well with a child depth of 1-2. I'm gonna run with this for now, thanks again for thinking through this with me :)
justinmc
approved these changes
Mar 28, 2025
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM once the checks are passing 👍
| /// Since nodes may be marked for layout at any time, they are best checked during | ||
| /// [flushLayout]. | ||
| /// | ||
| /// Note that this does not include marked children of child [PipelineOwner]s. |
Contributor
There was a problem hiding this comment.
See that style guide on "note that": https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#avoid-empty-prose
Contributor
There was a problem hiding this comment.
+1, also maybe add that in the iterable relayout boundaries appear in arbitrary order and the same RO may appear multiple times.
Contributor
Author
There was a problem hiding this comment.
Fixed and added. Thanks!
| /// Since nodes may be marked for layout at any time, they are best checked during | ||
| /// [flushPaint]. | ||
| /// | ||
| /// Note that this does not include marked children of child [PipelineOwner]s. |
Contributor
There was a problem hiding this comment.
Another "note that" that should be rephrased.
| /// [flushLayout]. | ||
| /// | ||
| /// Note that this does not include marked children of child [PipelineOwner]s. | ||
| @protected |
Contributor
There was a problem hiding this comment.
@nonVirtual too, if you're not overriding it?
| /// when they are marked for layout. Subclasses of [PipelineOwner] may use them | ||
| /// to invalidate caches or otherwise make performance optimizations. | ||
| @protected | ||
| Iterable<RenderObject> get nodesNeedingLayout => _nodesNeedingLayout; |
Contributor
There was a problem hiding this comment.
I don't think you can "wrap" any children IIUC, PiplelineOwner is a base class so composition is probably not an option, you'll have to extend the child's class in case it's a different PipelineOwner subclass and has custom logic.
| bool _shouldMergeDirtyNodes = false; | ||
| List<RenderObject> _nodesNeedingLayout = <RenderObject>[]; | ||
|
|
||
| /// The [RenderObject]s which need to be laid out in the next [flushLayout] pass. |
Contributor
There was a problem hiding this comment.
nit: I'd say relayout boundaries since this is not a comprehensive list of dirty nodes.
|
|
||
| /// The [RenderObject]s which need to be laid out in the next [flushLayout] pass. | ||
| /// | ||
| /// [RenderObject]s with [RenderObject.isRepaintBoundary] are added |
Contributor
There was a problem hiding this comment.
This doesn't sound right. For layout we collect relayout boundaries instead of repaint boundaries.
| /// Since nodes may be marked for layout at any time, they are best checked during | ||
| /// [flushLayout]. | ||
| /// | ||
| /// Note that this does not include marked children of child [PipelineOwner]s. |
Contributor
There was a problem hiding this comment.
+1, also maybe add that in the iterable relayout boundaries appear in arbitrary order and the same RO may appear multiple times.
LongCatIsLooong
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 2, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 2, 2025
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) flutter/flutter@05b5e79...a0b1b32 2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342) 2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296) 2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654) 2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437) 2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191) 2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329) 2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321) 2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211) 2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037) 2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156) 2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301) 2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199) 2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293) 2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298) 2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299) 2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165) 2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164) 2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277) 2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727) 2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283) 2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148) 2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690) 2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884) 2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780) 2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926) 2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733) 2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964) 2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260) 2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205) 2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937) 2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178) 2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252) 2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251) 2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244) 2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236) 2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224) 2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...
masterromuald
pushed a commit
to masterromuald/packages
that referenced
this pull request
Apr 3, 2025
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) flutter/flutter@05b5e79...a0b1b32 2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342) 2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296) 2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654) 2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437) 2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191) 2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329) 2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321) 2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211) 2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037) 2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156) 2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301) 2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199) 2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293) 2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298) 2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299) 2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165) 2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164) 2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277) 2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727) 2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283) 2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148) 2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690) 2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884) 2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780) 2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926) 2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733) 2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964) 2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260) 2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205) 2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937) 2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178) 2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252) 2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251) 2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244) 2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236) 2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224) 2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...
CodixNinja
pushed a commit
to CodixNinja/packages
that referenced
this pull request
May 15, 2025
Roll Flutter from 05b5e7910544 to a0b1b3253416 (37 revisions) flutter/flutter@05b5e79...a0b1b32 2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342) 2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296) 2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654) 2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437) 2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191) 2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329) 2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321) 2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211) 2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037) 2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156) 2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301) 2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199) 2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293) 2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298) 2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299) 2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165) 2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164) 2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277) 2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727) 2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283) 2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148) 2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690) 2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884) 2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780) 2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926) 2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733) 2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964) 2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260) 2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205) 2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937) 2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178) 2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252) 2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251) 2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244) 2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236) 2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224) 2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) flutter/flutter@05b5e79...a0b1b32 2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342) 2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296) 2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654) 2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437) 2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191) 2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329) 2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321) 2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211) 2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037) 2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156) 2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301) 2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199) 2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293) 2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298) 2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299) 2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165) 2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164) 2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277) 2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727) 2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283) 2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148) 2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690) 2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884) 2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780) 2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926) 2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733) 2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964) 2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260) 2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205) 2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937) 2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178) 2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252) 2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251) 2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244) 2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236) 2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224) 2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...
zhangyuang
pushed a commit
to zhangyuang/flutter-fork
that referenced
this pull request
Jun 9, 2025
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> This PR adds 2 new `@protected` fields to `PipelineOwner` which list the RenderObjects currently needing paint or layout for the next frame. This PR addresses flutter#166147, which has further discussion of the motivation. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) flutter/flutter@05b5e79...a0b1b32 2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342) 2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296) 2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654) 2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437) 2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191) 2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329) 2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321) 2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211) 2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037) 2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156) 2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301) 2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199) 2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293) 2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298) 2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299) 2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165) 2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164) 2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277) 2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727) 2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283) 2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148) 2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690) 2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884) 2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780) 2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926) 2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733) 2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964) 2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260) 2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205) 2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937) 2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178) 2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252) 2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251) 2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244) 2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236) 2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224) 2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) flutter/flutter@05b5e79...a0b1b32 2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342) 2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296) 2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654) 2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437) 2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191) 2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329) 2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321) 2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211) 2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037) 2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156) 2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301) 2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199) 2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293) 2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298) 2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299) 2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165) 2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164) 2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277) 2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727) 2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283) 2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148) 2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690) 2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884) 2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780) 2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926) 2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733) 2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964) 2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260) 2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205) 2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937) 2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178) 2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252) 2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251) 2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244) 2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236) 2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224) 2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> This PR adds 2 new `@protected` fields to `PipelineOwner` which list the RenderObjects currently needing paint or layout for the next frame. This PR addresses flutter#166147, which has further discussion of the motivation. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new
@protectedfields toPipelineOwnerwhich list the RenderObjects currently needing paint or layout for the next frame.This PR addresses #166147, which has further discussion of the motivation.
Pre-launch Checklist
///).