Skip to content

[Impeller] small cpu perf for text contents.#166199

Merged
auto-submit[bot] merged 5 commits intoflutter:masterfrom
jonahwilliams:remove_count_stuff
Apr 1, 2025
Merged

[Impeller] small cpu perf for text contents.#166199
auto-submit[bot] merged 5 commits intoflutter:masterfrom
jonahwilliams:remove_count_stuff

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 29, 2025

  • Compute scaling matrices once per frame instead of per glyph.
  • Use index buffer to avoid performing redundant computations for second triangle.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 29, 2025
@jonahwilliams jonahwilliams requested a review from gaaclarke March 31, 2025 16:10
gaaclarke
gaaclarke reviewed Mar 31, 2025
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I think we should switch to triangle strip since we are at it. Not necessary though

engine/src/flutter/impeller/entity/contents/text_contents_unittests.cc Outdated

Rect PerVertexDataPositionToRect(
GlyphAtlasPipeline::VertexShader::PerVertexData data[6]) {
GlyphAtlasPipeline::VertexShader::PerVertexData data[4]) {
Copy link
Member

@gaaclarke gaaclarke Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Since we were refactoring these, it would have been nice to switch to std::array

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

engine/src/flutter/impeller/entity/contents/text_contents.cc
Comment on lines +326 to +331
indices[j++] = base + 0;
indices[j++] = base + 1;
indices[j++] = base + 2;
indices[j++] = base + 1;
indices[j++] = base + 2;
indices[j++] = base + 3;
Copy link
Member

@gaaclarke gaaclarke Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Switching to triangle strip would be more efficient.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glyph rects aren't connected, so switching to strip would be move overall geometry:

Before: 6 pts
This PR: 4 pts
w/ Strip: 4pts + 4 to break primitive

engine/src/flutter/impeller/entity/contents/text_contents.cc
index_count * sizeof(uint16_t), alignof(uint16_t), [&](uint8_t* data) {
uint16_t* indices = reinterpret_cast<uint16_t*>(data);
size_t j = 0;
for (auto i = 0u; i < glyph_count; i++) {
Copy link
Member

@gaaclarke gaaclarke Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to loop through everything twice. Why not calculate the index buffer in the ComputeVertexData's loop?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the way the emplace callback works, we can't easy emplace into two buffers at once unless I copy everything. I think this is still OK.

@jonahwilliams jonahwilliams requested a review from gaaclarke March 31, 2025 16:48
gaaclarke
gaaclarke approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

Revert "use std::array."
e1e5967 
This reverts commit 4c85295.
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Mar 31, 2025

reverted std::array change. We're using different sized arrays in the test, I think templating out all the helper functions is overkill for a unit test

@gaaclarke
Copy link
Member

gaaclarke commented Mar 31, 2025

reverted std::array change. We're using different sized arrays in the test, I think templating out all the helper functions is overkill for a unit test

All of those functions you changed to std::array require that the size is 4 though. Where was the problem?

@gaaclarke
Copy link
Member

gaaclarke commented Mar 31, 2025

Ugh, add this to the list of times where std::span would be useful.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Mar 31, 2025

They don't all require a size of 4, some need 8 and such...

@gaaclarke
Copy link
Member

gaaclarke commented Mar 31, 2025

They don't all require a size of 4, some need 8 and such...

The signatures you've changed all had foo[4] in the signature though. We should switch those to std::vector or raw pointers since the [4] is meaningless.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Mar 31, 2025

What are we changing to use std::array then, just l values?

@gaaclarke
Copy link
Member

gaaclarke commented Mar 31, 2025

What are we changing to use std::array then, just l values?

I was thinking the parameters. Here's my concern: when declaring parameters with int foo[4] it's functionally equivalent to int* foo but you get this false sense that it is doing something like std::array<int, 4>. I got bit by this the other day where the code was written fine, but then when it got refactored I was sending in the wrong size array and I got zero compilation or runtime feedback. I just started reading garbage memory and had to figure out why.

So, passing in std::array<int,4> x > std::vector<int> x > int* x, size_t size. I don't think there is every a good reason to use int x[4] actually.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Mar 31, 2025

Done

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 1, 2025
Merged via the queue into flutter:master with commit 49ebe50 Apr 1, 2025
172 of 173 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
49ebe50 [Impeller] small cpu perf for text contents. (flutter/flutter…
13934a4 
…#166199)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
49ebe50 [Impeller] small cpu perf for text contents. (flutter/flutter…
b1e3c25 
…#166199)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
49ebe50 [Impeller] small cpu perf for text contents. (flutter/flutter…
90e5012 
…#166199)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
49ebe50 [Impeller] small cpu perf for text contents. (flutter/flutter…
e49b88d 
…#166199)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 2, 2025
@engine-flutter-autoroll
49ebe50 [Impeller] small cpu perf for text contents. (flutter/flutter…
01996cb 
…#166199)
This was referenced Apr 2, 2025
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 2, 2025
@engine-flutter-autoroll
49ebe50 [Impeller] small cpu perf for text contents. (flutter/flutter…
3be0cec 
…#166199)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 2, 2025
@engine-flutter-autoroll
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (#8985)
8f5844a 
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions)

flutter/flutter@05b5e79...a0b1b32

2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342)
2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296)
2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654)
2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437)
2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191)
2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329)
2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321)
2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211)
2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037)
2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156)
2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301)
2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199)
2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293)
2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298)
2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299)
2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165)
2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164)
2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277)
2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727)
2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283)
2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148)
2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690)
2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884)
2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780)
2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926)
2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733)
2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964)
2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260)
2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205)
2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937)
2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178)
2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252)
2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251)
2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244)
2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236)
2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224)
2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
masterromuald pushed a commit to masterromuald/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll @masterromuald
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter#8985)
894e301 
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions)

flutter/flutter@05b5e79...a0b1b32

2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342)
2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296)
2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654)
2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437)
2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191)
2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329)
2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321)
2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211)
2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037)
2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156)
2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301)
2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199)
2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293)
2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298)
2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299)
2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165)
2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164)
2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277)
2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727)
2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283)
2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148)
2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690)
2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884)
2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780)
2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926)
2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733)
2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964)
2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260)
2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205)
2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937)
2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178)
2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252)
2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251)
2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244)
2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236)
2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224)
2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Roll Flutter from 05b5e7910544 to a0b1b3253416 (37 revisions) (#8985)
1721bf2 
Roll Flutter from 05b5e7910544 to a0b1b3253416 (37 revisions)

flutter/flutter@05b5e79...a0b1b32

2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342)
2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296)
2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654)
2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437)
2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191)
2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329)
2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321)
2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211)
2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037)
2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156)
2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301)
2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199)
2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293)
2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298)
2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299)
2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165)
2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164)
2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277)
2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727)
2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283)
2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148)
2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690)
2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884)
2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780)
2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926)
2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733)
2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964)
2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260)
2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205)
2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937)
2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178)
2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252)
2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251)
2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244)
2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236)
2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224)
2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
49ebe50 [Impeller] small cpu perf for text contents. (flutter/flutter…
5536726 
…#166199)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
49ebe50 [Impeller] small cpu perf for text contents. (flutter/flutter…
c3fc805 
…#166199)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
49ebe50 [Impeller] small cpu perf for text contents. (flutter/flutter…
5f07cb5 
…#166199)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter#8985)
315d890 
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions)

flutter/flutter@05b5e79...a0b1b32

2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342)
2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296)
2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654)
2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437)
2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191)
2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329)
2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321)
2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211)
2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037)
2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156)
2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301)
2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199)
2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293)
2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298)
2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299)
2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165)
2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164)
2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277)
2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727)
2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283)
2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148)
2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690)
2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884)
2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780)
2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926)
2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733)
2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964)
2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260)
2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205)
2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937)
2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178)
2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252)
2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251)
2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244)
2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236)
2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224)
2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
[Impeller] small cpu perf for text contents. (flutter#166199)
d1f4815 
* Compute scaling matrices once per frame instead of per glyph.
* Use index buffer to avoid performing redundant computations for second
triangle.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter#8985)
2e03ef8 
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions)

flutter/flutter@05b5e79...a0b1b32

2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342)
2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296)
2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654)
2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437)
2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191)
2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329)
2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321)
2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211)
2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037)
2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156)
2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301)
2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199)
2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293)
2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298)
2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299)
2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165)
2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164)
2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277)
2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727)
2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283)
2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148)
2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690)
2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884)
2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780)
2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926)
2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733)
2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964)
2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260)
2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205)
2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937)
2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178)
2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252)
2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251)
2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244)
2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236)
2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224)
2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter#8985)
53ee18d 
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions)

flutter/flutter@05b5e79...a0b1b32

2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342)
2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296)
2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654)
2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437)
2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191)
2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329)
2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321)
2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211)
2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037)
2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156)
2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301)
2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199)
2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293)
2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298)
2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299)
2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165)
2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164)
2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277)
2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727)
2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283)
2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148)
2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690)
2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884)
2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780)
2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926)
2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733)
2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964)
2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260)
2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205)
2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937)
2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178)
2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252)
2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251)
2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244)
2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236)
2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224)
2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@romanejaquez
[Impeller] small cpu perf for text contents. (flutter#166199)
96ebfdc 
* Compute scaling matrices once per frame instead of per glyph.
* Use index buffer to avoid performing redundant computations for second
triangle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @gaaclarke