Skip to content

[reland] Convert the Flutter Gradle Plugin entirely to Kotlin source#166676

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
gmackall:reland_fgp_final_conversion
Apr 7, 2025
Merged

[reland] Convert the Flutter Gradle Plugin entirely to Kotlin source#166676
auto-submit[bot] merged 2 commits intoflutter:masterfrom
gmackall:reland_fgp_final_conversion

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented Apr 7, 2025 •
edited
Loading

Relands #166114.

The original PR failed this postsubmit
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8718287794116896097/+/u/run_engine_dependency_proxy_test/stdout

Because

Task result:
{
  "success": false,
  "reason": "Task failed: Expected Android engine maven dependency URL to resolve to https://storage.googleapis.com/download.flutter.io. Got https://storage.googleapis.com//download.flutter.io instead"
}

which was because apparently in Groovy

String foo = ""
if (foo) { 
    // branch
}

Evaluates to false (i.e. does not take the branch). So we need to check if the engineRealm string is empty, which is what the additional commit does.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 7, 2025
@gmackall gmackall requested a review from reidbaker April 7, 2025 07:54
@gmackall
Copy link
Member Author

gmackall commented Apr 7, 2025

@reidbaker if you see this in the morning and it still looks good can you add autosubmit? no worries if not

@gmackall gmackall marked this pull request as ready for review April 7, 2025 07:55
@gmackall gmackall mentioned this pull request Apr 7, 2025
Merged
9 tasks
@gmackall gmackall requested a review from a team April 7, 2025 15:54
reidbaker
reidbaker reviewed Apr 7, 2025
View reviewed changes
packages/flutter_tools/gradle/src/main/kotlin/FlutterPlugin.kt
.toFile()
.readText()
.trim()
if (engineRealm!!.isNotEmpty()) {
Copy link
Contributor

@reidbaker reidbaker Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the groovy equivalent might be something like.

Suggested change
if (engineRealm!!.isNotEmpty()) {
if (engineRealm != null && engineRealm.isNotEmpty()) {

Where a null value would not take the path and would not crash.

Copy link
Member Author

@gmackall gmackall Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what I originally had, but the return value of the above line is always not null and therefore this gives a warning and suggests removal of the null check

Copy link
Member Author

@gmackall gmackall Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.text/trim.html returns a String

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 7, 2025
Merged via the queue into flutter:master with commit 56e11ae Apr 7, 2025
136 of 137 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
abca26f 
… source (flutter/flutter#166676)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
0bc9e82 
… source (flutter/flutter#166676)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
0aa76d6 
… source (flutter/flutter#166676)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
fc1f8dd 
… source (flutter/flutter#166676)
@gmackall gmackall mentioned this pull request Apr 7, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
b71f390 
… source (flutter/flutter#166676)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
0a0f5e1 
… source (flutter/flutter#166676)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
ee986de 
… source (flutter/flutter#166676)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
ddd36aa 
… source (flutter/flutter#166676)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
fc8fe03 
… source (flutter/flutter#166676)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
c1ee374 
… source (flutter/flutter#166676)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
0a49e60 
… source (flutter/flutter#166676)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
7a105f1 
… source (flutter/flutter#166676)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
604fbae 
… source (flutter/flutter#166676)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
efe39ba 
… source (flutter/flutter#166676)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
6405d09 
… source (flutter/flutter#166676)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
b5ca589 
… source (flutter/flutter#166676)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
9c415c8 
… source (flutter/flutter#166676)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
2797ce7 
… source (flutter/flutter#166676)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
800329f 
… source (flutter/flutter#166676)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
4ac2e1a 
… source (flutter/flutter#166676)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (#9041)
5faf596 
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@212064a...9bf18f0

2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503)
2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
nick-llewellyn pushed a commit to labrystechnology/flutter_packages that referenced this pull request Apr 23, 2025
@engine-flutter-autoroll @nick-llewellyn
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
a7e131c 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@212064a...9bf18f0

2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503)
2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 212064a3e558 to 9bf18f097137 (32 revisions) …
8f5e6a5 
…(#9041)

Manual roll Flutter from 212064a3e558 to 9bf18f097137 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@212064a...9bf18f0

2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503)
2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
0b8b8e8 
… source (flutter/flutter#166676)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
4be9f22 
… source (flutter/flutter#166676)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
56e11ae [reland] Convert the Flutter Gradle Plugin entirely to Kotlin…
9b443db 
… source (flutter/flutter#166676)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
e8d24f5 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@212064a...9bf18f0

2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503)
2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@gmackall
[reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (f…
bbfd392 
…lutter#166676)

Relands flutter#166114.

The original PR failed this postsubmit

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8718287794116896097/+/u/run_engine_dependency_proxy_test/stdout

Because 
```
Task result:
{
  "success": false,
  "reason": "Task failed: Expected Android engine maven dependency URL to resolve to https://storage.googleapis.com/download.flutter.io. Got https://storage.googleapis.com//download.flutter.io instead"
}
```
which was because apparently in Groovy
```groovy
String foo = ""
if (foo) { 
    // branch
}
```
Evaluates to false (i.e. does not take the branch). So we need to check
if the `engineRealm` string is empty, which is what the additional
commit does.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <[email protected]>
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
ad840f8 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@212064a...9bf18f0

2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503)
2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
aae1da3 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@212064a...9bf18f0

2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503)
2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@gmackall @romanejaquez
[reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (f…
25291df 
…lutter#166676)

Relands flutter#166114.

The original PR failed this postsubmit

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8718287794116896097/+/u/run_engine_dependency_proxy_test/stdout

Because 
```
Task result:
{
  "success": false,
  "reason": "Task failed: Expected Android engine maven dependency URL to resolve to https://storage.googleapis.com/download.flutter.io. Got https://storage.googleapis.com//download.flutter.io instead"
}
```
which was because apparently in Groovy
```groovy
String foo = ""
if (foo) { 
    // branch
}
```
Evaluates to false (i.e. does not take the branch). So we need to check
if the `engineRealm` string is empty, which is what the additional
commit does.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

+1 more reviewer

@ash2moon ash2moon ash2moon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gmackall @reidbaker @ash2moon