When using --local-web-sdk, use a locally built Dart SDK if one is available by jason-simmons · Pull Request #166732 · flutter/flutter

jason-simmons · 2025-04-08T02:00:24Z

If flutter_tools is run with both a local Web SDK and a local engine, then use the Dart SDK from the local engine instead of the prebuilt Dart SDK.

This enables testing of a local Wasm build with a locally patched Dart SDK by setting --local-web-sdk to the Wasm engine output and --local-engine/--local-engine-host to a local engine built with --no-prebuilt-dart-sdk.

eyebrowsoffire

I have one clarifying question, but if it works the way I'm assuming this LGTM

eyebrowsoffire · 2025-04-14T20:08:02Z

packages/flutter_tools/lib/src/artifacts.dart

  String _getDartSdkPath() {
+    // If the parent is a local engine, then use the locally built Dart SDK.
+    if (_parent.usesLocalArtifacts) {
+      return _parent.getArtifactPath(Artifact.engineDartSdkPath);


Just to clarify, this only happens if you're passing both --local-web-sdk and --local-engine, correct? I just want to make sure this doesn't happen if only --local-web-sdk is passed. (Those of us who work on the web engine very rarely actually do a full local engine build, so we don't want to accidentally pick up a stale version of the dart sdk).

Yes - if you specify --local-web-sdk and --local-engine, then this will use the Dart SDK built as part of the local engine.

If you only specify --local-web-sdk, then this will maintain the current behavior which uses the prebuilt Dart SDK.

Great, thank you!

…ailable If flutter_tools is run with both a local Web SDK and a local engine, then use the Dart SDK from the local engine instead of the prebuilt Dart SDK. This enables testing of a local Wasm build with a locally patched Dart SDK by setting --local-web-sdk to the Wasm engine output and --local-engine/--local-engine-host to a local engine built with --no-prebuilt-dart-sdk.

…ne is available (flutter/flutter#166732)

flutter/flutter@aef4718...ecabb1a 2025-04-17 [email protected] Hide error on mDNS registration failure and print warning in flutter attach (flutter/flutter#166782) 2025-04-17 [email protected] Add support for language hints in TextFields (Android only) (flutter/flutter#165554) 2025-04-17 [email protected] Roll Skia from d8f13372549d to cc2b57434651 (1 revision) (flutter/flutter#167331) 2025-04-17 [email protected] Add DropdownMenu.restorationId (flutter/flutter#166684) 2025-04-17 [email protected] Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (flutter/flutter#167325) 2025-04-17 [email protected] fix(CircularProgressIndicator.adaptive): strokeWidth default value (flutter/flutter#165370) 2025-04-17 [email protected] Remove unnecessary builder (flutter/flutter#166623) 2025-04-17 [email protected] Add a `gradle_errors.dart`entry for missing NDK source.properties file (flutter/flutter#167320) 2025-04-17 [email protected] Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) (flutter/flutter#167255) 2025-04-17 [email protected] Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (flutter/flutter#167243) 2025-04-16 [email protected] Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (flutter/flutter#167312) 2025-04-16 [email protected] Don't throw on error for mDNS when searching for Dart VML url on core devices (flutter/flutter#167135) 2025-04-16 [email protected] Fix: Localization for non zero time in 24 hours format (flutter/flutter#164885) 2025-04-16 [email protected] Updated docstrings for TextureContents (flutter/flutter#167221) 2025-04-16 [email protected] Broke cyclical dependency with dlpath and typographer. (flutter/flutter#167293) 2025-04-16 [email protected] Set an additional CMake arg in `forceNdkDownload` to make the task name align with the `BuildType` (flutter/flutter#167240) 2025-04-16 [email protected] Fix Carousel crashes when using PageStorageKey (flutter/flutter#166817) 2025-04-16 [email protected] Revert "Removed superfluous copy in license checker (#167146)" (flutter/flutter#167246) 2025-04-16 [email protected] [native assets] Roll dependencies (flutter/flutter#167287) 2025-04-16 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#167259) 2025-04-16 [email protected] Feat: Add carousel view theme (flutter/flutter#164769) 2025-04-16 [email protected] Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167261) 2025-04-16 [email protected] When using --local-web-sdk, use a locally built Dart SDK if one is available (flutter/flutter#166732) 2025-04-16 [email protected] Added emulator version to doctor (flutter/flutter#167236) 2025-04-16 [email protected] Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ailable (flutter#166732) If flutter_tools is run with both a local Web SDK and a local engine, then use the Dart SDK from the local engine instead of the prebuilt Dart SDK. This enables testing of a local Wasm build with a locally patched Dart SDK by setting --local-web-sdk to the Wasm engine output and --local-engine/--local-engine-host to a local engine built with --no-prebuilt-dart-sdk.

flutter/flutter@aef4718...ecabb1a 2025-04-17 [email protected] Hide error on mDNS registration failure and print warning in flutter attach (flutter/flutter#166782) 2025-04-17 [email protected] Add support for language hints in TextFields (Android only) (flutter/flutter#165554) 2025-04-17 [email protected] Roll Skia from d8f13372549d to cc2b57434651 (1 revision) (flutter/flutter#167331) 2025-04-17 [email protected] Add DropdownMenu.restorationId (flutter/flutter#166684) 2025-04-17 [email protected] Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (flutter/flutter#167325) 2025-04-17 [email protected] fix(CircularProgressIndicator.adaptive): strokeWidth default value (flutter/flutter#165370) 2025-04-17 [email protected] Remove unnecessary builder (flutter/flutter#166623) 2025-04-17 [email protected] Add a `gradle_errors.dart`entry for missing NDK source.properties file (flutter/flutter#167320) 2025-04-17 [email protected] Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) (flutter/flutter#167255) 2025-04-17 [email protected] Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (flutter/flutter#167243) 2025-04-16 [email protected] Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (flutter/flutter#167312) 2025-04-16 [email protected] Don't throw on error for mDNS when searching for Dart VML url on core devices (flutter/flutter#167135) 2025-04-16 [email protected] Fix: Localization for non zero time in 24 hours format (flutter/flutter#164885) 2025-04-16 [email protected] Updated docstrings for TextureContents (flutter/flutter#167221) 2025-04-16 [email protected] Broke cyclical dependency with dlpath and typographer. (flutter/flutter#167293) 2025-04-16 [email protected] Set an additional CMake arg in `forceNdkDownload` to make the task name align with the `BuildType` (flutter/flutter#167240) 2025-04-16 [email protected] Fix Carousel crashes when using PageStorageKey (flutter/flutter#166817) 2025-04-16 [email protected] Revert "Removed superfluous copy in license checker (#167146)" (flutter/flutter#167246) 2025-04-16 [email protected] [native assets] Roll dependencies (flutter/flutter#167287) 2025-04-16 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#167259) 2025-04-16 [email protected] Feat: Add carousel view theme (flutter/flutter#164769) 2025-04-16 [email protected] Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167261) 2025-04-16 [email protected] When using --local-web-sdk, use a locally built Dart SDK if one is available (flutter/flutter#166732) 2025-04-16 [email protected] Added emulator version to doctor (flutter/flutter#167236) 2025-04-16 [email protected] Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ne is available (flutter/flutter#166732)

…ailable (flutter#166732) If flutter_tools is run with both a local Web SDK and a local engine, then use the Dart SDK from the local engine instead of the prebuilt Dart SDK. This enables testing of a local Wasm build with a locally patched Dart SDK by setting --local-web-sdk to the Wasm engine output and --local-engine/--local-engine-host to a local engine built with --no-prebuilt-dart-sdk.

…ne is available (flutter/flutter#166732)

jason-simmons requested a review from eyebrowsoffire April 8, 2025 02:00

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 8, 2025

jason-simmons force-pushed the web_local_dart_sdk_3 branch from e68af95 to 7d99fa4 Compare April 8, 2025 02:03

jason-simmons changed the title ~~If flutter_tools is run with both a local Web SDK and a local engine, then use the Dart SDK from the local engine instead of the prebuilt Dart SDK~~ When using --local-web-sdk, use a locally built Dart SDK if one is available Apr 8, 2025

eyebrowsoffire approved these changes Apr 14, 2025

View reviewed changes

jason-simmons force-pushed the web_local_dart_sdk_3 branch from 7d99fa4 to 11e1cd9 Compare April 15, 2025 18:11

jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025

auto-submit bot added this pull request to the merge queue Apr 16, 2025

Merged via the queue into flutter:master with commit 7493583 Apr 16, 2025
142 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2025

7493583 When using --local-web-sdk, use a locally built Dart SDK if o…

fa947e3

…ne is available (flutter/flutter#166732)

engine-flutter-autoroll mentioned this pull request Apr 17, 2025

Roll Flutter from aef4718b3956 to ecabb1a05212 (25 revisions) flutter/packages#9104

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

7493583 When using --local-web-sdk, use a locally built Dart SDK if o…

bf16a53

…ne is available (flutter/flutter#166732)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

7493583 When using --local-web-sdk, use a locally built Dart SDK if o…

4c7c6ec

…ne is available (flutter/flutter#166732)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

7493583 When using --local-web-sdk, use a locally built Dart SDK if o…

84913b0

…ne is available (flutter/flutter#166732)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

7493583 When using --local-web-sdk, use a locally built Dart SDK if o…

56aa715

…ne is available (flutter/flutter#166732)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

7493583 When using --local-web-sdk, use a locally built Dart SDK if o…

fa813de

…ne is available (flutter/flutter#166732)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When using --local-web-sdk, use a locally built Dart SDK if one is available#166732

When using --local-web-sdk, use a locally built Dart SDK if one is available#166732
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jason-simmons:web_local_dart_sdk_3

jason-simmons commented Apr 8, 2025 •

edited

Loading

Uh oh!

eyebrowsoffire left a comment

Uh oh!

eyebrowsoffire Apr 14, 2025

Uh oh!

jason-simmons Apr 14, 2025

Uh oh!

eyebrowsoffire Apr 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jason-simmons commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eyebrowsoffire left a comment

Choose a reason for hiding this comment

Uh oh!

eyebrowsoffire Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

jason-simmons Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

eyebrowsoffire Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jason-simmons commented Apr 8, 2025 •

edited

Loading