Skip to content

Remove package:macros and package:_macros from pubspec.yaml#166749

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
alexmarkov:remove-macros-from-pubspec
Apr 9, 2025
Merged

Remove package:macros and package:_macros from pubspec.yaml#166749
auto-submit[bot] merged 1 commit intoflutter:masterfrom
alexmarkov:remove-macros-from-pubspec

Conversation

@alexmarkov
Copy link
Contributor

@alexmarkov alexmarkov commented Apr 8, 2025

Update Flutter for the upcoming removal of pkg/_macros and pkg/macros from Dart SDK: https://dart-review.googlesource.com/c/sdk/+/420680.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Apr 8, 2025
jonahwilliams
jonahwilliams approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmarkov alexmarkov marked this pull request as ready for review April 8, 2025 15:14
@alexmarkov alexmarkov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 8, 2025

autosubmit label was removed for flutter/flutter/166749, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@alexmarkov alexmarkov force-pushed the remove-macros-from-pubspec branch from 5f1b8af to 292d1e8 Compare April 8, 2025 18:02
@alexmarkov alexmarkov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 8, 2025

autosubmit label was removed for flutter/flutter/166749, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@alexmarkov alexmarkov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 9, 2025
Merged via the queue into flutter:master with commit 41c32eb Apr 9, 2025
178 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@alexmarkov alexmarkov deleted the remove-macros-from-pubspec branch April 9, 2025 03:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
fdaa817 
…lutter/flutter#166749)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
07c914d 
…lutter/flutter#166749)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
7ab6c70 
…lutter/flutter#166749)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
4c12ce0 
…lutter/flutter#166749)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
9113d82 
…lutter/flutter#166749)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
f7067ef 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
4d26c6f 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
55431bf 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
fdf92b5 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
a3fa34c 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
118e99d 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
44b12e1 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
44043a8 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
cfea2d8 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
84cce53 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
420d645 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
b77bb45 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
2a2cfd8 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
958beca 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
ddaf36d 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
a598934 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
b407d32 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
28e2da4 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
95cf08b 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
e340a19 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
7b5aa4a 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
cbd425a 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
6c87bbb 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
e6370af 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
b837fa2 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
8537bb8 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
a3192bf 
…lutter/flutter#166749)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@alexmarkov @romanejaquez
Remove package:macros and package:_macros from pubspec.yaml (flutter#…
1b5f653 
…166749)

Update Flutter for the upcoming removal of pkg/_macros and pkg/macros
from Dart SDK: https://dart-review.googlesource.com/c/sdk/+/420680.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
16c11a5 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
0c4540c 
…lutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
41c32eb Remove package:macros and package:_macros from pubspec.yaml (f…
71bf3f8 
…lutter/flutter#166749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexmarkov @jonahwilliams