feat(CheckboxListTile): ensure that 'isThreeLine' can be configured through the theme.#166826
Merged
auto-submit[bot] merged 7 commits intoflutter:masterfrom Apr 30, 2025
Merged
Conversation
…hrough the theme.
github-actions
bot
added
framework
This was referenced Apr 18, 2025
justinmc
approved these changes
Apr 24, 2025
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM with nits 👍 . Thanks for following up on this for the other classes.
|
|
||
| Widget buildFrame({bool? themeDataIsThreeLine, bool? themeIsThreeLine, bool? isThreeLine}) { | ||
| return MaterialApp( | ||
| key: UniqueKey(), |
Contributor
Author
There was a problem hiding this comment.
I believe this key is useful. Since the same widget tree is called multiple times below with slight modifications, a unique key is needed here to prevent reuse-related errors.
Contributor
There was a problem hiding this comment.
Oh I see, so you purposely want a new UniqueKey each time so that nothing gets reused. Makes sense to me.
Comment on lines
+402
to
+404
| /// If null, the value from [ListTileThemeData.isThreeLine] is used. | ||
| /// If that is also null, the value from the [ListTileThemeData] returned by [ThemeData.listTileTheme] is used. | ||
| /// If still null, the default value is `false`. |
Contributor
There was a problem hiding this comment.
Nit: I think this exceeds the 80 character limit.
Contributor
Author
There was a problem hiding this comment.
Updated, thank you.
justinmc
approved these changes
Apr 30, 2025
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . I'll add autosubmit, but heads up that there may be other PRs about to merge that could cause a conflict with this one.
|
|
||
| Widget buildFrame({bool? themeDataIsThreeLine, bool? themeIsThreeLine, bool? isThreeLine}) { | ||
| return MaterialApp( | ||
| key: UniqueKey(), |
Contributor
There was a problem hiding this comment.
Oh I see, so you purposely want a new UniqueKey each time so that nothing gets reused. Makes sense to me.
justinmc
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…igured through the theme. (flutter/flutter#166826)
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2025
…gh the (#166964) This PR is a continuation of [165481](#165481) Related items also include: [SwitchListTile](#166820), [CheckboxListTile](#166826) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Tong Mu <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2025
…ough the theme. (#166820) This PR is a continuation of [165481](#165481) Related items also include: [RadioListTile](#166964), [CheckboxListTile](#166826) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
…igured through the theme. (flutter/flutter#166826)
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
May 6, 2025
…gh the (flutter#166964) This PR is a continuation of [165481](flutter#165481) Related items also include: [SwitchListTile](flutter#166820), [CheckboxListTile](flutter#166826) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Tong Mu <[email protected]>
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
May 6, 2025
…ough the theme. (flutter#166820) This PR is a continuation of [165481](flutter#165481) Related items also include: [RadioListTile](flutter#166964), [CheckboxListTile](flutter#166826) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…igured through the theme. (flutter/flutter#166826)
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…hrough the theme. (flutter#166826) This PR is a continuation of [165481](flutter#165481) Related items also include: [SwitchListTile](flutter#166820), [RadioListTile](flutter#166964) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…igured through the theme. (flutter/flutter#166826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
…igured through the theme. (flutter/flutter#166826)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of 165481
Related items also include: SwitchListTile, RadioListTile
Pre-launch Checklist
///).