Reverts "[Impeller] Speed up vulkan startup time by re-using existing vulkan context. (#166784)"#166938
Merged
auto-submit[bot] merged 1 commit intomasterfrom Apr 10, 2025
Conversation
auto-submit
bot
added
the
revert of
github-actions
bot
added
platform-android
fluttergithubbot
approved these changes
Apr 10, 2025
auto-submit
bot
deleted the
revert_b55ffbff8ed4491ab004acb8e459c688b735ce1a
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 13, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
… vulkan context. (flutter#166784)" (flutter#166938) <!-- start_original_pr_link --> Reverts: flutter#166784 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: jonahwilliams <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: didn't do enough, going to try something different. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: jonahwilliams <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {matanlurey} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Once we've created the Vulkan context, lets just use it - creating it isn't free. See numbers. Also change AHB swapchain to lazily create images, which will also improve startup and will be added to an opt in list to test startup performance. ``` ════════════════════════════╡ ••• Raw results ••• ╞═════════════════════════════ timeToFirstFrameMicros: A: 371525.00 225155.00 B: 254054.00 254668.00 timeToFirstFrameRasterizedMicros: A: 781015.00 555791.00 B: 527163.00 526827.00 ═════════════════════════╡ ••• Final A/B results ••• ╞══════════════════════════ Score Average A (noise) Average B (noise) Speed-up timeToFirstFrameMicros 298340.00 (24.53%) 254361.00 (0.12%) 1.17x timeToFirstFrameRasterizedMicros 668403.00 (16.85%) 526995.00 (0.03%) 1.27x ``` <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
…existing vulkan context. (#166784)" (flutter/flutter#166938)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts: #166784
Initiated by: jonahwilliams
Reason for reverting: didn't do enough, going to try something different.
Original PR Author: jonahwilliams
Reviewed By: {matanlurey}
This change reverts the following previous change:
Once we've created the Vulkan context, lets just use it - creating it isn't free. See numbers. Also change AHB swapchain to lazily create images, which will also improve startup and will be added to an opt in list to test startup performance.